Attachment 370329 Details for Bug 197286 – Patch

[patch] Patch

bug-197286-20190521110844.patch (text/plain), 3.97 KB, created by Said Abou-Hallawa on 2019-05-21 11:08:45 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Said Abou-Hallawa

Created: 2019-05-21 11:08:45 PDT

Size: 3.97 KB

patch

obsolete

>Index: LayoutTests/ChangeLog
>===================================================================
>--- LayoutTests/ChangeLog	(revision 245583)
>+++ LayoutTests/ChangeLog	(working copy)
>@@ -1,3 +1,12 @@
>+2019-05-21  Said Abou-Hallawa  <sabouhallawa@apple.com>
>+
>+        REGRESSION (r244182) [Mac WK2] Layout Test imported/w3c/web-platform-tests/visual-viewport/viewport-resize-event-on-load-overflowing-page.html is a flaky failure
>+        https://bugs.webkit.org/show_bug.cgi?id=197286
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * platform/mac-wk2/TestExpectations:
>+
> 2019-05-21  Antti Koivisto  <antti@apple.com>
> 
>         RTL/overflow scroll tests fail with async overflow enabled
>Index: LayoutTests/imported/w3c/ChangeLog
>===================================================================
>--- LayoutTests/imported/w3c/ChangeLog	(revision 245583)
>+++ LayoutTests/imported/w3c/ChangeLog	(working copy)
>@@ -1,3 +1,20 @@
>+2019-05-21  Said Abou-Hallawa  <sabouhallawa@apple.com>
>+
>+        REGRESSION (r244182) [Mac WK2] Layout Test imported/w3c/web-platform-tests/visual-viewport/viewport-resize-event-on-load-overflowing-page.html is a flaky failure
>+        https://bugs.webkit.org/show_bug.cgi?id=197286
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        This is a time sensitive test. It expects to receive a resize event within
>+        two frames after the page load. Scheduling the page update through the 
>+        RenderingUpdate made updating the page for the first time happens not 
>+        immediately after the page load but after an additional frame.
>+
>+        So we need to wait for this additional frame before checking whether the
>+        'resize' event was fired.
>+
>+        * web-platform-tests/visual-viewport/viewport-resize-event-on-load-overflowing-page.html:
>+
> 2019-05-17  Rob Buis  <rbuis@igalia.com>
> 
>         Implement imagesrcset and imagesizes attributes on link rel=preload
>Index: LayoutTests/imported/w3c/web-platform-tests/visual-viewport/viewport-resize-event-on-load-overflowing-page.html
>===================================================================
>--- LayoutTests/imported/w3c/web-platform-tests/visual-viewport/viewport-resize-event-on-load-overflowing-page.html	(revision 245583)
>+++ LayoutTests/imported/w3c/web-platform-tests/visual-viewport/viewport-resize-event-on-load-overflowing-page.html	(working copy)
>@@ -26,9 +26,15 @@
>                 });
> 
>                 window.addEventListener('load', function() {
>-                  requestAnimationFrame(function() {
>-                    requestAnimationFrame(
>-                        t.step_func_done(function() {
>+                    var count = 0;
>+                    requestAnimationFrame(function step() {
>+                        // Wait for two RenderingUpdates before checking the value of numViewResizes.
>+                        if (count++ < 2) {
>+                            requestAnimationFrame(step);
>+                            return;
>+                        }
>+
>+                        requestAnimationFrame(t.step_func_done(function() {
>                             var isOverlay = calculateScrollbarThickness() == 0;
>                             assert_equals(numViewResizes, isOverlay ? 0 : 1);
>                         }));
>Index: LayoutTests/platform/mac-wk2/TestExpectations
>===================================================================
>--- LayoutTests/platform/mac-wk2/TestExpectations	(revision 245583)
>+++ LayoutTests/platform/mac-wk2/TestExpectations	(working copy)
>@@ -933,8 +933,6 @@ webkit.org/b/197285 [ Debug ] http/tests
> 
> webkit.org/b/197207 http/wpt/resource-timing/rt-resources-per-frame.html [ Pass Failure ]
> 
>-webkit.org/b/197286 imported/w3c/web-platform-tests/visual-viewport/viewport-resize-event-on-load-overflowing-page.html [ Pass Failure ]
>-
> webkit.org/b/197425 [ Mojave Debug ] scrollingcoordinator/scrolling-tree/scrolling-tree-includes-frame.html [ Pass Failure ]
> 
> webkit.org/b/197662 [ Debug ] imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-getStats.https.html [ Pass Failure ]

Actions: View | Formatted Diff | Diff

Attachments on bug 197286: 370329