Attachment 370231 Details for Bug 198029 – Patch

[patch] Patch

patch.txt (text/plain), 1.64 KB, created by Nikita Vasilyev on 2019-05-19 18:02:46 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Nikita Vasilyev

Created: 2019-05-19 18:02:46 PDT

Size: 1.64 KB

patch

obsolete

>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
>index d76efb6430c..0e2257e07f2 100644
>--- a/Source/WebInspectorUI/ChangeLog
>+++ b/Source/WebInspectorUI/ChangeLog
>@@ -1,3 +1,13 @@
>+2019-05-19  Nikita Vasilyev  <nvasilyev@apple.com>
>+
>+        Web Inspector: Display "Resource has no content" for about:blank iframes instead of an error
>+        https://bugs.webkit.org/show_bug.cgi?id=198029
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * UserInterface/Views/ResourceContentView.js:
>+        (WI.ResourceContentView):
>+
> 2019-05-17  Devin Rousso  <drousso@apple.com>
> 
>         Web Inspector: Timelines: CPU/memory timeline bars sometimes don't draw correctly and jump around on scrolling
>diff --git a/Source/WebInspectorUI/UserInterface/Views/ResourceContentView.js b/Source/WebInspectorUI/UserInterface/Views/ResourceContentView.js
>index ef4867a3f53..45b15791225 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/ResourceContentView.js
>+++ b/Source/WebInspectorUI/UserInterface/Views/ResourceContentView.js
>@@ -36,6 +36,12 @@ WI.ResourceContentView = class ResourceContentView extends WI.ContentView
> 
>         this.element.classList.add(styleClassName, "resource");
> 
>+        // <iframe src="about:blank" srcdoc="..."> has url "about:srcdoc".
>+        if (resource.url === "about:blank") {
>+            this.showGenericNoContentMessage();
>+            return;
>+        }
>+
>         this._spinnerTimeout = setTimeout(() => {
>             // Append a spinner while waiting for contentAvailable. Subclasses are responsible for
>             // removing the spinner before showing the resource content by calling removeLoadingIndicator.

Flags:

hi: review-

Actions: View | Formatted Diff | Diff

Attachments on bug 198029: 370230 | 370231 | 370232 | 372981 | 372982 | 372985 | 372989 | 373590 | 373900 | 374642 | 374709