Attachment 370191 Details for Bug 197814 – To check ews result

[patch] To check ews result

bug-197814-20190519011255.patch (text/plain), 5.37 KB, created by Joonghun Park on 2019-05-18 09:12:56 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Joonghun Park

Created: 2019-05-18 09:12:56 PDT

Size: 5.37 KB

patch

obsolete

>Subversion Revision: 245499
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 571497342240f02fbf2324b49c75c68f57e010e2..9da5f63a21ea1271b2faeef6fbddf9305ad6ebc5 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,23 @@
>+2019-05-18  Joonghun Park  <pjh0718@gmail.com>
>+
>+        Make computed width of non-replaced inline return computed style.
>+        https://bugs.webkit.org/show_bug.cgi?id=197814
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Currently, Computed width of non-replaced inline incorrectly returns "auto"
>+        instead of the computed value.
>+        This patch changes the behavior according to
>+        https://drafts.csswg.org/cssom/#resolved-value as below.
>+
>+        'If the property applies to the element or pseudo-element
>+        and the resolved value of the display property is not none or contents,
>+        then the resolved value is the used value.
>+        Otherwise the resolved value is the computed value.'
>+
>+        * css/CSSComputedStyleDeclaration.cpp:
>+        (WebCore::ComputedStyleExtractor::valueForPropertyinStyle):
>+
> 2019-05-17  Joonghun Park  <pjh0718@gmail.com>
> 
>         Implement CSS `display: flow-root` (modern clearfix)
>diff --git a/Source/WebCore/css/CSSComputedStyleDeclaration.cpp b/Source/WebCore/css/CSSComputedStyleDeclaration.cpp
>index f2dc6b7bd26c55972f83597191f6fb9b9b75a8bd..745c1348957934f3292701217b2ddc2f7d6544b5 100644
>--- a/Source/WebCore/css/CSSComputedStyleDeclaration.cpp
>+++ b/Source/WebCore/css/CSSComputedStyleDeclaration.cpp
>@@ -3190,9 +3190,8 @@ RefPtr<CSSValue> ComputedStyleExtractor::valueForPropertyinStyle(const RenderSty
>             if (renderer && !renderer->isRenderSVGModelObject()) {
>                 // According to http://www.w3.org/TR/CSS2/visudet.html#the-height-property,
>                 // the "height" property does not apply for non-replaced inline elements.
>-                if (isNonReplacedInline(*renderer))
>-                    return cssValuePool.createIdentifierValue(CSSValueAuto);
>-                return zoomAdjustedPixelValue(sizingBox(*renderer).height(), style);
>+                if (!isNonReplacedInline(*renderer))
>+                    return zoomAdjustedPixelValue(sizingBox(*renderer).height(), style);
>             }
>             return zoomAdjustedPixelValueForLength(style.height(), style);
>         case CSSPropertyWebkitHyphens:
>@@ -3513,9 +3512,8 @@ RefPtr<CSSValue> ComputedStyleExtractor::valueForPropertyinStyle(const RenderSty
>             if (renderer && !renderer->isRenderSVGModelObject()) {
>                 // According to http://www.w3.org/TR/CSS2/visudet.html#the-width-property,
>                 // the "width" property does not apply for non-replaced inline elements.
>-                if (isNonReplacedInline(*renderer))
>-                    return cssValuePool.createIdentifierValue(CSSValueAuto);
>-                return zoomAdjustedPixelValue(sizingBox(*renderer).width(), style);
>+                if (!isNonReplacedInline(*renderer))
>+                    return zoomAdjustedPixelValue(sizingBox(*renderer).width(), style);
>             }
>             return zoomAdjustedPixelValueForLength(style.width(), style);
>         case CSSPropertyWillChange:
>diff --git a/LayoutTests/imported/w3c/ChangeLog b/LayoutTests/imported/w3c/ChangeLog
>index b9152e70ec7431af4639ac248704d180f93bffd1..112234fa633deb88354d021adab50e1a4fe56554 100644
>--- a/LayoutTests/imported/w3c/ChangeLog
>+++ b/LayoutTests/imported/w3c/ChangeLog
>@@ -1,3 +1,22 @@
>+2019-05-18  Joonghun Park  <pjh0718@gmail.com>
>+
>+        Make computed width of non-replaced inline return computed style.
>+        https://bugs.webkit.org/show_bug.cgi?id=197814
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Currently, Computed width of non-replaced inline incorrectly returns "auto"
>+        instead of the computed value.
>+        This patch changes the behavior according to
>+        https://drafts.csswg.org/cssom/#resolved-value as below.
>+
>+        'If the property applies to the element or pseudo-element
>+        and the resolved value of the display property is not none or contents,
>+        then the resolved value is the used value.
>+        Otherwise the resolved value is the computed value.'
>+
>+        * web-platform-tests/html/semantics/embedded-content/the-object-element/object-attributes-expected.txt:
>+
> 2019-05-17  Rob Buis  <rbuis@igalia.com>
> 
>         Implement imagesrcset and imagesizes attributes on link rel=preload
>diff --git a/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-object-element/object-attributes-expected.txt b/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-object-element/object-attributes-expected.txt
>index e9f22e17ccc57c0731f0fb1f975006805bc7cd26..af6912126d451124ac73357fff0d98ff2aecbeda 100644
>--- a/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-object-element/object-attributes-expected.txt
>+++ b/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-object-element/object-attributes-expected.txt
>@@ -1,5 +1,5 @@
> 
> FAIL object.contentWindow assert_equals: The contentWindow's name of the object element should be 'o1'. expected "o1" but got "o"
>-FAIL object.width assert_equals: The width should be 100px. expected "100px" but got "auto"
>-FAIL object.height assert_equals: The height should be 50px. expected "50px" but got "auto"
>+PASS object.width 
>+PASS object.height 
>

Actions: View | Formatted Diff | Diff

Attachments on bug 197814: 370191 | 370192 | 370193 | 370194 | 370195 | 370196 | 370205 | 370210 | 370211 | 370212 | 370213 | 370214 | 370217 | 370221 | 370585