Attachment 370162 Details for Bug 197511 – Patch

[patch] Patch

bug-197511-20190517153152.patch (text/plain), 3.67 KB, created by Andres Gonzalez on 2019-05-17 15:31:53 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Andres Gonzalez

Created: 2019-05-17 15:31:53 PDT

Size: 3.67 KB

patch

obsolete

>Subversion Revision: 245007
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index 8b1d32e90313c2d2d32d911a040b43f940b75629..d73bc12fdfbe0c76ca63dc8c6a30d89e282d47df 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,15 @@
>+2019-05-17  Andres Gonzalez  <andresg_22@apple.com>
>+
>+        Hitpoint for link which spans two lines in web content is incorrect
>+        https://bugs.webkit.org/show_bug.cgi?id=197511
>+        <rdar://problem/49971483>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * accessibility/ios-simulator/links-activation.html:
>+        * accessibility/links-activation-expected.txt:
>+        * accessibility/links-activation.html:
>+
> 2019-05-07  Antti Koivisto  <antti@apple.com>
> 
>         <body> with overflow:hidden CSS is scrollable on iOS
>diff --git a/LayoutTests/accessibility/ios-simulator/links-activation.html b/LayoutTests/accessibility/ios-simulator/links-activation.html
>index eb52158c5ad3dda3be973ca3782bf09af28d5429..cf53d55f32be9ef357162d69f0507f0bc9ec1d4c 100644
>--- a/LayoutTests/accessibility/ios-simulator/links-activation.html
>+++ b/LayoutTests/accessibility/ios-simulator/links-activation.html
>@@ -37,8 +37,6 @@ if (window.testRunner)
>     };
> 
>     if (window.accessibilityController) {
>-        window.jsTestIsAsync = true;
>-
>         var link = accessibilityController.accessibleElementById("multiline-link");
>         shouldBeTrue("clickPointInsideFrame(link)");
>         link.press();
>@@ -46,11 +44,6 @@ if (window.testRunner)
>         link = accessibilityController.accessibleElementById("singleline-link");
>         shouldBeTrue("clickPointInsideFrame(link)");
>         link.press();
>-
>-        setTimeout(
>-            function() {
>-                finishJSTest();
>-            }, 10);
>     }
> </script>
> 
>diff --git a/LayoutTests/accessibility/links-activation-expected.txt b/LayoutTests/accessibility/links-activation-expected.txt
>index faa4dd2c100469f4f1574d5008f25ed4f022faae..5b565eb5c5b455758451cc4a2ebd8ef10dda09a4 100644
>--- a/LayoutTests/accessibility/links-activation-expected.txt
>+++ b/LayoutTests/accessibility/links-activation-expected.txt
>@@ -12,7 +12,9 @@ On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE
> 
> 
> click event [object MouseEvent] for element A with id multiline-link
>+PASS clicked became true
> click event [object MouseEvent] for element A with id singleline-link
>+PASS clicked became true
> PASS successfullyParsed is true
> 
> TEST COMPLETE
>diff --git a/LayoutTests/accessibility/links-activation.html b/LayoutTests/accessibility/links-activation.html
>index 0d3e9296393960eaf2176f07320a84ecec68629d..6ffc30c1de737df0cec71e388ad63f9c62d9bc9a 100644
>--- a/LayoutTests/accessibility/links-activation.html
>+++ b/LayoutTests/accessibility/links-activation.html
>@@ -6,7 +6,9 @@
> if (window.testRunner)
>     testRunner.dumpAsText();
> 
>+var clicked = false;
> function handleClick(event) {
>+    clicked = true;
>     debug("click event " + event
>           + " for element " + event.target.nodeName
>           + " with id " + event.target.id);
>@@ -35,14 +37,15 @@ function handleClick(event) {
> 
>         var link = accessibilityController.accessibleElementById("multiline-link");
>         link.press();
>+        shouldBecomeEqual("clicked", "true", function() {
>+            clicked = false;
> 
>-        link = accessibilityController.accessibleElementById("singleline-link");
>-        link.press();
>-
>-        setTimeout(
>-            function() {
>+            link = accessibilityController.accessibleElementById("singleline-link");
>+            link.press();
>+            shouldBecomeEqual("clicked", "true", function() {
>                 finishJSTest();
>-            }, 10);
>+            });
>+        });
>     }
> </script>
>

Actions: View | Formatted Diff | Diff

Attachments on bug 197511: 368773 | 368785 | 368810 | 368870 | 368873 | 368879 | 368887 | 368889 | 368894 | 368923 | 368928 | 368930 | 368931 | 368934 | 368935 | 368945 | 368954 | 368956 | 368957 | 368960 | 368963 | 368964 | 368966 | 368967 | 368971 | 368973 | 368982 | 368993 | 369006 | 369008 | 369019 | 369020 | 369022 | 369097 | 369114 | 370160 | 370162