Attachment 370161 Details for Bug 197971 – Fix to check the EGL version at compile time

[patch] Fix to check the EGL version at compile time

0001-PATCH-v2-egl-GLContextEGL.cpp-Check-the-spported-EGL-version-.patch (text/plain), 2.22 KB, created by Mads on 2019-05-17 15:27:21 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Mads

Created: 2019-05-17 15:27:21 PDT

Size: 2.22 KB

patch

obsolete

>Index: Source/WebCore/ChangeLog
>===================================================================
>--- Source/WebCore/ChangeLog	(revision 245483)
>+++ Source/WebCore/ChangeLog	(working copy)
>@@ -1,3 +1,16 @@
>+2019-05-17  Madhurkiran Harikrishnan  <madhurkiran.harikrishnan@xilinx.com>
>+
>+        egl: GLContextEGL.cpp: Check the spported EGL version at compile time
>+        https://bugs.webkit.org/show_bug.cgi?id=197971
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        EGL providers/headers will not provide macro definitions for higher EGL
>+        version. Hence, check the supported EGL version at compile time.
>+
>+        * platform/graphics/egl/GLContextEGL.cpp:
>+        (WebCore::GLContextEGL::createContextForEGLVersion):
>+
> 2019-05-17  Antoine Quint  <graouts@apple.com>
> 
>         Add a website policy to disable the legacy -webkit-overflow-scrolling:touch behavior
>Index: Source/WebCore/platform/graphics/egl/GLContextEGL.cpp
>===================================================================
>--- Source/WebCore/platform/graphics/egl/GLContextEGL.cpp	(revision 245483)
>+++ Source/WebCore/platform/graphics/egl/GLContextEGL.cpp	(working copy)
>@@ -401,7 +401,7 @@ EGLContext GLContextEGL::createContextFo
>         // we'll use whatever is available. In order to request a concrete version of OpenGL we need EGL version
>         // 1.5 or EGL version 1.4 with the extension EGL_KHR_create_context.
>         EGLContext context = EGL_NO_CONTEXT;
>-
>+#ifdef EGL_VERSION_1_5
>         if (platformDisplay.eglCheckVersion(1, 5)) {
>             contextAttributes[0] = EGL_CONTEXT_MAJOR_VERSION;
>             contextAttributes[1] = 3;
>@@ -414,6 +414,9 @@ EGLContext GLContextEGL::createContextFo
>             // Try to create a context with this configuration.
>             context = eglCreateContext(platformDisplay.eglDisplay(), config, sharingContext, contextAttributes);
>         } else if (platformDisplay.eglCheckVersion(1, 4)) {
>+#else
>+        if (platformDisplay.eglCheckVersion(1, 4)) {
>+#endif
>             const char* extensions = eglQueryString(platformDisplay.eglDisplay(), EGL_EXTENSIONS);
>             if (GLContext::isExtensionSupported(extensions, "EGL_KHR_create_context")) {
>                 contextAttributes[0] = EGL_CONTEXT_MAJOR_VERSION_KHR;

Flags:

mcatanzaro: review+
mcatanzaro: commit-queue-

Actions: View | Formatted Diff | Diff

Attachments on bug 197971: 370090 | 370161 | 370304 | 370343 | 370881