Attachment 370154 Details for Bug 198003 – Patch

[patch] Patch

bug-198003-20190517143957.patch (text/plain), 1.65 KB, created by Ross Kirsling on 2019-05-17 14:40:00 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Ross Kirsling

Created: 2019-05-17 14:40:00 PDT

Size: 1.65 KB

patch

obsolete

>Subversion Revision: 245407
>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
>index eafa215585124fc48807022fe0541ed3c2d3ad7e..b2c06c883b561880b9bfe3339ff14410c4a25ec1 100644
>--- a/Source/WebInspectorUI/ChangeLog
>+++ b/Source/WebInspectorUI/ChangeLog
>@@ -1,3 +1,14 @@
>+2019-05-17  Ross Kirsling  <ross.kirsling@sony.com>
>+
>+        REGRESSION(r244350): Web Inspector: Storage tab data grids aren't editable.
>+        https://bugs.webkit.org/show_bug.cgi?id=198003
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * UserInterface/Views/DOMStorageContentView.js:
>+        (WI.DOMStorageContentView):
>+        Fix typo.
>+
> 2019-05-09  Devin Rousso  <drousso@apple.com>
> 
>         Web Inspector: Uncaught Exception: null is not an object (evaluating 'resource.parentFrame.securityOrigin')
>diff --git a/Source/WebInspectorUI/UserInterface/Views/DOMStorageContentView.js b/Source/WebInspectorUI/UserInterface/Views/DOMStorageContentView.js
>index 2cd7e042d4439913b127590484a2667f850c97e5..c08ccbd163fabe71cce456c1dce7b9920d499e16 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/DOMStorageContentView.js
>+++ b/Source/WebInspectorUI/UserInterface/Views/DOMStorageContentView.js
>@@ -42,7 +42,7 @@ WI.DOMStorageContentView = class DOMStorageContentView extends WI.ContentView
>         columns.value = {title: WI.UIString("Value"), sortable: true};
> 
>         this._dataGrid = new WI.DataGrid(columns, {
>-            editingCallback: this._editingCallback.bind(this),
>+            editCallback: this._editingCallback.bind(this),
>             copyCallback: this._dataGridCopy.bind(this),
>             deleteCallback: this._deleteCallback.bind(this),
>         });

Actions: View | Formatted Diff | Diff

Attachments on bug 198003: 370154