Attachment 370153 Details for Bug 197996 – Patch

[patch] Patch

bug-197996-20190517173427.patch (text/plain), 1.64 KB, created by Aakash Jain on 2019-05-17 14:34:28 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Aakash Jain

Created: 2019-05-17 14:34:28 PDT

Size: 1.64 KB

patch

obsolete

>Index: Tools/ChangeLog
>===================================================================
>--- Tools/ChangeLog	(revision 245476)
>+++ Tools/ChangeLog	(working copy)
>@@ -1,3 +1,12 @@
>+2019-05-17  Aakash Jain  <aakash_jain@apple.com>
>+
>+        [ews-build] Add clickable url in UI for uploaded S3 archive
>+        https://bugs.webkit.org/show_bug.cgi?id=197996
>+
>+        Reviewed by Jonathan Bedard.
>+
>+        * BuildSlaveSupport/ews-build/steps.py:
>+
> 2019-05-17  Keith Rollin  <krollin@apple.com>
> 
>         Unreviewed build fix.
>Index: Tools/BuildSlaveSupport/ews-build/steps.py
>===================================================================
>--- Tools/BuildSlaveSupport/ews-build/steps.py	(revision 245476)
>+++ Tools/BuildSlaveSupport/ews-build/steps.py	(working copy)
>@@ -790,7 +790,18 @@ class TransferToS3(master.MasterShellCom
>         kwargs['command'] = self.command
>         master.MasterShellCommand.__init__(self, logEnviron=False, **kwargs)
> 
>+    def start(self):
>+        self.log_observer = logobserver.BufferLogObserver(wantStderr=True)
>+        self.addLogObserver('stdio', self.log_observer)
>+        return super(TransferToS3, self).start()
>+
>     def finished(self, results):
>+        log_text = self.log_observer.getStdout() + self.log_observer.getStderr()
>+        match = re.search(r'S3 URL: (?P<url>[^\s]+)', log_text)
>+        # Sample log: S3 URL: https://s3-us-west-2.amazonaws.com/ews-archives.webkit.org/ios-simulator-12-x86_64-release/123456.zip
>+        if match:
>+            self.addURL('uploaded archive', match.group('url'))
>+
>         if results == SUCCESS:
>             triggers = self.getProperty('triggers', None)
>             if triggers:

Actions: View | Formatted Diff | Diff

Attachments on bug 197996: 370148 | 370153