Attachment 370137 Details for Bug 197955 – Patch

[patch] Patch

bug-197955-20190517160902.patch (text/plain), 3.13 KB, created by Jamal Nasser on 2019-05-17 13:09:03 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Jamal Nasser

Created: 2019-05-17 13:09:03 PDT

Size: 3.13 KB

patch

obsolete

>Index: Source/WebInspectorUI/ChangeLog
>===================================================================
>--- Source/WebInspectorUI/ChangeLog	(revision 245474)
>+++ Source/WebInspectorUI/ChangeLog	(working copy)
>@@ -1,3 +1,18 @@
>+2019-05-17  Jamal Nasser  <jamaln@mail.com>
>+
>+        Web Inspector: Dark Mode: Fix colors in network table waterfall container
>+        https://bugs.webkit.org/show_bug.cgi?id=197955
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * UserInterface/Views/NetworkTableContentView.css:
>+        (.network-table :not(.header) .cell.waterfall .waterfall-container > .dom-event):
>+        (.network-table :not(.header) .cell.waterfall .waterfall-container > .dom-activity):
>+        (.network-table :not(.header) .cell.waterfall .waterfall-container > .area.dom-fullscreen):
>+        * UserInterface/Views/Variables.css:
>+        (@media (prefers-color-scheme: dark)):
>+        (:root):
>+
> 2019-05-09  Devin Rousso  <drousso@apple.com>
> 
>         Web Inspector: Uncaught Exception: null is not an object (evaluating 'resource.parentFrame.securityOrigin')
>Index: Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.css
>===================================================================
>--- Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.css	(revision 245400)
>+++ Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.css	(working copy)
>@@ -184,14 +184,14 @@ body[dir=rtl] .network-table .cell.name 
>     top: calc(50% - (var(--node-waterfall-dom-event-size) / 2));
>     min-width: var(--node-waterfall-dom-event-size);
>     height: var(--node-waterfall-dom-event-size);
>-    background-color: var(--selected-background-color);
>+    background-color: var(--selected-background-color-active);
>     border-radius: calc(var(--node-waterfall-dom-event-size) / 2);
> }
> 
> .network-table :not(.header) .cell.waterfall .waterfall-container > .dom-activity {
>     position: absolute;
>     top: calc(50% - 0.5px);
>-    border-top: 1px dashed var(--selected-background-color);
>+    border-top: 1px dashed var(--selected-background-color-active);
> }
> 
> .network-table :not(.header) .cell.waterfall .waterfall-container > .dom-activity.playing {
>@@ -208,7 +208,7 @@ body[dir=rtl] .network-table .cell.name 
> }
> 
> .network-table :not(.header) .cell.waterfall .waterfall-container > .area.dom-fullscreen {
>-    background-color: hsla(0, 0%, 75%, 0.75);
>+    background-color: var(--network-waterfall-fullscreen-area-color);
> }
> 
> .network-table :not(.header) .cell.waterfall .waterfall-container > .area.power-efficient-playback {
>Index: Source/WebInspectorUI/UserInterface/Views/Variables.css
>===================================================================
>--- Source/WebInspectorUI/UserInterface/Views/Variables.css	(revision 245400)
>+++ Source/WebInspectorUI/UserInterface/Views/Variables.css	(working copy)
>@@ -305,6 +305,7 @@ body.window-inactive * {
>         --network-system-color: hsl(79, 95%, 50%);
>         --network-pseudo-header-color: hsl(312, 55%, 61%);
>         --network-error-color: hsl(0, 54%, 55%);
>+        --network-waterfall-fullscreen-area-color: hsla(0, 0%, 40%);
> 
>         --cpu-overlay-color: hsl(35, 88%, 45%);
>

Actions: View | Formatted Diff | Diff

Attachments on bug 197955: 370055 | 370056 | 370060 | 370137 | 370139 | 370143