Attachment 370096 Details for Bug 197951 – Patch

[patch] Patch

bug-197951-20190516180003.patch (text/plain), 3.70 KB, created by Devin Rousso on 2019-05-16 18:00:04 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Devin Rousso

Created: 2019-05-16 18:00:04 PDT

Size: 3.70 KB

patch

obsolete

>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
>index eafa215585124fc48807022fe0541ed3c2d3ad7e..f102a17e007a1821a6503ef351fc2b8059bf2243 100644
>--- a/Source/WebInspectorUI/ChangeLog
>+++ b/Source/WebInspectorUI/ChangeLog
>@@ -1,3 +1,29 @@
>+2019-05-16  Devin Rousso  <drousso@apple.com>
>+
>+        Web Inspector: clicking a source link should never open the Network tab
>+        https://bugs.webkit.org/show_bug.cgi?id=197951
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        The preview panel in the Network tab is really meant to be just that; a preview.
>+
>+        Opening resources in the preview panel is not a great experience, as the Network tab doesn't
>+        have as much of the information one would expect when viewing a resource (namely the
>+        Resource details sidebar panel).
>+
>+        Navigating within the Network tab also completely wipes out the current "state" of what
>+        you're looking at (e.g. which panel), which could be unexpected.
>+
>+        The only way this could happen previously was if the Resources/Debugger/Sources tabs had
>+        never been active at any point in the past. Selecting one of those tabs and then clicking on
>+        an initiator link in the Network tab would re-select that other tab.
>+
>+        * UserInterface/Base/Main.js:
>+        (WI.dialogWasDismissedWithRepresentedObject):
>+
>+        * UserInterface/Views/ResourceHeadersContentView.js:
>+        (WI.ResourceHeadersContentView.prototype._refreshSummarySection):
>+
> 2019-05-09  Devin Rousso  <drousso@apple.com>
> 
>         Web Inspector: Uncaught Exception: null is not an object (evaluating 'resource.parentFrame.securityOrigin')
>diff --git a/Source/WebInspectorUI/UserInterface/Base/Main.js b/Source/WebInspectorUI/UserInterface/Base/Main.js
>index 625dd8c4df9cbaf3e7a98e9315f23004d892cb36..04047f5b99c7273a55e0e6d9b0e11b9a86cc3a79 100644
>--- a/Source/WebInspectorUI/UserInterface/Base/Main.js
>+++ b/Source/WebInspectorUI/UserInterface/Base/Main.js
>@@ -3235,7 +3235,10 @@ WI.dialogWasDismissedWithRepresentedObject = function(dialog, representedObject)
>     if (!representedObject)
>         return;
> 
>-    WI.showRepresentedObject(representedObject, dialog.cookie);
>+    WI.showRepresentedObject(representedObject, dialog.cookie, {
>+        ignoreSearchTab: true,
>+        ignoreNetworkTab: true,
>+    });
> };
> 
> // Popover delegate
>diff --git a/Source/WebInspectorUI/UserInterface/Views/ResourceHeadersContentView.js b/Source/WebInspectorUI/UserInterface/Views/ResourceHeadersContentView.js
>index 397bd0f385305029dc464d9940205b5d6cba702d..acc5055f411b2ea84a415e8712d4b49d5c66ac52 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/ResourceHeadersContentView.js
>+++ b/Source/WebInspectorUI/UserInterface/Views/ResourceHeadersContentView.js
>@@ -270,6 +270,7 @@ WI.ResourceHeadersContentView = class ResourceHeadersContentView extends WI.Cont
>             const options = {
>                 dontFloat: true,
>                 ignoreSearchTab: true,
>+                ignoreNetworkTab: true,
>             };
>             let link = WI.createSourceCodeLocationLink(initiatorLocation, options);
>             fragment.appendChild(link);
>@@ -283,7 +284,7 @@ WI.ResourceHeadersContentView = class ResourceHeadersContentView extends WI.Cont
>                 this._popoverCallStackIconElement.addEventListener("click", (event) => {
>                     if (!this._popover) {
>                         this._popover = new WI.Popover(this);
>-                        this._popover.windowResizeHandler = () => { this._presentPopoverBelowCallStackElement() };
>+                        this._popover.windowResizeHandler = () => { this._presentPopoverBelowCallStackElement(); };
>                     }
> 
>                     const selectable = false;

Actions: View | Formatted Diff | Diff

Attachments on bug 197951: 370096 | 370107