Attachment 370076 Details for Bug 197965 – Patch v1

[patch] Patch v1

bug-197965-20190516153519.patch (text/plain), 1.51 KB, created by David Kilzer (:ddkilzer) on 2019-05-16 15:35:20 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: David Kilzer (:ddkilzer)

Created: 2019-05-16 15:35:20 PDT

Size: 1.51 KB

patch

obsolete

>Subversion Revision: 245366
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 912093f0ffe341c2f46daa6a0beefe2b97c12bf2..d97863a0f8515a56c609abe37fa4202c6981a3bc 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,15 @@
>+2019-05-16  David Kilzer  <ddkilzer@apple.com>
>+
>+        REGRESSION (r84160): Leak of OpaqueJSString under WTR::JSTestRunner::pathToLocalResource (32 bytes) in com.apple.WebKit.WebContent running layout tests
>+        <https://webkit.org/b/197965>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
>+        (WTR::TestRunner::pathToLocalResource): Don't call
>+        JSStringRetain() here because the JSRetainPtr<JSStringRef>
>+        return type will increment the retain count for us.
>+
> 2019-05-15  Aakash Jain  <aakash_jain@apple.com>
> 
>         Replace double-quotes with single quotes in steps.py
>diff --git a/Tools/WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm b/Tools/WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm
>index 0486dc866879880e101f5a9dd5c60c8095880e9e..403f4ff832ee0ef7c3cfabdf0f87e2ccbe614f8a 100644
>--- a/Tools/WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm
>+++ b/Tools/WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm
>@@ -38,7 +38,7 @@ void TestRunner::platformInitialize()
> 
> JSRetainPtr<JSStringRef> TestRunner::pathToLocalResource(JSStringRef url)
> {
>-    return JSStringRetain(url); // Do nothing on mac.
>+    return url; // Do nothing on Cocoa.
> }
> 
> JSRetainPtr<JSStringRef> TestRunner::inspectorTestStubURL()

Actions: View | Formatted Diff | Diff

Attachments on bug 197965: 370076