WebKit Bugzilla
Attachment 370046 Details for
Bug 197933
: Re-enable generate-xcfilelists
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-197933-20190516094845.patch (text/plain), 7.70 KB, created by
Keith Rollin
on 2019-05-16 09:48:46 PDT
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Keith Rollin
Created:
2019-05-16 09:48:46 PDT
Size:
7.70 KB
patch
obsolete
>Subversion Revision: 245396 >diff --git a/Source/JavaScriptCore/ChangeLog b/Source/JavaScriptCore/ChangeLog >index 5b4da472e0ce993c154193f9b8fee4044e796e59..b5b34ef609f85016e9249d292b3fc91f5ae99057 100644 >--- a/Source/JavaScriptCore/ChangeLog >+++ b/Source/JavaScriptCore/ChangeLog >@@ -1,3 +1,19 @@ >+2019-05-15 Keith Rollin <krollin@apple.com> >+ >+ Re-enable generate-xcfilelists >+ https://bugs.webkit.org/show_bug.cgi?id=197933 >+ <rdar://problem/50831677> >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ The following two tasks have been completed, and we can re-enable >+ generate-xcfilelists: >+ >+ Bug 197619 <rdar://problem/50507392> Temporarily disable generate-xcfilelists (197619) >+ Bug 197622 <rdar://problem/50508222> Rewrite generate-xcfilelists in Python (197622) >+ >+ * Scripts/check-xcfilelists.sh: >+ > 2019-05-15 Saam Barati <sbarati@apple.com> > > Bound liveness of SetArgumentMaybe nodes when maximal flush insertion phase is enabled >diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog >index 0bd242bbc38e168b33befd0feb0e76647d56f6b9..1ebc5833e23da464bc1988f374269a0a15fa4a4b 100644 >--- a/Source/WebCore/ChangeLog >+++ b/Source/WebCore/ChangeLog >@@ -1,3 +1,21 @@ >+2019-05-15 Keith Rollin <krollin@apple.com> >+ >+ Re-enable generate-xcfilelists >+ https://bugs.webkit.org/show_bug.cgi?id=197933 >+ <rdar://problem/50831677> >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ The following two tasks have been completed, and we can re-enable >+ generate-xcfilelists: >+ >+ Bug 197619 <rdar://problem/50507392> Temporarily disable generate-xcfilelists (197619) >+ Bug 197622 <rdar://problem/50508222> Rewrite generate-xcfilelists in Python (197622) >+ >+ No new tests -- no change in user-visible functionality. >+ >+ * Scripts/check-xcfilelists.sh: >+ > 2019-05-16 Ali Juma <ajuma@chromium.org> > > [IntersectionObserver] Regression: No initial observation when nothing else triggers rendering >diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog >index cecd9521341fa7ad17edc7cfe31bffad7fc537d1..398560d97807ae0b1c44abdef63f9e740dbbe1f6 100644 >--- a/Source/WebKit/ChangeLog >+++ b/Source/WebKit/ChangeLog >@@ -1,3 +1,19 @@ >+2019-05-15 Keith Rollin <krollin@apple.com> >+ >+ Re-enable generate-xcfilelists >+ https://bugs.webkit.org/show_bug.cgi?id=197933 >+ <rdar://problem/50831677> >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ The following two tasks have been completed, and we can re-enable >+ generate-xcfilelists: >+ >+ Bug 197619 <rdar://problem/50507392> Temporarily disable generate-xcfilelists (197619) >+ Bug 197622 <rdar://problem/50508222> Rewrite generate-xcfilelists in Python (197622) >+ >+ * Scripts/check-xcfilelists.sh: >+ > 2019-05-16 Ryan Walklin <ryan@testtoast.com> > > [WPE] Rendering on a HiDPI display looks scaled up instead of rendered at 2x >diff --git a/Source/JavaScriptCore/Scripts/check-xcfilelists.sh b/Source/JavaScriptCore/Scripts/check-xcfilelists.sh >index 89fbdd5d1658253e6dd1de706975dcb868aceb15..8ceb164c77af772eb756515cc29e3d2658ee9fc8 100755 >--- a/Source/JavaScriptCore/Scripts/check-xcfilelists.sh >+++ b/Source/JavaScriptCore/Scripts/check-xcfilelists.sh >@@ -1,8 +1,5 @@ > #!/bin/sh > >-# FIXME: Remove this once https://bugs.webkit.org/show_bug.cgi?id=197622 is resolved >-exit 0 >- > [ "${WK_DISABLE_CHECK_XCFILELISTS}" == "1" ] && { echo "### Not running because WK_DISABLE_CHECK_XCFILELISTS is set"; exit 0; } > [ "${DEPLOYMENT_LOCATION}" == "YES" ] && { echo "### Not running because DEPLOYMENT_LOCATION is YES"; exit 0; } > [ "${USE_INTERNAL_SDK}" == "YES" ] || { echo "### Not running because USE_INTERNAL_SDK is not YES"; exit 0; } >diff --git a/Source/WebCore/Scripts/check-xcfilelists.sh b/Source/WebCore/Scripts/check-xcfilelists.sh >index 93569649639bf05d11505a09f9975a33696e37b2..c318aa911767ff0b0447a51665df4e51f73a0f6e 100755 >--- a/Source/WebCore/Scripts/check-xcfilelists.sh >+++ b/Source/WebCore/Scripts/check-xcfilelists.sh >@@ -1,8 +1,5 @@ > #!/bin/sh > >-# FIXME: Remove this once https://bugs.webkit.org/show_bug.cgi?id=197622 is resolved >-exit 0 >- > [ "${WK_DISABLE_CHECK_XCFILELISTS}" == "1" ] && { echo "### Not running because WK_DISABLE_CHECK_XCFILELISTS is set"; exit 0; } > [ "${DEPLOYMENT_LOCATION}" == "YES" ] && { echo "### Not running because DEPLOYMENT_LOCATION is YES"; exit 0; } > [ "${USE_INTERNAL_SDK}" == "YES" ] || { echo "### Not running because USE_INTERNAL_SDK is not YES"; exit 0; } >diff --git a/Source/WebKit/Scripts/check-xcfilelists.sh b/Source/WebKit/Scripts/check-xcfilelists.sh >index cc371fac2372c3592bb4e5267f868643ff4eaf22..0bb128a8bfe9e9030e8663efb50e60f1ac06e754 100755 >--- a/Source/WebKit/Scripts/check-xcfilelists.sh >+++ b/Source/WebKit/Scripts/check-xcfilelists.sh >@@ -1,8 +1,5 @@ > #!/bin/sh > >-# FIXME: Remove this once https://bugs.webkit.org/show_bug.cgi?id=197622 is resolved >-exit 0 >- > [ "${WK_DISABLE_CHECK_XCFILELISTS}" == "1" ] && { echo "### Not running because WK_DISABLE_CHECK_XCFILELISTS is set"; exit 0; } > [ "${DEPLOYMENT_LOCATION}" == "YES" ] && { echo "### Not running because DEPLOYMENT_LOCATION is YES"; exit 0; } > [ "${USE_INTERNAL_SDK}" == "YES" ] || { echo "### Not running because USE_INTERNAL_SDK is not YES"; exit 0; } >diff --git a/Tools/ChangeLog b/Tools/ChangeLog >index 912093f0ffe341c2f46daa6a0beefe2b97c12bf2..fa846ed6e20c0049420004cc9ad507839746c210 100644 >--- a/Tools/ChangeLog >+++ b/Tools/ChangeLog >@@ -1,3 +1,20 @@ >+2019-05-15 Keith Rollin <krollin@apple.com> >+ >+ Re-enable generate-xcfilelists >+ https://bugs.webkit.org/show_bug.cgi?id=197933 >+ <rdar://problem/50831677> >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ The following two tasks have been completed, and we can re-enable >+ generate-xcfilelists: >+ >+ Bug 197619 <rdar://problem/50507392> Temporarily disable generate-xcfilelists (197619) >+ Bug 197622 <rdar://problem/50508222> Rewrite generate-xcfilelists in Python (197622) >+ >+ * DumpRenderTree/Scripts/check-xcfilelists.sh: >+ * WebKitTestRunner/Scripts/check-xcfilelists.sh: >+ > 2019-05-15 Aakash Jain <aakash_jain@apple.com> > > Replace double-quotes with single quotes in steps.py >diff --git a/Tools/DumpRenderTree/Scripts/check-xcfilelists.sh b/Tools/DumpRenderTree/Scripts/check-xcfilelists.sh >index 9e64e3ba27c38110321efc910bbfa046567707db..234dfbb4d1e418a24728caed48b74b20accc5b0a 100755 >--- a/Tools/DumpRenderTree/Scripts/check-xcfilelists.sh >+++ b/Tools/DumpRenderTree/Scripts/check-xcfilelists.sh >@@ -1,8 +1,5 @@ > #!/bin/sh > >-# FIXME: Remove this once https://bugs.webkit.org/show_bug.cgi?id=197622 is resolved >-exit 0 >- > [ "${WK_DISABLE_CHECK_XCFILELISTS}" == "1" ] && { echo "### Not running because WK_DISABLE_CHECK_XCFILELISTS is set"; exit 0; } > [ "${DEPLOYMENT_LOCATION}" == "YES" ] && { echo "### Not running because DEPLOYMENT_LOCATION is YES"; exit 0; } > [ "${USE_INTERNAL_SDK}" == "YES" ] || { echo "### Not running because USE_INTERNAL_SDK is not YES"; exit 0; } >diff --git a/Tools/WebKitTestRunner/Scripts/check-xcfilelists.sh b/Tools/WebKitTestRunner/Scripts/check-xcfilelists.sh >index fe3ec480eb17d47d371f1d4f8a1bba5147fa81e7..e5ecbb6825fac9eac2db4fe8f81dc344088c63ce 100755 >--- a/Tools/WebKitTestRunner/Scripts/check-xcfilelists.sh >+++ b/Tools/WebKitTestRunner/Scripts/check-xcfilelists.sh >@@ -1,8 +1,5 @@ > #!/bin/sh > >-# FIXME: Remove this once https://bugs.webkit.org/show_bug.cgi?id=197622 is resolved >-exit 0 >- > [ "${WK_DISABLE_CHECK_XCFILELISTS}" == "1" ] && { echo "### Not running because WK_DISABLE_CHECK_XCFILELISTS is set"; exit 0; } > [ "${DEPLOYMENT_LOCATION}" == "YES" ] && { echo "### Not running because DEPLOYMENT_LOCATION is YES"; exit 0; } > [ "${USE_INTERNAL_SDK}" == "YES" ] || { echo "### Not running because USE_INTERNAL_SDK is not YES"; exit 0; }
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 197933
: 370046