Attachment 370012 Details for Bug 197935 – Patch

[patch] Patch

bug-197935-20190515174710.patch (text/plain), 2.52 KB, created by Greg Hughes on 2019-05-15 17:47:11 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Greg Hughes

Created: 2019-05-15 17:47:11 PDT

Size: 2.52 KB

patch

obsolete

>Subversion Revision: 245344
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 44c0affc708075e1efa314cb4ed6acedc45cad55..e0e05b2ff5b80231e73e45adf025da74ffba109d 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,15 @@
>+2019-05-15  Greg Hughes  <ghughes@apple.com>
>+
>+        Updated screenHasInvertedColors to use AppKit when available
>+        https://bugs.webkit.org/show_bug.cgi?id=197935
>+        <rdar://problem/50834405>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * platform/mac/PlatformScreenMac.mm:
>+        (WebCore::collectScreenProperties):
>+        (WebCore::screenHasInvertedColors):
>+
> 2019-05-15  Youenn Fablet  <youenn@apple.com>
> 
>         Mark beacon and ping loads as low priority
>diff --git a/Source/WebCore/platform/mac/PlatformScreenMac.mm b/Source/WebCore/platform/mac/PlatformScreenMac.mm
>index 0402319023bc480cef2845395cc5c3ad5b3db588..13aafac6bd80b171764053e72d9760790c8c2357 100644
>--- a/Source/WebCore/platform/mac/PlatformScreenMac.mm
>+++ b/Source/WebCore/platform/mac/PlatformScreenMac.mm
>@@ -110,7 +110,13 @@ PlatformDisplayID primaryScreenDisplayID()
> ScreenProperties collectScreenProperties()
> {
>     ASSERT(hasProcessPrivilege(ProcessPrivilege::CanCommunicateWithWindowServer));
>-
>+    
>+#if HAVE_ACCESSIBILITY_SUPPORT
>+    bool screenHasInvertedColors = [[NSWorkspace sharedWorkspace] accessibilityDisplayShouldInvertColors];
>+#else
>+    bool screenHasInvertedColors = CGDisplayUsesInvertedPolarity();
>+#endif
>+    
>     ScreenProperties screenProperties;
> 
>     for (NSScreen *screen in [NSScreen screens]) {
>@@ -124,7 +130,6 @@ ScreenProperties collectScreenProperties()
>         int screenDepth = NSBitsPerPixelFromDepth(screen.depth);
>         int screenDepthPerComponent = NSBitsPerSampleFromDepth(screen.depth);
>         bool screenSupportsExtendedColor = [screen canRepresentDisplayGamut:NSDisplayGamutP3];
>-        bool screenHasInvertedColors = CGDisplayUsesInvertedPolarity();
>         bool screenIsMonochrome = CGDisplayUsesForceToGray();
>         uint32_t displayMask = CGDisplayIDToOpenGLDisplayMask(displayID);
>         IORegistryGPUID gpuID = 0;
>@@ -256,7 +261,11 @@ bool screenHasInvertedColors()
> 
>     // This is a system-wide accessibility setting, same on all screens.
>     ASSERT(hasProcessPrivilege(ProcessPrivilege::CanCommunicateWithWindowServer));
>+#if HAVE_ACCESSIBILITY_SUPPORT
>+    return [[NSWorkspace sharedWorkspace] accessibilityDisplayShouldInvertColors];
>+#else
>     return CGDisplayUsesInvertedPolarity();
>+#endif
> }
> 
> int screenDepth(Widget* widget)

Actions: View | Formatted Diff | Diff

Attachments on bug 197935: 370012 | 370013