Attachment 369884 Details for Bug 197890 – Patch for landing

[patch] Patch for landing

patch197890 (text/plain), 1.63 KB, created by Robin Morisset on 2019-05-14 12:55:30 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Robin Morisset

Created: 2019-05-14 12:55:30 PDT

Size: 1.63 KB

patch

obsolete

>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 53df7a7d285..7896247b243 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,16 @@
>+2019-05-14  Robin Morisset  <rmorisset@apple.com>
>+
>+        [WHLSL] parseEffectfulAssignment should not call parseCallExpression directly
>+        https://bugs.webkit.org/show_bug.cgi?id=197890
>+
>+        Reviewed by Myles Maxfield.
>+
>+        callExpression already appears in effSuffix which is in effPrefix which is in effAssignment, so having it directly in effAssignment as well is useless (and ambiguous).
>+        I've already fixed the grammar (https://github.com/gpuweb/WHLSL/commit/a07005f4d692fe3370618dca5db218992b362049), the grammar was always good, this patch is fixing the parser.
>+
>+        * Modules/webgpu/WHLSL/WHLSLParser.cpp:
>+        (WebCore::WHLSL::Parser::parseEffectfulAssignment):
>+
> 2019-05-14  Youenn Fablet  <youenn@apple.com>
> 
>         Video frame resizing should be using Trim
>diff --git a/Source/WebCore/Modules/webgpu/WHLSL/WHLSLParser.cpp b/Source/WebCore/Modules/webgpu/WHLSL/WHLSLParser.cpp
>index 53325676649..2356273d5ea 100644
>--- a/Source/WebCore/Modules/webgpu/WHLSL/WHLSLParser.cpp
>+++ b/Source/WebCore/Modules/webgpu/WHLSL/WHLSLParser.cpp
>@@ -1803,12 +1803,6 @@ auto Parser::parseEffectfulAssignment() -> Expected<UniqueRef<AST::Expression>,
>     if (assignment)
>         return assignment;
> 
>-    assignment = backtrackingScope<Expected<UniqueRef<AST::Expression>, Error>>([&]() {
>-        return parseCallExpression();
>-    });
>-    if (assignment)
>-        return assignment;
>-
>     return Unexpected<Error>(assignment.error());
> }
>

Actions: View | Formatted Diff | Diff

Attachments on bug 197890: 369879 | 369882 | 369884