Attachment 369881 Details for Bug 195864 – Patch

[patch] Patch

patch195864 (text/plain), 1.59 KB, created by Robin Morisset on 2019-05-14 12:33:26 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Robin Morisset

Created: 2019-05-14 12:33:26 PDT

Size: 1.59 KB

patch

obsolete

>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 53df7a7d285..4c371210e84 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,19 @@
>+2019-05-14  Robin Morisset  <rmorisset@apple.com>
>+
>+        [WHLSL] parseEffectfulSuffix() is never called
>+        https://bugs.webkit.org/show_bug.cgi?id=195864
>+        <rdar://problem/50746278>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        The fix is trivial: when parseEffectfulPrefix does not see a ++ or --, it must call parseEffectfulSuffix.
>+
>+        No test yet, as it is not testable until the property resolver is finished.
>+        It will be tested with the rest of the compiler, when we port the testsuite from the js implementation (it already covers this case).
>+
>+        * Modules/webgpu/WHLSL/WHLSLParser.cpp:
>+        (WebCore::WHLSL::Parser::parseEffectfulPrefix):
>+
> 2019-05-14  Youenn Fablet  <youenn@apple.com>
> 
>         Video frame resizing should be using Trim
>diff --git a/Source/WebCore/Modules/webgpu/WHLSL/WHLSLParser.cpp b/Source/WebCore/Modules/webgpu/WHLSL/WHLSLParser.cpp
>index 53325676649..b51765aef8e 100644
>--- a/Source/WebCore/Modules/webgpu/WHLSL/WHLSLParser.cpp
>+++ b/Source/WebCore/Modules/webgpu/WHLSL/WHLSLParser.cpp
>@@ -1816,7 +1816,7 @@ auto Parser::parseEffectfulPrefix() -> Expected<UniqueRef<AST::Expression>, Erro
> {
>     auto prefix = consumeTypes({ Lexer::Token::Type::PlusPlus, Lexer::Token::Type::MinusMinus });
>     if (!prefix)
>-        return Unexpected<Error>(prefix.error());
>+        return parseEffectfulSuffix();
> 
>     auto previous = parsePossiblePrefix();
>     if (!previous)

Actions: View | Formatted Diff | Diff

Attachments on bug 195864: 369881 | 372569 | 372572 | 372619