Attachment 369816 Details for Bug 178319 – Patch

[patch] Patch

bug-178319-20190513200422.patch (text/plain), 23.59 KB, created by Darin Adler on 2019-05-13 20:04:23 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Darin Adler

Created: 2019-05-13 20:04:23 PDT

Size: 23.59 KB

patch

obsolete

>Subversion Revision: 245270
>diff --git a/Source/WTF/ChangeLog b/Source/WTF/ChangeLog
>index 1331f236534779304d192e4f9c7b2d04c24b7434..e84bcfe3d6beb05dfc59e7f0baf55286b5a648f9 100644
>--- a/Source/WTF/ChangeLog
>+++ b/Source/WTF/ChangeLog
>@@ -1,3 +1,16 @@
>+2019-05-13  Darin Adler  <darin@apple.com>
>+
>+        Change String::number to use "shortest" instead of "fixed precision 6 digits"
>+        https://bugs.webkit.org/show_bug.cgi?id=178319
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * wtf/text/StringBuilder.h: Delete appendNumber for floating point and
>+        appendECMAScriptNumber for single-precision.
>+
>+        * wtf/text/WTFString.h: Delete String::number for floating point and
>+        numberToStringECMAScript for single-precision.
>+
> 2019-05-13  Youenn Fablet  <youenn@apple.com>
> 
>         [Mac] Use realpath for dlopen_preflight
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index ec1fd0759b74f1f95d3094c89cca1bacff95fbfe..de6f4bd500d95d7fd91fc52c8a609a4439509fdc 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,37 @@
>+2019-05-13  Darin Adler  <darin@apple.com>
>+
>+        Change String::number to use "shortest" instead of "fixed precision 6 digits"
>+        https://bugs.webkit.org/show_bug.cgi?id=178319
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * accessibility/atk/WebKitAccessibleInterfaceValue.cpp:
>+        (webkitAccessibleSetNewValue): Use String::numberToStringFixedPrecision
>+        instead of String::number to be explicit about the fact that it's fixed precision.
>+        * page/linux/ResourceUsageOverlayLinux.cpp:
>+        (gcTimerString): Ditto.
>+
>+        * platform/graphics/ca/win/PlatformCALayerWin.cpp:
>+        (printTransform): Use appendFixedPrecisionNumber instead of appendNumber
>+        to be explicit about the fact that it's fixed precision.
>+        (printLayer): Ditto.
>+        (WebCore::PlatformCALayerWin::layerTreeAsString const): Ditto.
>+        * platform/graphics/freetype/FontCacheFreeType.cpp:
>+        (buildVariationSettings): Ditto.
>+
>+        * svg/SVGNumberList.h: Use appendFixedPrecisionNumber instead of appendNumber
>+        to be explicit about the fact that it's fixed precision. We'll consider moving
>+        to shortest later.
>+
>+        * svg/SVGPathUtilities.cpp:
>+        (WebCore::buildStringFromPath): Use appendNumberShortest instead of
>+        appendNumberECMAScript since these are single-precision.
>+
>+        * svg/SVGPointList.h: Use appendFixedPrecisionNumber instead of appendNumber
>+        to be explicit about the fact that it's fixed precision. We'll consider moving
>+        to shortest later.
>+        * svg/SVGTransformValue.h: Ditto.
>+
> 2019-05-13  Yusuke Suzuki  <ysuzuki@apple.com>
> 
>         Unreviewed, build fix after 245258, missing ThreadSpecific.h include
>diff --git a/Source/WTF/wtf/text/StringBuilder.h b/Source/WTF/wtf/text/StringBuilder.h
>index 1f508bcc986c2281cf65234788eb1d3dcacf013e..ebaf73e6ef790c8269ab9a012d425488c57b1e11 100644
>--- a/Source/WTF/wtf/text/StringBuilder.h
>+++ b/Source/WTF/wtf/text/StringBuilder.h
>@@ -222,9 +222,9 @@ public:
>     WTF_EXPORT_PRIVATE void appendNumber(unsigned long);
>     WTF_EXPORT_PRIVATE void appendNumber(long long);
>     WTF_EXPORT_PRIVATE void appendNumber(unsigned long long);
>-    // FIXME: Change appendNumber to be appendShortestFormNumber instead of appendFixedPrecisionNumber.
>-    void appendNumber(float);
>-    void appendNumber(double, unsigned precision = 6, TrailingZerosTruncatingPolicy = TruncateTrailingZeros);
>+    // FIXME: Change to call appendShortestFormNumber.
>+    void appendNumber(float) = delete;
>+    void appendNumber(double) = delete;
> 
>     WTF_EXPORT_PRIVATE void appendShortestFormNumber(float);
>     WTF_EXPORT_PRIVATE void appendShortestFormNumber(double);
>@@ -234,7 +234,7 @@ public:
>     WTF_EXPORT_PRIVATE void appendFixedWidthNumber(double, unsigned decimalPlaces);
> 
>     // FIXME: Delete in favor of the name appendShortestFormNumber or just appendNumber.
>-    void appendECMAScriptNumber(float);
>+    void appendECMAScriptNumber(float) = delete;
>     void appendECMAScriptNumber(double);
> 
>     String toString()
>@@ -394,23 +394,6 @@ ALWAYS_INLINE UChar* StringBuilder::getBufferCharacters<UChar>()
>     return m_bufferCharacters16;
> }
> 
>-inline void StringBuilder::appendNumber(float number)
>-{
>-    appendFixedPrecisionNumber(number);
>-}
>-
>-inline void StringBuilder::appendNumber(double number, unsigned precision, TrailingZerosTruncatingPolicy policy)
>-{
>-    appendFixedPrecisionNumber(number, precision, policy);
>-}
>-
>-inline void StringBuilder::appendECMAScriptNumber(float number)
>-{
>-    // FIXME: This preserves existing behavior but is not what we want.
>-    // In the future, this should either be a compilation error or call appendShortestFormNumber without converting to double.
>-    appendShortestFormNumber(static_cast<double>(number));
>-}
>-
> inline void StringBuilder::appendECMAScriptNumber(double number)
> {
>     appendShortestFormNumber(number);
>diff --git a/Source/WTF/wtf/text/WTFString.h b/Source/WTF/wtf/text/WTFString.h
>index 1d9f0db0083041949aa005864e5044409201de74..007ac572d6be07b1fd85b9ddc353a59fe7d17472 100644
>--- a/Source/WTF/wtf/text/WTFString.h
>+++ b/Source/WTF/wtf/text/WTFString.h
>@@ -179,9 +179,9 @@ public:
>     WTF_EXPORT_PRIVATE static String number(unsigned long);
>     WTF_EXPORT_PRIVATE static String number(long long);
>     WTF_EXPORT_PRIVATE static String number(unsigned long long);
>-    // FIXME: Change number to be numberToStringShortest instead of numberToStringFixedPrecision.
>-    static String number(float);
>-    static String number(double, unsigned precision = 6, TrailingZerosTruncatingPolicy = TruncateTrailingZeros);
>+    // FIXME: Change to call numberToStringShortest.
>+    static String number(float) = delete;
>+    static String number(double) = delete;
> 
>     WTF_EXPORT_PRIVATE static String numberToStringShortest(float);
>     WTF_EXPORT_PRIVATE static String numberToStringShortest(double);
>@@ -191,7 +191,7 @@ public:
>     WTF_EXPORT_PRIVATE static String numberToStringFixedWidth(double, unsigned decimalPlaces);
> 
>     // FIXME: Delete in favor of the name numberToStringShortest or just number.
>-    static String numberToStringECMAScript(float);
>+    static String numberToStringECMAScript(float) = delete;
>     static String numberToStringECMAScript(double);
> 
>     // Find a single character or string, also with match function & latin1 forms.
>@@ -654,23 +654,6 @@ template<unsigned length> inline bool startsWithLettersIgnoringASCIICase(const S
>     return startsWithLettersIgnoringASCIICase(string.impl(), lowercaseLetters);
> }
> 
>-inline String String::number(float number)
>-{
>-    return numberToStringFixedPrecision(number);
>-}
>-
>-inline String String::number(double number, unsigned precision, TrailingZerosTruncatingPolicy policy)
>-{
>-    return numberToStringFixedPrecision(number, precision, policy);
>-}
>-
>-inline String String::numberToStringECMAScript(float number)
>-{
>-    // FIXME: This preserves existing behavior but is not what we want.
>-    // In the future, this should either be a compilation error or call numberToStringShortest without converting to double.
>-    return numberToStringShortest(static_cast<double>(number));
>-}
>-
> inline String String::numberToStringECMAScript(double number)
> {
>     return numberToStringShortest(number);
>diff --git a/Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceValue.cpp b/Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceValue.cpp
>index edb5e855135ac913cae2e3afe66aed9ef8d9b3b3..a6b15f8f9bf5d90313877310edd6cbfa17d1643d 100644
>--- a/Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceValue.cpp
>+++ b/Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceValue.cpp
>@@ -49,7 +49,7 @@ static bool webkitAccessibleSetNewValue(AtkValue* coreValue, const gdouble newVa
>     value = std::max(static_cast<double>(coreObject->minValueForRange()), newValue);
>     value = std::min(static_cast<double>(coreObject->maxValueForRange()), newValue);
> 
>-    coreObject->setValue(String::number(value));
>+    coreObject->setValue(String::numberToStringFixedPrecision(value));
>     return TRUE;
> }
> 
>diff --git a/Source/WebCore/page/linux/ResourceUsageOverlayLinux.cpp b/Source/WebCore/page/linux/ResourceUsageOverlayLinux.cpp
>index 9571d1228558ecebe7b7821a5e6b624f254b4789..a824e53fc899e67cebdb56460e19901c80c2f68f 100644
>--- a/Source/WebCore/page/linux/ResourceUsageOverlayLinux.cpp
>+++ b/Source/WebCore/page/linux/ResourceUsageOverlayLinux.cpp
>@@ -64,7 +64,7 @@ static String gcTimerString(MonotonicTime timerFireDate, MonotonicTime now)
> {
>     if (std::isnan(timerFireDate))
>         return "[not scheduled]"_s;
>-    return String::number((timerFireDate - now).seconds());
>+    return String::numberToStringFixedPrecision((timerFireDate - now).seconds());
> }
> 
> static const float gFontSize = 14;
>diff --git a/Source/WebCore/platform/graphics/ca/win/PlatformCALayerWin.cpp b/Source/WebCore/platform/graphics/ca/win/PlatformCALayerWin.cpp
>index eeb4c54e2a7fb796e63281dd0a13f42d46d84d8a..15d4e46b06c76c17f3405139c6c979c1017b3696 100644
>--- a/Source/WebCore/platform/graphics/ca/win/PlatformCALayerWin.cpp
>+++ b/Source/WebCore/platform/graphics/ca/win/PlatformCALayerWin.cpp
>@@ -704,37 +704,37 @@ static void printIndent(StringBuilder& builder, int indent)
> static void printTransform(StringBuilder& builder, const CATransform3D& transform)
> {
>     builder.append('[');
>-    builder.appendNumber(transform.m11);
>+    builder.appendFixedPrecisionNumber(transform.m11);
>     builder.append(' ');
>-    builder.appendNumber(transform.m12);
>+    builder.appendFixedPrecisionNumber(transform.m12);
>     builder.append(' ');
>-    builder.appendNumber(transform.m13);
>+    builder.appendFixedPrecisionNumber(transform.m13);
>     builder.append(' ');
>-    builder.appendNumber(transform.m14);
>+    builder.appendFixedPrecisionNumber(transform.m14);
>     builder.append("; ");
>-    builder.appendNumber(transform.m21);
>+    builder.appendFixedPrecisionNumber(transform.m21);
>     builder.append(' ');
>-    builder.appendNumber(transform.m22);
>+    builder.appendFixedPrecisionNumber(transform.m22);
>     builder.append(' ');
>-    builder.appendNumber(transform.m23);
>+    builder.appendFixedPrecisionNumber(transform.m23);
>     builder.append(' ');
>-    builder.appendNumber(transform.m24);
>+    builder.appendFixedPrecisionNumber(transform.m24);
>     builder.append("; ");
>-    builder.appendNumber(transform.m31);
>+    builder.appendFixedPrecisionNumber(transform.m31);
>     builder.append(' ');
>-    builder.appendNumber(transform.m32);
>+    builder.appendFixedPrecisionNumber(transform.m32);
>     builder.append(' ');
>-    builder.appendNumber(transform.m33);
>+    builder.appendFixedPrecisionNumber(transform.m33);
>     builder.append(' ');
>-    builder.appendNumber(transform.m34);
>+    builder.appendFixedPrecisionNumber(transform.m34);
>     builder.append("; ");
>-    builder.appendNumber(transform.m41);
>+    builder.appendFixedPrecisionNumber(transform.m41);
>     builder.append(' ');
>-    builder.appendNumber(transform.m42);
>+    builder.appendFixedPrecisionNumber(transform.m42);
>     builder.append(' ');
>-    builder.appendNumber(transform.m43);
>+    builder.appendFixedPrecisionNumber(transform.m43);
>     builder.append(' ');
>-    builder.appendNumber(transform.m44);
>+    builder.appendFixedPrecisionNumber(transform.m44);
>     builder.append(']');
> }
> 
>@@ -785,25 +785,25 @@ static void printLayer(StringBuilder& builder, const PlatformCALayer* layer, int
>     builder.append("(");
>     builder.append(layerTypeName);
>     builder.append(" [");
>-    builder.appendNumber(layerPosition.x());
>+    builder.appendFixedPrecisionNumber(layerPosition.x());
>     builder.append(' ');
>-    builder.appendNumber(layerPosition.y());
>+    builder.appendFixedPrecisionNumber(layerPosition.y());
>     builder.append(' ');
>-    builder.appendNumber(layerPosition.z());
>+    builder.appendFixedPrecisionNumber(layerPosition.z());
>     builder.append("] [");
>-    builder.appendNumber(layerBounds.x());
>+    builder.appendFixedPrecisionNumber(layerBounds.x());
>     builder.append(' ');
>-    builder.appendNumber(layerBounds.y());
>+    builder.appendFixedPrecisionNumber(layerBounds.y());
>     builder.append(' ');
>-    builder.appendNumber(layerBounds.width());
>+    builder.appendFixedPrecisionNumber(layerBounds.width());
>     builder.append(' ');
>-    builder.appendNumber(layerBounds.height());
>+    builder.appendFixedPrecisionNumber(layerBounds.height());
>     builder.append("] [");
>-    builder.appendNumber(layerAnchorPoint.x());
>+    builder.appendFixedPrecisionNumber(layerAnchorPoint.x());
>     builder.append(' ');
>-    builder.appendNumber(layerAnchorPoint.y());
>+    builder.appendFixedPrecisionNumber(layerAnchorPoint.y());
>     builder.append(' ');
>-    builder.appendNumber(layerAnchorPoint.z());
>+    builder.appendFixedPrecisionNumber(layerAnchorPoint.z());
>     builder.append("] superlayer=");
>     builder.appendNumber(reinterpret_cast<unsigned long long>(layer->superlayer()));
> 
>@@ -822,7 +822,7 @@ static void printLayer(StringBuilder& builder, const PlatformCALayer* layer, int
>         builder.append('\n');
>         printIndent(builder, indent + 1);
>         builder.append("(borderWidth ");
>-        builder.appendNumber(borderWidth);
>+        builder.appendFixedPrecisionNumber(borderWidth);
>         builder.append(')');
>     }
> 
>@@ -851,7 +851,7 @@ static void printLayer(StringBuilder& builder, const PlatformCALayer* layer, int
>         builder.append('\n');
>         printIndent(builder, indent + 1);
>         builder.append("(opacity ");
>-        builder.appendNumber(layerOpacity);
>+        builder.appendFixedPrecisionNumber(layerOpacity);
>         builder.append(')');
>     }
> 
>@@ -927,15 +927,15 @@ String PlatformCALayerWin::layerTreeAsString() const
> 
>     StringBuilder builder;
>     builder.append("\n\n** Render tree at time ");
>-    builder.appendNumber(MonotonicTime::now().secondsSinceEpoch().seconds());
>+    builder.appendFixedPrecisionNumber(MonotonicTime::now().secondsSinceEpoch().seconds());
>     builder.append(" (bounds ");
>-    builder.appendNumber(rootBounds.origin.x);
>+    builder.appendFixedPrecisionNumber(rootBounds.origin.x);
>     builder.append(", ");
>-    builder.appendNumber(rootBounds.origin.y);
>+    builder.appendFixedPrecisionNumber(rootBounds.origin.y);
>     builder.append(' ');
>-    builder.appendNumber(rootBounds.size.width);
>+    builder.appendFixedPrecisionNumber(rootBounds.size.width);
>     builder.append('x');
>-    builder.appendNumber(rootBounds.size.height);
>+    builder.appendFixedPrecisionNumber(rootBounds.size.height);
>     builder.append(") **\n\n");
> 
>     // Print layer tree from the root
>diff --git a/Source/WebCore/platform/graphics/freetype/FontCacheFreeType.cpp b/Source/WebCore/platform/graphics/freetype/FontCacheFreeType.cpp
>index d5ac0ed691a866d7bbc43b913739a45e402078ac..db0485dbc33ae86c03abf0f3f79dd89fb9a8de5b 100644
>--- a/Source/WebCore/platform/graphics/freetype/FontCacheFreeType.cpp
>+++ b/Source/WebCore/platform/graphics/freetype/FontCacheFreeType.cpp
>@@ -522,7 +522,7 @@ String buildVariationSettings(FT_Face face, const FontDescription& fontDescripti
>         builder.append(variation.key[2]);
>         builder.append(variation.key[3]);
>         builder.append('=');
>-        builder.appendNumber(variation.value);
>+        builder.appendFixedPrecisionNumber(variation.value);
>     }
>     return builder.toString();
> }
>diff --git a/Source/WebCore/svg/SVGNumberList.h b/Source/WebCore/svg/SVGNumberList.h
>index 5e2c114659bb66e62a1ff42971334010b54ac281..5b5d57e846f431aaf5c08dbc9a4c34abe84d6d1f 100644
>--- a/Source/WebCore/svg/SVGNumberList.h
>+++ b/Source/WebCore/svg/SVGNumberList.h
>@@ -78,7 +78,7 @@ public:
>             if (builder.length())
>                 builder.append(' ');
> 
>-            builder.appendNumber(number->value());
>+            builder.appendFixedPrecisionNumber(number->value());
>         }
> 
>         return builder.toString();
>diff --git a/Source/WebCore/svg/SVGPathUtilities.cpp b/Source/WebCore/svg/SVGPathUtilities.cpp
>index e5746ca2048a323b0179dddf7bb041dfcf7134a8..4b79c1fab02dd5851fbba0707d9dd34fcc3fbcec 100644
>--- a/Source/WebCore/svg/SVGPathUtilities.cpp
>+++ b/Source/WebCore/svg/SVGPathUtilities.cpp
>@@ -60,39 +60,39 @@ String buildStringFromPath(const Path& path)
>             switch (element.type) {
>             case PathElementMoveToPoint:
>                 builder.append('M');
>-                builder.appendECMAScriptNumber(element.points[0].x());
>+                builder.appendShortestFormNumber(element.points[0].x());
>                 builder.append(' ');
>-                builder.appendECMAScriptNumber(element.points[0].y());
>+                builder.appendShortestFormNumber(element.points[0].y());
>                 break;
>             case PathElementAddLineToPoint:
>                 builder.append('L');
>-                builder.appendECMAScriptNumber(element.points[0].x());
>+                builder.appendShortestFormNumber(element.points[0].x());
>                 builder.append(' ');
>-                builder.appendECMAScriptNumber(element.points[0].y());
>+                builder.appendShortestFormNumber(element.points[0].y());
>                 break;
>             case PathElementAddQuadCurveToPoint:
>                 builder.append('Q');
>-                builder.appendECMAScriptNumber(element.points[0].x());
>+                builder.appendShortestFormNumber(element.points[0].x());
>                 builder.append(' ');
>-                builder.appendECMAScriptNumber(element.points[0].y());
>+                builder.appendShortestFormNumber(element.points[0].y());
>                 builder.append(',');
>-                builder.appendECMAScriptNumber(element.points[1].x());
>+                builder.appendShortestFormNumber(element.points[1].x());
>                 builder.append(' ');
>-                builder.appendECMAScriptNumber(element.points[1].y());
>+                builder.appendShortestFormNumber(element.points[1].y());
>                 break;
>             case PathElementAddCurveToPoint:
>                 builder.append('C');
>-                builder.appendECMAScriptNumber(element.points[0].x());
>+                builder.appendShortestFormNumber(element.points[0].x());
>                 builder.append(' ');
>-                builder.appendECMAScriptNumber(element.points[0].y());
>+                builder.appendShortestFormNumber(element.points[0].y());
>                 builder.append(',');
>-                builder.appendECMAScriptNumber(element.points[1].x());
>+                builder.appendShortestFormNumber(element.points[1].x());
>                 builder.append(' ');
>-                builder.appendECMAScriptNumber(element.points[1].y());
>+                builder.appendShortestFormNumber(element.points[1].y());
>                 builder.append(',');
>-                builder.appendECMAScriptNumber(element.points[2].x());
>+                builder.appendShortestFormNumber(element.points[2].x());
>                 builder.append(' ');
>-                builder.appendECMAScriptNumber(element.points[2].y());
>+                builder.appendShortestFormNumber(element.points[2].y());
>                 break;
>             case PathElementCloseSubpath:
>                 builder.append('Z');
>diff --git a/Source/WebCore/svg/SVGPointList.h b/Source/WebCore/svg/SVGPointList.h
>index 80b83901e7f8ae026b0a5fdd4e04e59d826059b2..8c6c50b0e3bace536ae50ebb28c1b46e15749e81 100644
>--- a/Source/WebCore/svg/SVGPointList.h
>+++ b/Source/WebCore/svg/SVGPointList.h
>@@ -93,9 +93,9 @@ public:
>             if (builder.length())
>                 builder.append(' ');
> 
>-            builder.appendNumber(point->x());
>+            builder.appendFixedPrecisionNumber(point->x());
>             builder.append(' ');
>-            builder.appendNumber(point->y());
>+            builder.appendFixedPrecisionNumber(point->y());
>         }
> 
>         return builder.toString();
>diff --git a/Source/WebCore/svg/SVGTransformValue.h b/Source/WebCore/svg/SVGTransformValue.h
>index 659208e6c53988b02c4a8fde3dd64fc218109625..077350e6fd5cf31c8bd4d26eb6f4e454ce3f5662 100644
>--- a/Source/WebCore/svg/SVGTransformValue.h
>+++ b/Source/WebCore/svg/SVGTransformValue.h
>@@ -229,33 +229,33 @@ public:
>     }
> 
> private:
>-    static void appendNumbers(StringBuilder& builder)
>+    static void appendFixedPrecisionNumbers(StringBuilder& builder)
>     {
>         builder.append(')');
>     }
> 
>     template<typename Number, typename... Numbers>
>-    static void appendNumbers(StringBuilder& builder, Number number, Numbers... numbers)
>+    static void appendFixedPrecisionNumbers(StringBuilder& builder, Number number, Numbers... numbers)
>     {
>         if (builder.length() && builder[builder.length() - 1] != '(')
>             builder.append(' ');
>-        builder.appendNumber(number);
>-        appendNumbers(builder, numbers...);
>+        builder.appendFixedPrecisionNumber(number);
>+        appendFixedPrecisionNumbers(builder, numbers...);
>     }
> 
>     void appendMatrix(StringBuilder& builder) const
>     {
>-        appendNumbers(builder, m_matrix->a(), m_matrix->b(), m_matrix->c(), m_matrix->d(), m_matrix->e(), m_matrix->f());
>+        appendFixedPrecisionNumbers(builder, m_matrix->a(), m_matrix->b(), m_matrix->c(), m_matrix->d(), m_matrix->e(), m_matrix->f());
>     }
> 
>     void appendTranslate(StringBuilder& builder) const
>     {
>-        appendNumbers(builder, m_matrix->e(), m_matrix->f());
>+        appendFixedPrecisionNumbers(builder, m_matrix->e(), m_matrix->f());
>     }
> 
>     void appendScale(StringBuilder& builder) const
>     {
>-        appendNumbers(builder, m_matrix->value().xScale(), m_matrix->value().yScale());
>+        appendFixedPrecisionNumbers(builder, m_matrix->value().xScale(), m_matrix->value().yScale());
>     }
> 
>     void appendRotate(StringBuilder& builder) const
>@@ -268,19 +268,19 @@ private:
>         float cy = narrowPrecisionToFloat(cosAngle != 1 ? (m_matrix->e() * sinAngle / (1 - cosAngle) + m_matrix->f()) / 2 : 0);
> 
>         if (cx || cy)
>-            appendNumbers(builder, m_angle, cx, cy);
>+            appendFixedPrecisionNumbers(builder, m_angle, cx, cy);
>         else
>-            appendNumbers(builder, m_angle);
>+            appendFixedPrecisionNumbers(builder, m_angle);
>     }
> 
>     void appendSkewX(StringBuilder& builder) const
>     {
>-        appendNumbers(builder, m_angle);
>+        appendFixedPrecisionNumbers(builder, m_angle);
>     }
> 
>     void appendSkewY(StringBuilder& builder) const
>     {
>-        appendNumbers(builder, m_angle);
>+        appendFixedPrecisionNumbers(builder, m_angle);
>     }
> 
>     SVGTransformType m_type { SVG_TRANSFORM_UNKNOWN };
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 17d6ca023e23ab60f85b6d0b54b10b8c21716311..8c5969984d630cd44ece1dd46d76a19a5f2ebb9e 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,13 @@
>+2019-05-13  Darin Adler  <darin@apple.com>
>+
>+        Change String::number to use "shortest" instead of "fixed precision 6 digits"
>+        https://bugs.webkit.org/show_bug.cgi?id=178319
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * TestWebKitAPI/Tests/WTF/WTFString.cpp:
>+        (TestWebKitAPI::testStringNumberFixedPrecision): Use String::numberToStringFixedPrecision.
>+
> 2019-05-12  Yusuke Suzuki  <ysuzuki@apple.com>
> 
>         [JSC] Compress Watchpoint size by using enum type and Packed<> data structure
>diff --git a/Tools/TestWebKitAPI/Tests/WTF/WTFString.cpp b/Tools/TestWebKitAPI/Tests/WTF/WTFString.cpp
>index a06a671e1957c2e76cde798761e06a07021fa953..7a057dcafda6664fade608d69f2efc6a412f6826 100644
>--- a/Tools/TestWebKitAPI/Tests/WTF/WTFString.cpp
>+++ b/Tools/TestWebKitAPI/Tests/WTF/WTFString.cpp
>@@ -74,7 +74,7 @@ TEST(WTF, StringASCII)
> static inline const char* testStringNumberFixedPrecision(double number)
> {
>     static char testBuffer[100] = { };
>-    std::strncpy(testBuffer, String::number(number).utf8().data(), 99);
>+    std::strncpy(testBuffer, String::numberToStringFixedPrecision(number).utf8().data(), 99);
>     return testBuffer;
> }
>

Actions: View | Formatted Diff | Diff

Attachments on bug 178319: 323834 | 325269 | 325307 | 325312 | 325316 | 325325 | 325326 | 325330 | 325332 | 325333 | 325334 | 325679 | 364944 | 364987 | 369725 | 369730 | 369731 | 369816 | 369918