Attachment 369778 Details for Bug 197806 – Patch for landing

[patch] Patch for landing

bug-197806-20190513135026.patch (text/plain), 11.09 KB, created by Megan Gardner on 2019-05-13 13:50:26 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Megan Gardner

Created: 2019-05-13 13:50:26 PDT

Size: 11.09 KB

patch

obsolete

>Subversion Revision: 245197
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index 512e5219ce9f424363417651821abf1105c2a3c5..89146562e81c69dc4a2613afe7e0b96e05368413 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,28 @@
>+2019-05-10  Megan Gardner  <megan_gardner@apple.com>
>+
>+        Alter Conic Gradient tests to be less subject to noise
>+        https://bugs.webkit.org/show_bug.cgi?id=197806
>+        <rdar://problem/47272067>
>+
>+        Reviewed by Wenson Hsieh.
>+
>+        There is a currently a bug where there's a lot of detectable noise in
>+        the green gradients. Replace them with the less noisy magenta or blue.
>+        <rdar://problem/50682535>
>+
>+        * fast/gradients/conic-extended-stops-expected.html:
>+        * fast/gradients/conic-extended-stops.html:
>+        * fast/gradients/conic-from-angle-expected.html:
>+        * fast/gradients/conic-from-angle.html:
>+        * fast/gradients/conic-gradient-expected.html:
>+        * fast/gradients/conic-gradient-extended-stops-expected.html:
>+        * fast/gradients/conic-gradient-extended-stops.html:
>+        * fast/gradients/conic-gradient.html:
>+        * fast/gradients/conic-off-center-expected.html:
>+        * fast/gradients/conic-off-center.html:
>+        * fast/gradients/conic-two-hints-expected.html:
>+        * fast/gradients/conic-two-hints.html:
>+
> 2019-05-10  Zalan Bujtas  <zalan@apple.com>
> 
>         [iOS] baidu.com: Synthetic bold renders too far apart, appears doubled.
>diff --git a/LayoutTests/fast/gradients/conic-extended-stops-expected.html b/LayoutTests/fast/gradients/conic-extended-stops-expected.html
>index 5b93fedf787c883d3f195e3608f01680a28445c6..cfdfc08bd7efa167783cff373987105e8fc364a5 100644
>--- a/LayoutTests/fast/gradients/conic-extended-stops-expected.html
>+++ b/LayoutTests/fast/gradients/conic-extended-stops-expected.html
>@@ -14,7 +14,7 @@
>             height: 25px;
>             width: 25px;
>             clear: left;
>-            background-color: green;
>+            background-color: magenta;
>         }
>         #box3 {
>             height: 25px;
>diff --git a/LayoutTests/fast/gradients/conic-extended-stops.html b/LayoutTests/fast/gradients/conic-extended-stops.html
>index 996ff740e22b6d4bce7aa8099ce0f709e1f45d16..55dc201b3fd49a2788de6bb11c2af6d1d307ad1b 100644
>--- a/LayoutTests/fast/gradients/conic-extended-stops.html
>+++ b/LayoutTests/fast/gradients/conic-extended-stops.html
>@@ -4,7 +4,7 @@
>         #grad {
>             height: 50px;
>             width: 50px;
>-            background: conic-gradient(blue -50deg, blue 90deg, orange 90deg, orange 180deg, green 180deg, green 270deg, blue 270deg, blue 540deg);
>+            background: conic-gradient(blue -50deg, blue 90deg, orange 90deg, orange 180deg, magenta 180deg, magenta 270deg, blue 270deg, blue 540deg);
>         }
>     </style>
> </head>
>diff --git a/LayoutTests/fast/gradients/conic-from-angle-expected.html b/LayoutTests/fast/gradients/conic-from-angle-expected.html
>index 072265d11e5a10dfaee0bd8947f5e8cab89c1e21..dbe06f8ce56d386b956cd6e58b0d23e93e1427c1 100644
>--- a/LayoutTests/fast/gradients/conic-from-angle-expected.html
>+++ b/LayoutTests/fast/gradients/conic-from-angle-expected.html
>@@ -8,14 +8,14 @@
>         #top {
>             width: 0; 
>             height: 0; 
>-            border-left: 100px solid green;
>+            border-left: 100px solid magenta;
>             border-right: 100px solid blue;
>             border-top: 100px solid yellow;
>         }
>         #bottom {
>             width: 0; 
>             height: 0; 
>-            border-left: 100px solid green;
>+            border-left: 100px solid magenta;
>             border-right: 100px solid blue;
>             border-bottom: 100px solid orange;
>         }
>diff --git a/LayoutTests/fast/gradients/conic-from-angle.html b/LayoutTests/fast/gradients/conic-from-angle.html
>index aa0af1affea9c5345418e6f7648c408405ec9841..2b3007647d915b3e6ef0a6c06c933d11ecb9f085 100644
>--- a/LayoutTests/fast/gradients/conic-from-angle.html
>+++ b/LayoutTests/fast/gradients/conic-from-angle.html
>@@ -10,7 +10,7 @@
>           background: conic-gradient(from 45deg,
>                 blue 0deg, blue 90deg,
>                 orange 0deg, orange 180deg,
>-                green 0deg, green 270deg,
>+                magenta 0deg, magenta 270deg,
>                 yellow 0deg, yellow 360deg);
>         }
>         .x {
>diff --git a/LayoutTests/fast/gradients/conic-gradient-expected.html b/LayoutTests/fast/gradients/conic-gradient-expected.html
>index 322e16986a2439899a5b09c22aed7cfa5a8e3292..3edd44397ff39e1eb995f6938de52a6caaeb1a1f 100644
>--- a/LayoutTests/fast/gradients/conic-gradient-expected.html
>+++ b/LayoutTests/fast/gradients/conic-gradient-expected.html
>@@ -9,27 +9,27 @@
>         #topleft {
>             width: 0; 
>             height: 0; 
>-            border-left: 100px solid rgb(0,32,0);
>+            border-left: 100px solid rgb(0,0,32);
>             border-top: 100px solid rgb(0,0,0);
>         }
>         #topright {
>             width: 0; 
>             height: 0; 
>-            border-right: 100px solid rgb(0,192,0);
>-            border-top: 100px solid rgb(0,224,0);
>+            border-right: 100px solid rgb(0,0,192);
>+            border-top: 100px solid rgb(0,0,224);
>         }
>         #bottomleft {
>             clear: left;
>             width: 0; 
>             height: 0; 
>-            border-left: 100px solid rgb(0,64,0);
>-            border-bottom: 100px solid rgb(0,96,0);
>+            border-left: 100px solid rgb(0,0,64);
>+            border-bottom: 100px solid rgb(0,0,96);
>         }
>         #bottomright {
>             width: 0; 
>             height: 0; 
>-            border-right: 100px solid rgb(0,160,0);
>-            border-bottom: 100px solid rgb(0,128,0);
>+            border-right: 100px solid rgb(0,0,159);
>+            border-bottom: 100px solid rgb(0,0,128);
>         }
>         .box {
>             position: absolute;
>diff --git a/LayoutTests/fast/gradients/conic-gradient-extended-stops-expected.html b/LayoutTests/fast/gradients/conic-gradient-extended-stops-expected.html
>index f9260b4c0db609477d7517c2395b0964dd7b7bf0..6ebc93715187d16861e297e6f05af636ddb4d224 100644
>--- a/LayoutTests/fast/gradients/conic-gradient-extended-stops-expected.html
>+++ b/LayoutTests/fast/gradients/conic-gradient-extended-stops-expected.html
>@@ -9,27 +9,27 @@
>         #topleft {
>             width: 0; 
>             height: 0; 
>-            border-left: 100px solid rgb(0,80,0);
>-            border-top: 100px solid rgb(0,64,0);
>+            border-left: 100px solid rgb(0,0,80);
>+            border-top: 100px solid rgb(0,0,64);
>         }
>         #topright {
>             width: 0; 
>             height: 0; 
>-            border-right: 100px solid rgb(0,160,0);
>-            border-top: 100px solid rgb(0,176,0);
>+            border-right: 100px solid rgb(0,0,159);
>+            border-top: 100px solid rgb(0,0,175);
>         }
>         #bottomleft {
>             clear: left;
>             width: 0; 
>             height: 0; 
>-            border-left: 100px solid rgb(0,96,0);
>-            border-bottom: 100px solid rgb(0,112,0);
>+            border-left: 100px solid rgb(0,0,96);
>+            border-bottom: 100px solid rgb(0,0,112);
>         }
>         #bottomright {
>             width: 0; 
>             height: 0; 
>-            border-right: 100px solid rgb(0,144,0);
>-            border-bottom: 100px solid rgb(0,128,0);
>+            border-right: 100px solid rgb(0,0,143);
>+            border-bottom: 100px solid rgb(0,0,128);
>         }
>         .box {
>             position: absolute;
>diff --git a/LayoutTests/fast/gradients/conic-gradient-extended-stops.html b/LayoutTests/fast/gradients/conic-gradient-extended-stops.html
>index 1bd4b59180ddfc5e1751255e09f45f25f00170ab..6ee41575413336c63d9369b2efdcffbdc6b2a473 100644
>--- a/LayoutTests/fast/gradients/conic-gradient-extended-stops.html
>+++ b/LayoutTests/fast/gradients/conic-gradient-extended-stops.html
>@@ -13,7 +13,7 @@
>         position: absolute;
>         width: 200px;
>         height: 200px;
>-        background-image: conic-gradient(lime -180deg, black 540deg);
>+        background-image: conic-gradient(blue -180deg, black 540deg);
>         filter: url(#posterize);
>     }
> 
>diff --git a/LayoutTests/fast/gradients/conic-gradient.html b/LayoutTests/fast/gradients/conic-gradient.html
>index 73847024f9139ad103f3a97cb43b3a91bc6e1bab..8975e664dbd9c9ce486855ea846aa40542128811 100644
>--- a/LayoutTests/fast/gradients/conic-gradient.html
>+++ b/LayoutTests/fast/gradients/conic-gradient.html
>@@ -13,7 +13,7 @@
>         position: absolute;
>         width: 200px;
>         height: 200px;
>-        background-image: conic-gradient(lime, black);
>+        background-image: conic-gradient(blue, black);
>         filter: url(#posterize);
>     }
> 
>diff --git a/LayoutTests/fast/gradients/conic-off-center-expected.html b/LayoutTests/fast/gradients/conic-off-center-expected.html
>index 52883f2cce9e9863784646c42f03a5dc0ef3a6f4..8526ed80b66afe9d72326807b73c641dd5d319d3 100644
>--- a/LayoutTests/fast/gradients/conic-off-center-expected.html
>+++ b/LayoutTests/fast/gradients/conic-off-center-expected.html
>@@ -14,7 +14,7 @@
>             height: 40px;
>             width: 10px;
>             clear: left;
>-            background-color: green;
>+            background-color: magenta;
>         }
>         #box3 {
>             height: 40px;
>diff --git a/LayoutTests/fast/gradients/conic-off-center.html b/LayoutTests/fast/gradients/conic-off-center.html
>index c73e2ed45e684667902a05ab2d6b595eb5b8b38e..0194fbd70b01a654da6c0ca81ccb7be1d044b44e 100644
>--- a/LayoutTests/fast/gradients/conic-off-center.html
>+++ b/LayoutTests/fast/gradients/conic-off-center.html
>@@ -4,7 +4,7 @@
>         #grad {
>             height: 50px;
>             width: 50px;
>-            background: conic-gradient(at 10px 10px, blue 0deg, blue 90deg, orange 90deg, orange 180deg, green 180deg, green 270deg, blue 270deg, blue 360deg);
>+            background: conic-gradient(at 10px 10px, blue 0deg, blue 90deg, orange 90deg, orange 180deg, magenta 180deg, magenta 270deg, blue 270deg, blue 360deg);
>         }
>     </style>
> </head>
>diff --git a/LayoutTests/fast/gradients/conic-two-hints-expected.html b/LayoutTests/fast/gradients/conic-two-hints-expected.html
>index 7b71df1ae38616a31cbdfb04b732cc94400a8175..5ffa8ea701875132a1fba27ba264faa959749a29 100644
>--- a/LayoutTests/fast/gradients/conic-two-hints-expected.html
>+++ b/LayoutTests/fast/gradients/conic-two-hints-expected.html
>@@ -19,7 +19,7 @@
>             height: 25px;
>             width: 25px;
>             clear: left;
>-            background-color: green;
>+            background-color: magenta;
>         }
>     </style>
> </head>
>diff --git a/LayoutTests/fast/gradients/conic-two-hints.html b/LayoutTests/fast/gradients/conic-two-hints.html
>index 43928120a6f859e5a3410554fe0a3370bf035f98..1f8cf85ec922bd48970f84c419810e10efa5d7a7 100644
>--- a/LayoutTests/fast/gradients/conic-two-hints.html
>+++ b/LayoutTests/fast/gradients/conic-two-hints.html
>@@ -4,7 +4,7 @@
>         #grad {
>             height: 50px;
>             width: 50px;
>-            background: conic-gradient(blue 0deg 90deg, green 90deg 180deg, orange 180deg 360deg);
>+            background: conic-gradient(blue 0deg 90deg, magenta 90deg 180deg, orange 180deg 360deg);
>         }
>     </style>
> </head>

Actions: View | Formatted Diff | Diff

Attachments on bug 197806: 369625 | 369778