Attachment 369667 Details for Bug 185764 – Patch to add set_device_scale_factor implementation declared by libwpe

[patch] Patch to add set_device_scale_factor implementation declared by libwpe

hidpi.diff (text/plain), 1.93 KB, created by Ryan Walklin on 2019-05-11 20:02:49 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Ryan Walklin

Created: 2019-05-11 20:02:49 PDT

Size: 1.93 KB

patch

obsolete

>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index b808218101..4f21d7bf04 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,18 @@
>+2019-05-09  Ryan Walklin  <ryan@testtoast.com>
>+
>+        [WPE] Rendering on a HiDPI display looks scaled up instead of rendered at 2x
>+        https://bugs.webkit.org/show_bug.cgi?id=185764
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Add a function to the wpe_view_backend_client struct which accepts a device scale factor
>+        configured through wpe_view_backend_dispatch_set_device_scale_factor() and calls
>+        setIntrinsicDeviceScaleFactor for the the current View.Page object. The
>+        function definition has been added in libwpe 1.3.
>+
>+        * UIProcess/API/wpe/WPEView.cpp:
>+        (WKWPE::m_backend): Add set_device_scale_factor implementation declared by libwpe.
>+
> 2019-05-08  Antoine Quint  <graouts@apple.com>
> 
>         [iOS] Correctly handle overlapping regions for elements with a touch-action property
>diff --git a/Source/WebKit/UIProcess/API/wpe/WPEView.cpp b/Source/WebKit/UIProcess/API/wpe/WPEView.cpp
>index 0bc7cb8d7c..3060d85535 100644
>--- a/Source/WebKit/UIProcess/API/wpe/WPEView.cpp
>+++ b/Source/WebKit/UIProcess/API/wpe/WPEView.cpp
>@@ -100,9 +100,19 @@ View::View(struct wpe_view_backend* backend, const API::PageConfiguration& baseC
>                 flags.add(WebCore::ActivityState::IsInWindow);
>             view.setViewState(flags);
>         },
>-        // padding
>+        // get_accessible
>         nullptr,
>+#if WPE_CHECK_VERSION(1, 3, 0)
>+        // set_device_scale_factor
>+        [](void* data, float scale)
>+        {
>+            auto& view = *reinterpret_cast<View*>(data);
>+            view.page().setIntrinsicDeviceScaleFactor(scale);
>+        },
>+#else
>         nullptr,
>+#endif // WPE_CHECK_VERSION(1, 3, 0)
>+        // padding,
>         nullptr
>     };
>     wpe_view_backend_set_backend_client(m_backend, &s_backendClient, this);

Actions: View | Formatted Diff | Diff

Attachments on bug 185764: 340688 | 343499 | 343891 | 347582 | 347583 | 347605 | 369485 | 369525 | 369667