Attachment 369614 Details for Bug 197757 – patch

[patch] patch

b-backup.diff (text/plain), 1.28 KB, created by Saam Barati on 2019-05-10 16:17:39 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Saam Barati

Created: 2019-05-10 16:17:39 PDT

Size: 1.28 KB

patch

obsolete

>Index: Source/WTF/ChangeLog
>===================================================================
>--- Source/WTF/ChangeLog	(revision 245197)
>+++ Source/WTF/ChangeLog	(working copy)
>@@ -1,3 +1,16 @@
>+2019-05-10  Saam barati  <sbarati@apple.com>
>+
>+        Bag's move operator= leaks memory
>+        https://bugs.webkit.org/show_bug.cgi?id=197757
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        It was unused. So I'm just removing it. We can implement it properly
>+        if we ever need it.
>+
>+        * wtf/Bag.h:
>+        (WTF::Bag::operator=): Deleted.
>+
> 2019-05-10  Fujii Hironori  <Hironori.Fujii@sony.com>
> 
>         [WinCairo] storage/indexeddb tests are timing out
>Index: Source/WTF/wtf/Bag.h
>===================================================================
>--- Source/WTF/wtf/Bag.h	(revision 245197)
>+++ Source/WTF/wtf/Bag.h	(working copy)
>@@ -65,13 +65,13 @@ public:
>         other.m_head = nullptr;
>     }
> 
>-    template<typename U>
>-    Bag& operator=(Bag<T, U>&& other)
>-    {
>-        m_head = other.unwrappedHead();
>-        other.m_head = nullptr;
>-        return *this;
>-    }
>+    //template<typename U>
>+    //Bag& operator=(Bag<T, U>&& other)
>+    //{
>+    //    m_head = other.unwrappedHead();
>+    //    other.m_head = nullptr;
>+    //    return *this;
>+    //}
>     
>     ~Bag()
>     {

Actions: View | Formatted Diff | Diff

Attachments on bug 197757: 369614 | 369615