Attachment 369547 Details for Bug 197694 – patch

[patch] patch

event-region-backing-sharing.patch (text/plain), 2.94 KB, created by Antti Koivisto on 2019-05-10 00:39:52 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Antti Koivisto

Created: 2019-05-10 00:39:52 PDT

Size: 2.94 KB

patch

obsolete

>Index: Source/WebCore/ChangeLog
>===================================================================
>--- Source/WebCore/ChangeLog	(revision 245171)
>+++ Source/WebCore/ChangeLog	(working copy)
>@@ -1,3 +1,16 @@
>+2019-05-10  Antti Koivisto  <antti@apple.com>
>+
>+        Event region generation needs to know about backing-sharing
>+        https://bugs.webkit.org/show_bug.cgi?id=197694
>+        <rdar://problem/50584991>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * rendering/RenderLayerBacking.cpp:
>+        (WebCore::RenderLayerBacking::updateEventRegion):
>+
>+        Gather event region from backing sharing layers too.
>+
> 2019-05-09  Simon Fraser  <simon.fraser@apple.com>
> 
>         Implement backing-sharing in compositing layers, allowing overlap layers to paint into the backing store of another layer
>Index: Source/WebCore/rendering/RenderLayerBacking.cpp
>===================================================================
>--- Source/WebCore/rendering/RenderLayerBacking.cpp	(revision 245170)
>+++ Source/WebCore/rendering/RenderLayerBacking.cpp	(working copy)
>@@ -1493,6 +1493,9 @@ void RenderLayerBacking::updateEventRegi
>     auto paintFlags = RenderLayer::paintLayerPaintingCompositingAllPhasesFlags() | RenderLayer::PaintLayerCollectingEventRegion;
>     m_owningLayer.paintLayerContents(nullContext, paintingInfo, paintFlags);
> 
>+    for (auto& layerWeakPtr : m_backingSharingLayers)
>+        layerWeakPtr->paintLayerContents(nullContext, paintingInfo, paintFlags);
>+
>     auto contentOffset = roundedIntSize(contentOffsetInCompositingLayer());
>     eventRegion.translate(contentOffset);
>     m_graphicsLayer->setEventRegion(WTFMove(eventRegion));
>Index: LayoutTests/ChangeLog
>===================================================================
>--- LayoutTests/ChangeLog	(revision 245170)
>+++ LayoutTests/ChangeLog	(working copy)
>@@ -1,3 +1,13 @@
>+2019-05-10  Antti Koivisto  <antti@apple.com>
>+
>+        Event region generation needs to know about backing-sharing
>+        https://bugs.webkit.org/show_bug.cgi?id=197694
>+        <rdar://problem/50584991>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * platform/ios-wk2/TestExpectations:
>+
> 2019-05-09  Simon Fraser  <simon.fraser@apple.com>
> 
>         Implement backing-sharing in compositing layers, allowing overlap layers to paint into the backing store of another layer
>Index: LayoutTests/platform/ios-wk2/TestExpectations
>===================================================================
>--- LayoutTests/platform/ios-wk2/TestExpectations	(revision 245170)
>+++ LayoutTests/platform/ios-wk2/TestExpectations	(working copy)
>@@ -1076,7 +1076,6 @@ webkit.org/b/156620 legacy-animation-eng
> webkit.org/b/153049 perf/array-binary-search.html [ Pass Failure Timeout ]
> 
> fast/scrolling/ios/scroll-events-back-forward-after-pageshow.html [ Pass Failure ]
>-webkit.org/b/197694 fast/scrolling/ios/overflow-scroll-overlap-4.html [ Failure ]
> 
> webkit.org/b/157589 fast/text-autosizing/ios/text-autosizing-after-back.html [ Pass Timeout ]
>

Actions: View | Formatted Diff | Diff

Attachments on bug 197694: 369547 | 369548