Attachment 369527 Details for Bug 193876 – To land

[patch] To land

bug-193876-20190509155655.patch (text/plain), 4.13 KB, created by Daniel Bates on 2019-05-09 15:56:56 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Daniel Bates

Created: 2019-05-09 15:56:56 PDT

Size: 4.13 KB

patch

obsolete

>Subversion Revision: 244742
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 296438a41ef2ff12ea9aa8e0bf414a6eea9f89a1..17830f133656c194199bb6685fb1713057af232e 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,18 @@
>+2019-05-09  Daniel Bates  <dabates@apple.com>
>+
>+        [iOS] Right command key has wrong value for property code
>+        https://bugs.webkit.org/show_bug.cgi?id=193876
>+        <rdar://problem/47577308>
>+
>+        Reviewed by Brent Fulgham.
>+
>+        We're looking for the wrong Windows virtual key code for the right command key.
>+        Substitute VK_APPS for VK_RWIN so we can identify the right command key and return
>+        the correct value for the code property of the DOM key event.
>+
>+        * platform/ios/PlatformEventFactoryIOS.mm:
>+        (WebCore::codeForKeyEvent):
>+
> 2019-05-09  Daniel Bates  <dabates@apple.com>
> 
>         [iOS] Numpad comma key has incorrect keyIdentifier property
>diff --git a/Source/WebCore/platform/ios/PlatformEventFactoryIOS.mm b/Source/WebCore/platform/ios/PlatformEventFactoryIOS.mm
>index 63221d4552f1f614c9f85601748ada3682d5c931..b33da5dca47736e52c5baaf04143838823641489 100644
>--- a/Source/WebCore/platform/ios/PlatformEventFactoryIOS.mm
>+++ b/Source/WebCore/platform/ios/PlatformEventFactoryIOS.mm
>@@ -275,7 +275,7 @@ String codeForKeyEvent(WebEvent *event)
>     case VK_RCONTROL: return "ControlRight"_s;
>     case VK_RETURN: return "Enter"_s; //  Labeled Return on Apple keyboards.
>     case VK_LWIN: return "MetaLeft"_s;
>-    case VK_RWIN: return "MetaRight"_s;
>+    case VK_APPS: return "MetaRight"_s;
>     case VK_LSHIFT: return "ShiftLeft"_s;
>     case VK_RSHIFT: return "ShiftRight"_s;
>     case VK_SPACE: return "Space"_s;
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index f64bc98924e99f042e4c01bf38360163a2eb8eb0..adede898c133099f0ae7056361955a2c9c888ef4 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,15 @@
>+2019-05-09  Daniel Bates  <dabates@apple.com>
>+
>+        [iOS] Right command key has wrong value for property code
>+        https://bugs.webkit.org/show_bug.cgi?id=193876
>+        <rdar://problem/47577308>
>+
>+        Reviewed by Brent Fulgham.
>+
>+        Update test result.
>+
>+        * fast/events/ios/keydown-keyup-special-keys-in-non-editable-element-expected.txt:
>+
> 2019-05-09  Daniel Bates  <dabates@apple.com>
> 
>         [iOS] Numpad comma key has incorrect keyIdentifier property
>diff --git a/LayoutTests/fast/events/ios/keydown-keyup-special-keys-in-non-editable-element-expected.txt b/LayoutTests/fast/events/ios/keydown-keyup-special-keys-in-non-editable-element-expected.txt
>index 400e289e54102def17ea2fdc3cb2825e1919e507..9e536ffa5d247ab36d3a35727e05a23ec6435238 100644
>--- a/LayoutTests/fast/events/ios/keydown-keyup-special-keys-in-non-editable-element-expected.txt
>+++ b/LayoutTests/fast/events/ios/keydown-keyup-special-keys-in-non-editable-element-expected.txt
>@@ -38,8 +38,8 @@ type: keydown, key: Enter, code: Enter, keyIdentifier: Enter, keyCode: 13, charC
> type: keyup, key: Dead, code: Enter, keyIdentifier: Unidentified, keyCode: 13, charCode: 0, keyCode: 13, which: 13
> type: keydown, key: Alt, code: Unidentified, keyIdentifier: Alt, keyCode: 18, charCode: 0, keyCode: 18, which: 18
> type: keyup, key: Alt, code: Unidentified, keyIdentifier: Alt, keyCode: 18, charCode: 0, keyCode: 18, which: 18
>-type: keydown, key: Meta, code: Unidentified, keyIdentifier: Meta, keyCode: 93, charCode: 0, keyCode: 93, which: 93
>-type: keyup, key: Meta, code: Unidentified, keyIdentifier: Meta, keyCode: 93, charCode: 0, keyCode: 93, which: 93
>+type: keydown, key: Meta, code: MetaRight, keyIdentifier: Meta, keyCode: 93, charCode: 0, keyCode: 93, which: 93
>+type: keyup, key: Meta, code: MetaRight, keyIdentifier: Meta, keyCode: 93, charCode: 0, keyCode: 93, which: 93
> type: keydown, key: Control, code: ControlRight, keyIdentifier: Control, keyCode: 17, charCode: 0, keyCode: 17, which: 17
> type: keyup, key: Control, code: ControlRight, keyIdentifier: Control, keyCode: 17, charCode: 0, keyCode: 17, which: 17
> type: keydown, key: Shift, code: ShiftRight, keyIdentifier: Shift, keyCode: 16, charCode: 0, keyCode: 16, which: 16

Actions: View | Formatted Diff | Diff

Attachments on bug 193876: 369523 | 369527