Attachment 369500 Details for Bug 197736 – Patch

[patch] Patch

bug-197736-20190509203350.patch (text/plain), 1.77 KB, created by Rob Buis on 2019-05-09 11:33:50 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Rob Buis

Created: 2019-05-09 11:33:50 PDT

Size: 1.77 KB

patch

obsolete

>Subversion Revision: 245127
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index b8082181010baea60ae247624c9165dbcad66457..ae75f602e8d9563c7efb44e9fb4a8271cc61cb45 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,15 @@
>+2019-05-09  Rob Buis  <rbuis@igalia.com>
>+
>+        Limit number of prefetches of a given page
>+        https://bugs.webkit.org/show_bug.cgi?id=197736
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Limit prefetches for same url to 1.
>+
>+        * NetworkProcess/cache/PrefetchCache.cpp:
>+        (WebKit::PrefetchCache::store):
>+
> 2019-05-08  Antoine Quint  <graouts@apple.com>
> 
>         [iOS] Correctly handle overlapping regions for elements with a touch-action property
>diff --git a/Source/WebKit/NetworkProcess/cache/PrefetchCache.cpp b/Source/WebKit/NetworkProcess/cache/PrefetchCache.cpp
>index 73cab47f91ee74241f232fffbe3f992df9c56cfc..0401fc98b416ce0a9acd095c3c3a23ea2a38fdbb 100644
>--- a/Source/WebKit/NetworkProcess/cache/PrefetchCache.cpp
>+++ b/Source/WebKit/NetworkProcess/cache/PrefetchCache.cpp
>@@ -69,7 +69,10 @@ void PrefetchCache::store(const URL& requestUrl, WebCore::ResourceResponse&& res
> {
>     if (!m_sessionPrefetches)
>         m_sessionPrefetches = std::make_unique<PrefetchEntriesMap>();
>-    m_sessionPrefetches->set(requestUrl, std::make_unique<PrefetchCache::Entry>(WTFMove(response), WTFMove(buffer)));
>+    auto addResult = m_sessionPrefetches->add(requestUrl, std::make_unique<PrefetchCache::Entry>(WTFMove(response), WTFMove(buffer)));
>+    // Limit prefetches for same url to 1.
>+    if (!addResult.isNewEntry)
>+        return;
>     m_sessionExpirationList.append(std::make_tuple(requestUrl, WallTime::now()));
>     if (!m_expirationTimer.isActive())
>         m_expirationTimer.startOneShot(expirationTimeout);

Actions: View | Formatted Diff | Diff

Attachments on bug 197736: 369487 | 369489 | 369500