Attachment 369402 Details for Bug 197700 – Patch

[patch] Patch

bug-197700-20190508145932.patch (text/plain), 1.77 KB, created by Aakash Jain on 2019-05-08 11:59:33 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Aakash Jain

Created: 2019-05-08 11:59:33 PDT

Size: 1.77 KB

patch

obsolete

>Index: Tools/ChangeLog
>===================================================================
>--- Tools/ChangeLog	(revision 245061)
>+++ Tools/ChangeLog	(working copy)
>@@ -1,3 +1,12 @@
>+2019-05-08  Aakash Jain  <aakash_jain@apple.com>
>+
>+        [ews-app] Production and Development env should configure DEBUG appropriately
>+        https://bugs.webkit.org/show_bug.cgi?id=197700
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * BuildSlaveSupport/ews-app/ews-app/settings.py:
>+
> 2019-05-08  Ryan Haddad  <ryanhaddad@apple.com>
> 
>         Unreviewed, rolling out r244952.
>Index: Tools/BuildSlaveSupport/ews-app/ews-app/settings.py
>===================================================================
>--- Tools/BuildSlaveSupport/ews-app/ews-app/settings.py	(revision 245061)
>+++ Tools/BuildSlaveSupport/ews-app/ews-app/settings.py	(working copy)
>@@ -33,6 +33,8 @@ https://docs.djangoproject.com/en/1.11/r
> 
> import os
> 
>+is_test_mode_enabled = os.getenv('EWS_PRODUCTION') is None
>+
> # Build paths inside the project like this: os.path.join(BASE_DIR, ...)
> BASE_DIR = os.path.dirname(os.path.dirname(os.path.abspath(__file__)))
> 
>@@ -43,8 +45,10 @@ BASE_DIR = os.path.dirname(os.path.dirna
> # SECURITY WARNING: keep the secret key used in production secret!
> SECRET_KEY = os.environ.get('EWS_SECRET_KEY', 'secret')
> 
>-# SECURITY WARNING: don't run with debug turned on in production!
>-DEBUG = True
>+DEBUG = False
>+if is_test_mode_enabled:
>+    # SECURITY WARNING: don't run with debug turned on in production!
>+    DEBUG = True
> 
> ALLOWED_HOSTS = ['*']
> 
>@@ -95,7 +99,6 @@ WSGI_APPLICATION = 'ews-app.wsgi.applica
> # Database
> # https://docs.djangoproject.com/en/1.11/ref/settings/#databases
> 
>-is_test_mode_enabled = os.getenv('EWS_PRODUCTION') is None
> if is_test_mode_enabled:
>     DATABASES = {
>         'default': {

Actions: View | Formatted Diff | Diff

Attachments on bug 197700: 369402 | 369463