Attachment 369341 Details for Bug 197681 – Patch

[patch] Patch

bug-197681.diff (text/plain), 2.64 KB, created by Don Olmstead on 2019-05-07 17:39:54 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Don Olmstead

Created: 2019-05-07 17:39:54 PDT

Size: 2.64 KB

patch

obsolete

>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 291e2ca308b..9849072d37c 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,15 @@
>+2019-05-07  Don Olmstead  <don.olmstead@sony.com>
>+
>+        WEBCORE_EXPORT shouldn't be on the class and its methods
>+        https://bugs.webkit.org/show_bug.cgi?id=197681
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Remove WEBCORE_EXPORT from the methods.
>+
>+        * page/scrolling/ScrollingTreeFrameScrollingNode.h:
>+        * page/scrolling/ScrollingTreeScrollingNode.h:
>+
> 2019-05-07  Eric Carlson  <eric.carlson@apple.com>
> 
>         Define media buffering policy
>diff --git a/Source/WebCore/page/scrolling/ScrollingTreeFrameScrollingNode.h b/Source/WebCore/page/scrolling/ScrollingTreeFrameScrollingNode.h
>index 59ca2f650d1..35d2c1cc3df 100644
>--- a/Source/WebCore/page/scrolling/ScrollingTreeFrameScrollingNode.h
>+++ b/Source/WebCore/page/scrolling/ScrollingTreeFrameScrollingNode.h
>@@ -69,7 +69,7 @@ private:
>     LayoutPoint parentToLocalPoint(LayoutPoint) const final;
>     LayoutPoint localToContentsPoint(LayoutPoint) const final;
> 
>-    WEBCORE_EXPORT void updateViewportForCurrentScrollPosition(Optional<FloatRect>) override;
>+    void updateViewportForCurrentScrollPosition(Optional<FloatRect>) override;
>     bool scrollPositionAndLayoutViewportMatch(const FloatPoint& position, Optional<FloatRect> overrideLayoutViewport) override;
> 
>     void dumpProperties(WTF::TextStream&, ScrollingStateTreeAsTextBehavior) const override;
>diff --git a/Source/WebCore/page/scrolling/ScrollingTreeScrollingNode.h b/Source/WebCore/page/scrolling/ScrollingTreeScrollingNode.h
>index 97384836133..fdc91b40e82 100644
>--- a/Source/WebCore/page/scrolling/ScrollingTreeScrollingNode.h
>+++ b/Source/WebCore/page/scrolling/ScrollingTreeScrollingNode.h
>@@ -101,11 +101,11 @@ protected:
>     virtual FloatPoint adjustedScrollPosition(const FloatPoint&, ScrollPositionClamp = ScrollPositionClamp::ToContentEdges) const;
> 
>     virtual void currentScrollPositionChanged();
>-    WEBCORE_EXPORT virtual void updateViewportForCurrentScrollPosition(Optional<FloatRect> = { }) { }
>+    virtual void updateViewportForCurrentScrollPosition(Optional<FloatRect> = { }) { }
>     virtual bool scrollPositionAndLayoutViewportMatch(const FloatPoint& position, Optional<FloatRect> overrideLayoutViewport);
> 
>-    WEBCORE_EXPORT virtual void repositionScrollingLayers() { }
>-    WEBCORE_EXPORT virtual void repositionRelatedLayers() { }
>+    virtual void repositionScrollingLayers() { }
>+    virtual void repositionRelatedLayers() { }
> 
>     void applyLayerPositions(const FloatRect& layoutViewport, FloatSize& cumulativeDelta) override;
>

Actions: View | Formatted Diff | Diff

Attachments on bug 197681: 369341 | 369353