Attachment 369283 Details for Bug 194865 – Patch

[patch] Patch

bug-194865-20190507195844.patch (text/plain), 1.73 KB, created by Alice Mikhaylenko on 2019-05-07 07:58:45 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Alice Mikhaylenko

Created: 2019-05-07 07:58:45 PDT

Size: 1.73 KB

patch

obsolete

>Subversion Revision: 245007
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 33eff1465fc00de4679db854460c2972e0d4b1f9..f48079629edee6f91845a80bb2316ea46a1a2917 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,15 @@
>+2019-05-07  Alexander Mikhaylenko  <exalm7659@gmail.com>
>+
>+        [GTK] Pinch Zooming has no maximum
>+        https://bugs.webkit.org/show_bug.cgi?id=194865
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Set maximum zoom to 3.0, reflecting the value on macOS and iOS.
>+
>+        * UIProcess/gtk/GestureController.cpp:
>+        (WebKit::GestureController::ZoomGesture::scaleChanged):
>+
> 2019-05-07  Antti Koivisto  <antti@apple.com>
> 
>         <body> with overflow:hidden CSS is scrollable on iOS
>diff --git a/Source/WebKit/UIProcess/gtk/GestureController.cpp b/Source/WebKit/UIProcess/gtk/GestureController.cpp
>index 3d27d6bfa5f8441a95dd5d03a31d1302df5c0da3..5f58449102fb8e07b90f3d04de38dadb051f35c7 100644
>--- a/Source/WebKit/UIProcess/gtk/GestureController.cpp
>+++ b/Source/WebKit/UIProcess/gtk/GestureController.cpp
>@@ -34,6 +34,8 @@
> namespace WebKit {
> using namespace WebCore;
> 
>+static const double maximumZoom = 3.0;
>+
> GestureController::GestureController(GtkWidget* widget, std::unique_ptr<GestureControllerClient>&& client)
>     : m_client(WTFMove(client))
>     , m_dragGesture(widget, *m_client)
>@@ -214,6 +216,8 @@ void GestureController::ZoomGesture::scaleChanged(ZoomGesture* zoomGesture, doub
>     zoomGesture->m_scale = zoomGesture->m_initialScale * scale;
>     if (zoomGesture->m_scale < 1.0)
>         zoomGesture->m_scale = 1.0;
>+    if (zoomGesture->m_scale > maximumZoom)
>+        zoomGesture->m_scale = maximumZoom;
> 
>     zoomGesture->m_viewPoint = zoomGesture->center();
>

Actions: View | Formatted Diff | Diff

Attachments on bug 194865: 369283 | 369292