Attachment 369279 Details for Bug 197659 – patch

[patch] patch

overflow-hidden-keyboard.patch (text/plain), 1.34 KB, created by Antti Koivisto on 2019-05-07 07:07:06 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Antti Koivisto

Created: 2019-05-07 07:07:06 PDT

Size: 1.34 KB

patch

obsolete

>Index: Source/WebKit/ChangeLog
>===================================================================
>--- Source/WebKit/ChangeLog	(revision 245007)
>+++ Source/WebKit/ChangeLog	(working copy)
>@@ -1,3 +1,17 @@
>+2019-05-07  Antti Koivisto  <antti@apple.com>
>+
>+        <body> with overflow:hidden shouldn't be keyboard scrollable on iOS
>+        https://bugs.webkit.org/show_bug.cgi?id=197659
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        No test, there appears to be no UIScript support for key events on iOS at the moment.
>+
>+        * UIProcess/ios/WKContentViewInteraction.mm:
>+        (-[WKContentView isScrollableForKeyboardScrollViewAnimator:]):
>+
>+        Disable keyboard scrolling when touch scrolling is disabled.
>+
> 2019-05-07  Antti Koivisto  <antti@apple.com>
> 
>         <body> with overflow:hidden CSS is scrollable on iOS
>Index: Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
>===================================================================
>--- Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm	(revision 245007)
>+++ Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm	(working copy)
>@@ -4620,6 +4620,9 @@ - (BOOL)isScrollableForKeyboardScrollVie
>     if (_focusedElementInformation.elementType == WebKit::InputType::Select)
>         return NO;
> 
>+    if (!_webView.scrollView.scrollEnabled)
>+        return NO;
>+
>     return YES;
> }
>

Actions: View | Formatted Diff | Diff

Attachments on bug 197659: 369279 | 369284 | 369285