Attachment 369197 Details for Bug 197633 – PATCH

[patch] PATCH

197633.diff (text/plain), 1.33 KB, created by Basuke Suzuki on 2019-05-06 16:28:44 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Basuke Suzuki

Created: 2019-05-06 16:28:44 PDT

Size: 1.33 KB

patch

obsolete

>diff --git a/Source/WTF/ChangeLog b/Source/WTF/ChangeLog
>index 8da671ede38..7774e6a673e 100644
>--- a/Source/WTF/ChangeLog
>+++ b/Source/WTF/ChangeLog
>@@ -1,3 +1,15 @@
>+2019-05-06  Christopher Reid  <chris.reid@sony.com>
>+
>+        [JSC] Respect already defined USE_LLINT_EMBEDDED_OPCODE_ID compiler variable.
>+        https://bugs.webkit.org/show_bug.cgi?id=197633
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        When the variable `USE_LLINT_EMBEDDED_OPCODE_ID` is defined, stop defining
>+        its value with platform default one.
>+
>+        * wtf/Platform.h:
>+
> 2019-05-03  Sihui Liu  <sihui_liu@apple.com>
> 
>         Add assertion to check whether shm files have maximum FileProtection of CompleteUnlessOpen
>diff --git a/Source/WTF/wtf/Platform.h b/Source/WTF/wtf/Platform.h
>index 13faf616970..1e83caa891a 100644
>--- a/Source/WTF/wtf/Platform.h
>+++ b/Source/WTF/wtf/Platform.h
>@@ -982,7 +982,7 @@
> #define ENABLE_COMPUTED_GOTO_OPCODES 1
> #endif
> 
>-#if !ENABLE(C_LOOP) && !COMPILER(MSVC) && \
>+#if !ENABLE(C_LOOP) && !COMPILER(MSVC) && !defined(USE_LLINT_EMBEDDED_OPCODE_ID) && \
>     (CPU(X86) || CPU(X86_64) || CPU(ARM64) || (CPU(ARM_THUMB2) && OS(DARWIN)))
> /* This feature works by embedding the OpcodeID in the 32 bit just before the generated LLint code
>    that executes each opcode. It cannot be supported by the CLoop since there's no way to embed the

Flags:

don.olmstead: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 197633: 369196 | 369197 | 369200