Attachment 369194 Details for Bug 197366 – Patch

[patch] Patch

bug-197366-20190506162046.patch (text/plain), 2.70 KB, created by Alex Christensen on 2019-05-06 16:20:47 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Alex Christensen

Created: 2019-05-06 16:20:47 PDT

Size: 2.70 KB

patch

obsolete

>Index: Source/WebKit/ChangeLog
>===================================================================
>--- Source/WebKit/ChangeLog	(revision 244987)
>+++ Source/WebKit/ChangeLog	(working copy)
>@@ -1,3 +1,19 @@
>+2019-05-06  Alex Christensen  <achristensen@webkit.org>
>+
>+        Add assertions to catch NetworkProcess null CompletionHandler dispatching
>+        https://bugs.webkit.org/show_bug.cgi?id=197366
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        This will help us find the cause of rdar://problem/48679972
>+
>+        * NetworkProcess/cache/CacheStorageEngine.cpp:
>+        (WebKit::CacheStorage::Engine::clearAllCachesFromDisk):
>+        (WebKit::CacheStorage::Engine::deleteDirectoryRecursivelyOnBackgroundThread):
>+        * NetworkProcess/cache/NetworkCacheStorage.cpp:
>+        (WebKit::NetworkCache::Storage::remove):
>+        (WebKit::NetworkCache::Storage::clear):
>+
> 2019-05-06  Keith Rollin  <krollin@apple.com>
> 
>         Temporarily disable generate-xcfilelists
>Index: Source/WebKit/NetworkProcess/cache/CacheStorageEngine.cpp
>===================================================================
>--- Source/WebKit/NetworkProcess/cache/CacheStorageEngine.cpp	(revision 244968)
>+++ Source/WebKit/NetworkProcess/cache/CacheStorageEngine.cpp	(working copy)
>@@ -543,6 +543,7 @@ void Engine::clearAllCachesFromDisk(Comp
>             if (FileSystem::fileIsDirectory(filename, FileSystem::ShouldFollowSymbolicLinks::No))
>                 deleteDirectoryRecursively(filename);
>         }
>+        RELEASE_ASSERT(completionHandler);
>         RunLoop::main().dispatch(WTFMove(completionHandler));
>     });
> }
>@@ -594,6 +595,7 @@ void Engine::deleteDirectoryRecursivelyO
>     m_ioQueue->dispatch([path = path.isolatedCopy(), completionHandler = WTFMove(completionHandler)]() mutable {
>         deleteDirectoryRecursively(path);
> 
>+        RELEASE_ASSERT(completionHandler);
>         RunLoop::main().dispatch(WTFMove(completionHandler));
>     });
> }
>Index: Source/WebKit/NetworkProcess/cache/NetworkCacheStorage.cpp
>===================================================================
>--- Source/WebKit/NetworkProcess/cache/NetworkCacheStorage.cpp	(revision 244968)
>+++ Source/WebKit/NetworkProcess/cache/NetworkCacheStorage.cpp	(working copy)
>@@ -614,6 +614,7 @@ void Storage::remove(const Vector<Key>& 
>         for (auto& key : keysToRemove)
>             deleteFiles(key);
> 
>+        RELEASE_ASSERT(completionHandler);
>         RunLoop::main().dispatch(WTFMove(completionHandler));
>     });
> }
>@@ -1014,6 +1015,7 @@ void Storage::clear(const String& type, 
>         // This cleans unreferenced blobs.
>         m_blobStorage.synchronize();
> 
>+        RELEASE_ASSERT(completionHandler);
>         RunLoop::main().dispatch(WTFMove(completionHandler));
>     });
> }

Flags:

cdumez: review+
ews-watchlist: commit-queue-

Actions: View | Formatted Diff | Diff

Attachments on bug 197366: 368452 | 369194 | 369236