Attachment 369190 Details for Bug 195997 – Patch

[patch] Patch

bug-195997-20190506155642.patch (text/plain), 1.68 KB, created by youenn fablet on 2019-05-06 15:56:42 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: youenn fablet

Created: 2019-05-06 15:56:42 PDT

Size: 1.68 KB

patch

obsolete

>Subversion Revision: 244961
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 806e0b1b8cae70cb16c736727c8602b758e4da26..802966c9aa60f8f33fcef0e035080002dec7db88 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,14 @@
>+2019-05-06  Youenn Fablet  <youenn@apple.com>
>+
>+        Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageDefaultDirectories
>+        https://bugs.webkit.org/show_bug.cgi?id=195997
>+        <rdar://problem/50509884>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Spin test until successful. 
>+        * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
>+
> 2019-05-04  Alex Christensen  <achristensen@webkit.org>
> 
>         Revert r244953 and r244954 because they broke internal builds.
>diff --git a/Tools/TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm b/Tools/TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm
>index 1cb90e038eaf3f592c1afd7a879749b76a7503ee..4cd1b3328ad06f8dffe9534f1d36f286a0417df9 100644
>--- a/Tools/TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm
>+++ b/Tools/TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm
>@@ -1396,7 +1396,8 @@ TEST(ServiceWorkers, ServiceWorkerAndCacheStorageDefaultDirectories)
>     [webView loadRequest:request];
>     TestWebKitAPI::Util::run(&done);
>     done = false;
>-    EXPECT_TRUE([[configuration websiteDataStore] _hasRegisteredServiceWorker]);
>+    while (![[configuration websiteDataStore] _hasRegisteredServiceWorker])
>+        TestWebKitAPI::Util::spinRunLoop(0.1);
> 
>     webView = adoptNS([[WKWebView alloc] initWithFrame:NSMakeRect(0, 0, 800, 600) configuration:configuration.get()]);
>     [webView.get().configuration.processPool _registerURLSchemeServiceWorkersCanHandle:@"sw"];

Actions: View | Formatted Diff | Diff

Attachments on bug 195997: 369190 | 369253 | 369321