Attachment 369188 Details for Bug 197629 – Patch

[patch] Patch

bug-197629-20190506154935.patch (text/plain), 1.46 KB, created by Wenson Hsieh on 2019-05-06 15:49:36 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Wenson Hsieh

Created: 2019-05-06 15:49:36 PDT

Size: 1.46 KB

patch

obsolete

>Subversion Revision: 244956
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index f923c1f177614111e53f3b60c30b744df6464999..7e3310de50f66fa61d024b3ae26beae7f55a59af 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,16 @@
>+2019-05-06  Wenson Hsieh  <wenson_hsieh@apple.com>
>+
>+        Occasional crashes in layout tests when firing the shrink-to-fit-content timer
>+        https://bugs.webkit.org/show_bug.cgi?id=197629
>+        <rdar://problem/50514382>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Fixes several crashing layout tests by stopping the shrink-to-fit-content timer when the page closes.
>+
>+        * WebProcess/WebPage/WebPage.cpp:
>+        (WebKit::WebPage::close):
>+
> 2019-05-06  Wenson Hsieh  <wenson_hsieh@apple.com>
> 
>         Introduce SPI to request modern compatibility mode but defer to site-specific quirks
>diff --git a/Source/WebKit/WebProcess/WebPage/WebPage.cpp b/Source/WebKit/WebProcess/WebPage/WebPage.cpp
>index 0d8a0d34cc963c48e5fa2698d85142e527bf144b..09d59633340c2141fa5202ec2fc72d4e196b6cc9 100644
>--- a/Source/WebKit/WebProcess/WebPage/WebPage.cpp
>+++ b/Source/WebKit/WebProcess/WebPage/WebPage.cpp
>@@ -1362,6 +1362,10 @@ void WebPage::close()
>     m_determinePrimarySnapshottedPlugInTimer.stop();
> #endif
> 
>+#if ENABLE(VIEWPORT_RESIZING)
>+    m_shrinkToFitContentTimer.stop();
>+#endif
>+
> #if ENABLE(CONTEXT_MENUS)
>     m_contextMenuClient = std::make_unique<API::InjectedBundle::PageContextMenuClient>();
> #endif

Actions: View | Formatted Diff | Diff

Attachments on bug 197629: 369188