Attachment 369181 Details for Bug 197619 – Patch

[patch] Patch

bug-197619-20190506153456.patch (text/plain), 8.04 KB, created by Keith Rollin on 2019-05-06 15:34:56 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Keith Rollin

Created: 2019-05-06 15:34:56 PDT

Size: 8.04 KB

patch

obsolete

>Subversion Revision: 244964
>diff --git a/Source/JavaScriptCore/ChangeLog b/Source/JavaScriptCore/ChangeLog
>index 7d960395584de6aa830c033c9f0c21d4162c62f6..780d4b0ec93984feeafabcac90e32a644910df58 100644
>--- a/Source/JavaScriptCore/ChangeLog
>+++ b/Source/JavaScriptCore/ChangeLog
>@@ -1,3 +1,19 @@
>+2019-05-06  Keith Rollin  <krollin@apple.com>
>+
>+        Temporarily disable generate-xcfilelists
>+        https://bugs.webkit.org/show_bug.cgi?id=197619
>+        <rdar://problem/50507392>
>+
>+        Reviewed by Alex Christensen.
>+
>+        We need to perform a significant update to the generate-xcfilelist
>+        scripts. This work involves coordinated work with another facility. If
>+        the work does not occur in tandem, the build will be broken. To avoid
>+        this, disable the invoking of the scripts during the transition. The
>+        checking will be restored once the new scripts are in place.
>+
>+        * Scripts/check-xcfilelists.sh:
>+
> 2019-05-04  Tadeu Zagallo  <tzagallo@apple.com>
> 
>         TypedArrays should not store properties that are canonical numeric indices
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index c6c1f7679f545d94a40166b2a4b7d364ff85b7b1..de4b90cac46926c2091a0732b45fa315ce7f5324 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,21 @@
>+2019-05-06  Keith Rollin  <krollin@apple.com>
>+
>+        Temporarily disable generate-xcfilelists
>+        https://bugs.webkit.org/show_bug.cgi?id=197619
>+        <rdar://problem/50507392>
>+
>+        Reviewed by Alex Christensen.
>+
>+        We need to perform a significant update to the generate-xcfilelist
>+        scripts. This work involves coordinated work with another facility. If
>+        the work does not occur in tandem, the build will be broken. To avoid
>+        this, disable the invoking of the scripts during the transition. The
>+        checking will be restored once the new scripts are in place.
>+
>+        No new tests -- no change in user-visible functionality.
>+
>+        * Scripts/check-xcfilelists.sh:
>+
> 2019-05-06  Zan Dobersek  <zdobersek@igalia.com>
> 
>         [GLib] WebCore::MainThreadSharedTimer should use the appropriate GSource priority, name
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 335df3376f0455f40b0684592edbe66c446a008d..2bf4d8e9d9093935cf07abd7abfc532f3dc27bac 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,19 @@
>+2019-05-06  Keith Rollin  <krollin@apple.com>
>+
>+        Temporarily disable generate-xcfilelists
>+        https://bugs.webkit.org/show_bug.cgi?id=197619
>+        <rdar://problem/50507392>
>+
>+        Reviewed by Alex Christensen.
>+
>+        We need to perform a significant update to the generate-xcfilelist
>+        scripts. This work involves coordinated work with another facility. If
>+        the work does not occur in tandem, the build will be broken. To avoid
>+        this, disable the invoking of the scripts during the transition. The
>+        checking will be restored once the new scripts are in place.
>+
>+        * Scripts/check-xcfilelists.sh:
>+
> 2019-05-06  Ryan Haddad  <ryanhaddad@apple.com>
> 
>         Unreviewed, rolling out r244917.
>diff --git a/Source/JavaScriptCore/Scripts/check-xcfilelists.sh b/Source/JavaScriptCore/Scripts/check-xcfilelists.sh
>index efb4ab1763d7c424ba27052c01b6eba8d8c1fb71..dd8805300f7385fad86d71e47393dd8b54063523 100755
>--- a/Source/JavaScriptCore/Scripts/check-xcfilelists.sh
>+++ b/Source/JavaScriptCore/Scripts/check-xcfilelists.sh
>@@ -1,5 +1,8 @@
> #!/bin/sh
> 
>+# FIXME: Remove this once https://bugs.webkit.org/show_bug.cgi?id=197622 is resolved
>+exit 0
>+
> [ "${WK_DISABLE_CHECK_XCFILELISTS}" == "1" ] && { echo "### Not running because WK_DISABLE_CHECK_XCFILELISTS is set"; exit 0; }
> [ "${DEPLOYMENT_LOCATION}" == "YES" ] && { echo "### Not running because DEPLOYMENT_LOCATION is YES"; exit 0; }
> [ "${USE_INTERNAL_SDK}" == "YES" ] || { echo "### Not running because USE_INTERNAL_SDK is not YES"; exit 0; }
>diff --git a/Source/WebCore/Scripts/check-xcfilelists.sh b/Source/WebCore/Scripts/check-xcfilelists.sh
>index 585b950cdcf80a1ef12ae51748e300d34ba4b429..9aa9206b24031a5ef32ac6fddb0c3012fd91a31a 100755
>--- a/Source/WebCore/Scripts/check-xcfilelists.sh
>+++ b/Source/WebCore/Scripts/check-xcfilelists.sh
>@@ -1,5 +1,8 @@
> #!/bin/sh
> 
>+# FIXME: Remove this once https://bugs.webkit.org/show_bug.cgi?id=197622 is resolved
>+exit 0
>+
> [ "${WK_DISABLE_CHECK_XCFILELISTS}" == "1" ] && { echo "### Not running because WK_DISABLE_CHECK_XCFILELISTS is set"; exit 0; }
> [ "${DEPLOYMENT_LOCATION}" == "YES" ] && { echo "### Not running because DEPLOYMENT_LOCATION is YES"; exit 0; }
> [ "${USE_INTERNAL_SDK}" == "YES" ] || { echo "### Not running because USE_INTERNAL_SDK is not YES"; exit 0; }
>diff --git a/Source/WebKit/Scripts/check-xcfilelists.sh b/Source/WebKit/Scripts/check-xcfilelists.sh
>index 1150a4f60b2652d8bf28782d6b099209c2e10f08..46fb06178fcb44c0e56b1ad644528969ca0aca44 100755
>--- a/Source/WebKit/Scripts/check-xcfilelists.sh
>+++ b/Source/WebKit/Scripts/check-xcfilelists.sh
>@@ -1,5 +1,8 @@
> #!/bin/sh
> 
>+# FIXME: Remove this once https://bugs.webkit.org/show_bug.cgi?id=197622 is resolved
>+exit 0
>+
> [ "${WK_DISABLE_CHECK_XCFILELISTS}" == "1" ] && { echo "### Not running because WK_DISABLE_CHECK_XCFILELISTS is set"; exit 0; }
> [ "${DEPLOYMENT_LOCATION}" == "YES" ] && { echo "### Not running because DEPLOYMENT_LOCATION is YES"; exit 0; }
> [ "${USE_INTERNAL_SDK}" == "YES" ] || { echo "### Not running because USE_INTERNAL_SDK is not YES"; exit 0; }
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 806e0b1b8cae70cb16c736727c8602b758e4da26..ef56ed36d9f96a02540ca79040f97a3825ef1a0e 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,20 @@
>+2019-05-06  Keith Rollin  <krollin@apple.com>
>+
>+        Temporarily disable generate-xcfilelists
>+        https://bugs.webkit.org/show_bug.cgi?id=197619
>+        <rdar://problem/50507392>
>+
>+        Reviewed by Alex Christensen.
>+
>+        We need to perform a significant update to the generate-xcfilelist
>+        scripts. This work involves coordinated work with another facility. If
>+        the work does not occur in tandem, the build will be broken. To avoid
>+        this, disable the invoking of the scripts during the transition. The
>+        checking will be restored once the new scripts are in place.
>+
>+        * DumpRenderTree/Scripts/check-xcfilelists.sh:
>+        * WebKitTestRunner/Scripts/check-xcfilelists.sh:
>+
> 2019-05-04  Alex Christensen  <achristensen@webkit.org>
> 
>         Revert r244953 and r244954 because they broke internal builds.
>diff --git a/Tools/DumpRenderTree/Scripts/check-xcfilelists.sh b/Tools/DumpRenderTree/Scripts/check-xcfilelists.sh
>index b18acb3226edec7a7d9875856583987ce256be86..538a19920f5c375c16adde14784b26ce71c48ca1 100755
>--- a/Tools/DumpRenderTree/Scripts/check-xcfilelists.sh
>+++ b/Tools/DumpRenderTree/Scripts/check-xcfilelists.sh
>@@ -1,5 +1,8 @@
> #!/bin/sh
> 
>+# FIXME: Remove this once https://bugs.webkit.org/show_bug.cgi?id=197622 is resolved
>+exit 0
>+
> [ "${WK_DISABLE_CHECK_XCFILELISTS}" == "1" ] && { echo "### Not running because WK_DISABLE_CHECK_XCFILELISTS is set"; exit 0; }
> [ "${DEPLOYMENT_LOCATION}" == "YES" ] && { echo "### Not running because DEPLOYMENT_LOCATION is YES"; exit 0; }
> [ "${USE_INTERNAL_SDK}" == "YES" ] || { echo "### Not running because USE_INTERNAL_SDK is not YES"; exit 0; }
>diff --git a/Tools/WebKitTestRunner/Scripts/check-xcfilelists.sh b/Tools/WebKitTestRunner/Scripts/check-xcfilelists.sh
>index 7e89950bc3bd6450206cfe810bac34ce4d2dcae9..9cf827c8ae1c35d1345e78bbcf85da63d264e96c 100755
>--- a/Tools/WebKitTestRunner/Scripts/check-xcfilelists.sh
>+++ b/Tools/WebKitTestRunner/Scripts/check-xcfilelists.sh
>@@ -1,5 +1,8 @@
> #!/bin/sh
> 
>+# FIXME: Remove this once https://bugs.webkit.org/show_bug.cgi?id=197622 is resolved
>+exit 0
>+
> [ "${WK_DISABLE_CHECK_XCFILELISTS}" == "1" ] && { echo "### Not running because WK_DISABLE_CHECK_XCFILELISTS is set"; exit 0; }
> [ "${DEPLOYMENT_LOCATION}" == "YES" ] && { echo "### Not running because DEPLOYMENT_LOCATION is YES"; exit 0; }
> [ "${USE_INTERNAL_SDK}" == "YES" ] || { echo "### Not running because USE_INTERNAL_SDK is not YES"; exit 0; }

Actions: View | Formatted Diff | Diff

Attachments on bug 197619: 369154 | 369168 | 369181