Attachment 369149 Details for Bug 197600 – WIP 2

[patch] WIP 2

bug-197600-20190507043840.patch (text/plain), 2.80 KB, created by Dean Jackson on 2019-05-06 11:38:41 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Dean Jackson

Created: 2019-05-06 11:38:41 PDT

Size: 2.80 KB

patch

obsolete

>Subversion Revision: 244950
>diff --git a/Source/JavaScriptCore/ChangeLog b/Source/JavaScriptCore/ChangeLog
>index 7d960395584de6aa830c033c9f0c21d4162c62f6..ecadb9aa9ccd0c8d0ece8d9b795ca18a53f9bc60 100644
>--- a/Source/JavaScriptCore/ChangeLog
>+++ b/Source/JavaScriptCore/ChangeLog
>@@ -1,3 +1,21 @@
>+2019-05-05  Dean Jackson  <dino@apple.com>
>+
>+        Implement Promise.allSettled
>+        https://bugs.webkit.org/show_bug.cgi?id=197600
>+        <rdar://problem/50483885>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Implement Promise.allSettled
>+        https://github.com/tc39/proposal-promise-allSettled/
>+
>+        Shipping in Firefox since version 68.
>+        Shipping in V8 since https://chromium.googlesource.com/v8/v8.git/+/1f6d27e8df819b448712dface6ad367fb8de426b
>+
>+        * builtins/PromiseConstructor.js:
>+        (allSettled): Added.
>+        * runtime/JSPromiseConstructor.cpp: Add ref to allSettled.
>+
> 2019-05-04  Tadeu Zagallo  <tzagallo@apple.com>
> 
>         TypedArrays should not store properties that are canonical numeric indices
>diff --git a/Source/JavaScriptCore/builtins/PromiseConstructor.js b/Source/JavaScriptCore/builtins/PromiseConstructor.js
>index b13d146b7796cbd1ca476c124001ea536bce9588..604dbd60e6652e3cc5216ae5a7d0a08f8ac15a71 100644
>--- a/Source/JavaScriptCore/builtins/PromiseConstructor.js
>+++ b/Source/JavaScriptCore/builtins/PromiseConstructor.js
>@@ -75,6 +75,28 @@ function all(iterable)
>     return promiseCapability.@promise;
> }
> 
>+function allSettled(iterable)
>+{
>+    "use strict";
>+
>+    if (!@isObject(this))
>+        @throwTypeError("|this| is not a object");
>+
>+    var outerThis = this;
>+
>+    return @Promise.all.@call(this, @Array.from(iterable, function (item) {
>+        var promiseCapability = @newPromiseCapability(outerThis);
>+        promiseCapability.@resolve.@call(@undefined, item);
>+        var itemPromise = promiseCapability.@promise;
>+
>+        return itemPromise.then(function (value) {
>+            return { status: 'fulfilled', value };
>+        }, function (reason) {
>+            return { status: 'rejected', reason };
>+        });
>+    }));
>+}
>+
> function race(iterable)
> {
>     "use strict";
>diff --git a/Source/JavaScriptCore/runtime/JSPromiseConstructor.cpp b/Source/JavaScriptCore/runtime/JSPromiseConstructor.cpp
>index 74177c4b6a2556df21172317d1a5a5c4ba9282dc..053fed21cac809037d341905fc318fe11940913f 100644
>--- a/Source/JavaScriptCore/runtime/JSPromiseConstructor.cpp
>+++ b/Source/JavaScriptCore/runtime/JSPromiseConstructor.cpp
>@@ -57,6 +57,7 @@ const ClassInfo JSPromiseConstructor::s_info = { "Function", &Base::s_info, &pro
>   reject          JSBuiltin             DontEnum|Function 1
>   race            JSBuiltin             DontEnum|Function 1
>   all             JSBuiltin             DontEnum|Function 1
>+  allSettled      JSBuiltin             DontEnum|Function 1
> @end
> */
>

Actions: View | Formatted Diff | Diff

Attachments on bug 197600: 369095 | 369096 | 369149 | 369161 | 370789