Attachment 369075 Details for Bug 197593 – Patch

[patch] Patch

bug-197593-20190504165617.patch (text/plain), 2.25 KB, created by Wenson Hsieh on 2019-05-04 16:56:18 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Wenson Hsieh

Created: 2019-05-04 16:56:18 PDT

Size: 2.25 KB

patch

obsolete

>Subversion Revision: 244946
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 6a7508864b474651815305cbfb47acfe8ef2a15a..95ed8d4bfc0821d3e712c98272fe24daea8acf3a 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,20 @@
>+2019-05-04  Wenson Hsieh  <wenson_hsieh@apple.com>
>+
>+        fast/attachment/attachment-folder-icon.html is an Image Only failure on recent macOS builds
>+        https://bugs.webkit.org/show_bug.cgi?id=197593
>+        <rdar://problem/50379267>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        On recent versions of macOS, -[NSWorkspace iconForFileType:] returns the generic document icon for
>+        "public.directory". Instead of using this UTI to generate attachment icons for "multipart/x-folder" and
>+        "application/vnd.apple.folder", we should instead be using "public.folder", which has a folder icon. This fixes
>+        the existing test fast/attachment/attachment-folder-icon.html, which currently results in an image diff on these
>+        builds of macOS.
>+
>+        * rendering/RenderThemeMac.mm:
>+        (WebCore::iconForAttachment):
>+
> 2019-05-03  Zalan Bujtas  <zalan@apple.com>
> 
>         [iOS] outlook.live.com: Compose email frame not fully visible and not scrollable
>diff --git a/Source/WebCore/rendering/RenderThemeMac.mm b/Source/WebCore/rendering/RenderThemeMac.mm
>index 552f0bdeeb3be7e5215e6873ea1174087f4986d4..6a930ac9e19929f19166e0d7a4166c1c25eae137 100644
>--- a/Source/WebCore/rendering/RenderThemeMac.mm
>+++ b/Source/WebCore/rendering/RenderThemeMac.mm
>@@ -71,6 +71,7 @@
> #import "UserAgentStyleSheets.h"
> #import <Carbon/Carbon.h>
> #import <Cocoa/Cocoa.h>
>+#import <CoreServices/CoreServices.h>
> #import <math.h>
> #import <pal/spi/cg/CoreGraphicsSPI.h>
> #import <pal/spi/cocoa/NSColorSPI.h>
>@@ -2745,7 +2746,7 @@ static RefPtr<Icon> iconForAttachment(const RenderAttachment& attachment)
>     
>     if (!attachmentType.isEmpty()) {
>         if (equalIgnoringASCIICase(attachmentType, "multipart/x-folder") || equalIgnoringASCIICase(attachmentType, "application/vnd.apple.folder")) {
>-            if (auto icon = Icon::createIconForUTI("public.directory"))
>+            if (auto icon = Icon::createIconForUTI(kUTTypeFolder))
>                 return icon;
>         } else {
>             String UTI;

Actions: View | Formatted Diff | Diff

Attachments on bug 197593: 369075 | 369084