Attachment 369051 Details for Bug 197591 – Patch

[patch] Patch

bug-197591-20190503221556.patch (text/plain), 2.10 KB, created by Devin Rousso on 2019-05-03 22:15:57 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Devin Rousso

Created: 2019-05-03 22:15:57 PDT

Size: 2.10 KB

patch

obsolete

>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
>index 97206c896b10ddf3ad958b68b3f8bce3e8085713..3ee19a9b9a7e9fac67bd955d706452fb73aaf909 100644
>--- a/Source/WebInspectorUI/ChangeLog
>+++ b/Source/WebInspectorUI/ChangeLog
>@@ -1,3 +1,13 @@
>+2019-05-03  Devin Rousso  <drousso@apple.com>
>+
>+        Web Inspector: REGRESSION: unable to expand/collapse non-selectable WI.TreeOutline
>+        https://bugs.webkit.org/show_bug.cgi?id=197591
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * UserInterface/Views/TreeElement.js:
>+        (WI.TreeElement.treeElementToggled):
>+
> 2019-05-03  Devin Rousso  <drousso@apple.com>
> 
>         Web Inspector: DOM: rename "low power" to "display composited"
>diff --git a/Source/WebInspectorUI/UserInterface/Views/TreeElement.js b/Source/WebInspectorUI/UserInterface/Views/TreeElement.js
>index adf5904b621e5912be95d3c5f7dd2a114f71ffc5..63c27b8f1608094a36477ee4fa042f75669e1661 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/TreeElement.js
>+++ b/Source/WebInspectorUI/UserInterface/Views/TreeElement.js
>@@ -300,14 +300,12 @@ WI.TreeElement = class TreeElement extends WI.Object
>     static treeElementToggled(event)
>     {
>         let element = event.currentTarget;
>-        if (!element || !element.treeElement)
>+        if (!element)
>             return;
> 
>         let treeElement = element.treeElement;
>-        if (!treeElement.treeOutline.selectable) {
>-            treeElement.treeOutline.dispatchEventToListeners(WI.TreeOutline.Event.ElementClicked, {treeElement});
>+        if (!treeElement)
>             return;
>-        }
> 
>         let toggleOnClick = treeElement.toggleOnClick && !treeElement.selectable;
>         let isInTriangle = treeElement.isEventWithinDisclosureTriangle(event);
>@@ -326,6 +324,9 @@ WI.TreeElement = class TreeElement extends WI.Object
>                 treeElement.expand();
>         }
>         event.stopPropagation();
>+
>+        if (!treeElement.treeOutline.selectable)
>+            treeElement.treeOutline.dispatchEventToListeners(WI.TreeOutline.Event.ElementClicked, {treeElement});
>     }
> 
>     static treeElementDoubleClicked(event)

Actions: View | Formatted Diff | Diff

Attachments on bug 197591: 369051 | 369060