Attachment 369029 Details for Bug 197563 – Patch for landing

[patch] Patch for landing

bug-197563-20190503172417.patch (text/plain), 3.35 KB, created by Jonathan Bedard on 2019-05-03 17:24:17 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Bedard

Created: 2019-05-03 17:24:17 PDT

Size: 3.35 KB

patch

obsolete

>Index: Tools/ChangeLog
>===================================================================
>--- Tools/ChangeLog	(revision 244909)
>+++ Tools/ChangeLog	(working copy)
>@@ -1,3 +1,15 @@
>+2019-05-03  Jonathan Bedard  <jbedard@apple.com>
>+
>+        run-apit-tests: Add --iterations and --repeat-each
>+        https://bugs.webkit.org/show_bug.cgi?id=197563
>+
>+        Reviewed by Aakash Jain.
>+
>+        * Scripts/webkitpy/api_tests/manager.py:
>+        (Manager.run): Add --iterations and --repeat-each/
>+        * Scripts/webkitpy/api_tests/run_api_tests.py:
>+        (parse_args): Duplicate the test list based on --iterations and --repeat-each.
>+
> 2019-05-03  Commit Queue  <commit-queue@webkit.org>
> 
>         Unreviewed, rolling out r244881.
>Index: Tools/Scripts/webkitpy/api_tests/manager.py
>===================================================================
>--- Tools/Scripts/webkitpy/api_tests/manager.py	(revision 244871)
>+++ Tools/Scripts/webkitpy/api_tests/manager.py	(working copy)
>@@ -182,10 +182,16 @@ class Manager(object):
>                 self._stream.writeln(test)
>             return Manager.SUCCESS
> 
>+        test_names = [test for test in test_names for _ in xrange(self._options.repeat_each)]
>+        if self._options.repeat_each != 1:
>+            _log.debug('Repeating each test {} times'.format(self._options.iterations))
>+
>         try:
>             _log.info('Running tests')
>             runner = Runner(self._port, self._stream)
>-            runner.run(test_names, int(self._options.child_processes) if self._options.child_processes else self._port.default_child_processes())
>+            for i in xrange(self._options.iterations):
>+                _log.debug('\nIteration {}'.format(i + 1))
>+                runner.run(test_names, int(self._options.child_processes) if self._options.child_processes else self._port.default_child_processes())
>         except KeyboardInterrupt:
>             # If we receive a KeyboardInterrupt, print results.
>             self._stream.writeln('')
>@@ -205,7 +211,7 @@ class Manager(object):
> 
>         self._stream.writeln('-' * 30)
>         result = Manager.SUCCESS
>-        if len(successful) + disabled == len(test_names):
>+        if len(successful) * self._options.repeat_each + disabled == len(test_names):
>             self._stream.writeln('All tests successfully passed!')
>             if json_output:
>                 self.host.filesystem.write_text_file(json_output, json.dumps(result_dictionary, indent=4))
>Index: Tools/Scripts/webkitpy/api_tests/run_api_tests.py
>===================================================================
>--- Tools/Scripts/webkitpy/api_tests/run_api_tests.py	(revision 244871)
>+++ Tools/Scripts/webkitpy/api_tests/run_api_tests.py	(working copy)
>@@ -123,6 +123,8 @@ def parse_args(args):
>                              help='Number of seconds to wait before a test times out'),
>         optparse.make_option('--no-timeout', dest='timeout', action='store_false',
>                              help='Disable timeouts for all tests'),
>+        optparse.make_option('--iterations', type='int', default=1, help='Number of times to run the set of tests (e.g. ABCABCABC)'),
>+        optparse.make_option('--repeat-each', type='int', default=1, help='Number of times to run each test (e.g. AAABBBCCC)'),
> 
>         # FIXME: Remove the default, API tests should be multiprocess
>         optparse.make_option('--child-processes', default=1,

Actions: View | Formatted Diff | Diff

Attachments on bug 197563: 368940 | 368972 | 369029