Attachment 369018 Details for Bug 197520 – Patch

[patch] Patch

bug-197520-20190503163243.patch (text/plain), 1.25 KB, created by Aakash Jain on 2019-05-03 16:32:44 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Aakash Jain

Created: 2019-05-03 16:32:44 PDT

Size: 1.25 KB

patch

obsolete

>Index: Tools/ChangeLog
>===================================================================
>--- Tools/ChangeLog	(revision 244936)
>+++ Tools/ChangeLog	(working copy)
>@@ -1,3 +1,12 @@
>+2019-05-03  Aakash Jain  <aakash_jain@apple.com>
>+
>+        New EWS: Clicking on white bubble navigates to page with only bubbles
>+        https://bugs.webkit.org/show_bug.cgi?id=197520
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html: Disable clicking if bubble doesn't have any url.
>+
> 2019-05-03  Daniel Bates  <dabates@apple.com>
> 
>         [lldb-webkit] Support adding pretty-printing for qualified types
>Index: Tools/BuildSlaveSupport/ews-app/ews/templates/statusbubble.html
>===================================================================
>--- Tools/BuildSlaveSupport/ews-app/ews/templates/statusbubble.html	(revision 244936)
>+++ Tools/BuildSlaveSupport/ews-app/ews/templates/statusbubble.html	(working copy)
>@@ -77,7 +77,9 @@ window.addEventListener("message", funct
>   {% else %}
>   {% for bubble in bubbles %}
>   <a class="status {{ bubble.state }}" target="_top"
>+  {% if bubble.url %}
>       href="{{ bubble.url }}"
>+  {% endif %}
>   {% if bubble.details_message %}
>       title="{{ bubble.details_message }}"
>   {% endif %}

Actions: View | Formatted Diff | Diff

Attachments on bug 197520: 369018