Attachment 368932 Details for Bug 197560 – Patch

[patch] Patch

bug-197560-20190503085753.patch (text/plain), 1.74 KB, created by youenn fablet on 2019-05-03 08:57:53 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: youenn fablet

Created: 2019-05-03 08:57:53 PDT

Size: 1.74 KB

patch

obsolete

>Subversion Revision: 244802
>diff --git a/Source/ThirdParty/libwebrtc/ChangeLog b/Source/ThirdParty/libwebrtc/ChangeLog
>index d1d0b3e5af2ed2c8f379d11888c50db3c07ce7f7..5f6eb290cfda001153df8b017cc43dbc4b56ba0d 100644
>--- a/Source/ThirdParty/libwebrtc/ChangeLog
>+++ b/Source/ThirdParty/libwebrtc/ChangeLog
>@@ -1,3 +1,12 @@
>+2019-05-03  Youenn Fablet  <youenn@apple.com>
>+
>+        Do not require log_to_stderr for WebRTC logging through WebKit
>+        https://bugs.webkit.org/show_bug.cgi?id=197560
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * Source/webrtc/rtc_base/logging.cc:
>+
> 2019-04-29  Alex Christensen  <achristensen@webkit.org>
> 
>         <rdar://problem/50299396> Fix internal High Sierra build
>diff --git a/Source/ThirdParty/libwebrtc/Source/webrtc/rtc_base/logging.cc b/Source/ThirdParty/libwebrtc/Source/webrtc/rtc_base/logging.cc
>index 09d203bd2f7b50b200b3bc5d8ffbfd6a11f766d8..7898f6fd8d700c13af997fbfd01350776ff43e5f 100644
>--- a/Source/ThirdParty/libwebrtc/Source/webrtc/rtc_base/logging.cc
>+++ b/Source/ThirdParty/libwebrtc/Source/webrtc/rtc_base/logging.cc
>@@ -54,7 +54,6 @@ static LoggingSeverity g_dbg_sev = LS_NONE;
> #endif
> static LogMessage::LogOutputCallback g_log_output_callback = nullptr;
> 
>-
> // Return the filename portion of the string (that following the last slash).
> const char* FilenameFromPath(const char* file) {
>   const char* end1 = ::strrchr(file, '/');
>@@ -465,9 +464,10 @@ void LogMessage::OutputToDebug(const std::string& str,
>     }
>   }
> #endif  // WEBRTC_ANDROID
>+  if (g_log_output_callback) {
>+    g_log_output_callback(severity, str.c_str());
>+  }
>   if (log_to_stderr) {
>-    if (g_log_output_callback)
>-      g_log_output_callback(severity, str.c_str());
>     fprintf(stderr, "%s", str.c_str());
>     fflush(stderr);
>   }

Actions: View | Formatted Diff | Diff

Attachments on bug 197560: 368932