Attachment 368922 Details for Bug 197559 – ROLLOUT of r244881

[patch] ROLLOUT of r244881

bug-197559-20190503072756.patch (text/plain), 18.01 KB, created by WebKit Commit Bot on 2019-05-03 07:27:57 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: WebKit Commit Bot

Created: 2019-05-03 07:27:57 PDT

Size: 18.01 KB

patch

obsolete

>Subversion Revision: 244906
>diff --git a/Source/JavaScriptCore/ChangeLog b/Source/JavaScriptCore/ChangeLog
>index 7b7f0f62241d65cd655727cb2138b399cdf0a7c8..c05005e6603b8f6563045eda392a959d85d413b3 100644
>--- a/Source/JavaScriptCore/ChangeLog
>+++ b/Source/JavaScriptCore/ChangeLog
>@@ -1,3 +1,19 @@
>+2019-05-03  Commit Queue  <commit-queue@webkit.org>
>+
>+        Unreviewed, rolling out r244881.
>+        https://bugs.webkit.org/show_bug.cgi?id=197559
>+
>+        Breaks compilation of jsconly on linux, breaking compilation
>+        for jsc-i386-ews, jsc-mips-ews and jsc-armv7-ews (Requested by
>+        guijemont on #webkit).
>+
>+        Reverted changeset:
>+
>+        "[CMake] Refactor WEBKIT_MAKE_FORWARDING_HEADERS into
>+        WEBKIT_COPY_FILES"
>+        https://bugs.webkit.org/show_bug.cgi?id=197174
>+        https://trac.webkit.org/changeset/244881
>+
> 2019-05-02  Don Olmstead  <don.olmstead@sony.com>
> 
>         [CMake] Refactor WEBKIT_MAKE_FORWARDING_HEADERS into WEBKIT_COPY_FILES
>diff --git a/Source/WTF/ChangeLog b/Source/WTF/ChangeLog
>index cb3ea89796a83d340320ae572b5ced7e69c8a843..963b1e92187721f8fa43be57e27a663bc9b4e4f1 100644
>--- a/Source/WTF/ChangeLog
>+++ b/Source/WTF/ChangeLog
>@@ -1,3 +1,19 @@
>+2019-05-03  Commit Queue  <commit-queue@webkit.org>
>+
>+        Unreviewed, rolling out r244881.
>+        https://bugs.webkit.org/show_bug.cgi?id=197559
>+
>+        Breaks compilation of jsconly on linux, breaking compilation
>+        for jsc-i386-ews, jsc-mips-ews and jsc-armv7-ews (Requested by
>+        guijemont on #webkit).
>+
>+        Reverted changeset:
>+
>+        "[CMake] Refactor WEBKIT_MAKE_FORWARDING_HEADERS into
>+        WEBKIT_COPY_FILES"
>+        https://bugs.webkit.org/show_bug.cgi?id=197174
>+        https://trac.webkit.org/changeset/244881
>+
> 2019-05-02  Alex Christensen  <achristensen@webkit.org>
> 
>         Mark U+01C0 as a homograph of U+006C
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index bc3c831e405c043a6a59e1dc44ae6d64c7670fcc..586dc3eb7fdb555a46f3c3c4692e0d92409d9c90 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,19 @@
>+2019-05-03  Commit Queue  <commit-queue@webkit.org>
>+
>+        Unreviewed, rolling out r244881.
>+        https://bugs.webkit.org/show_bug.cgi?id=197559
>+
>+        Breaks compilation of jsconly on linux, breaking compilation
>+        for jsc-i386-ews, jsc-mips-ews and jsc-armv7-ews (Requested by
>+        guijemont on #webkit).
>+
>+        Reverted changeset:
>+
>+        "[CMake] Refactor WEBKIT_MAKE_FORWARDING_HEADERS into
>+        WEBKIT_COPY_FILES"
>+        https://bugs.webkit.org/show_bug.cgi?id=197174
>+        https://trac.webkit.org/changeset/244881
>+
> 2019-05-03  Joonghun Park  <jh718.park@samsung.com>
> 
>         Resolve the percentage values of inset properties against proper box.
>diff --git a/Source/WebCore/PAL/ChangeLog b/Source/WebCore/PAL/ChangeLog
>index 9549e186a8adeedb67e5eb46139ddd7a89490e41..93052c354e0cdc9aa6dd1589e82a234587cf4055 100644
>--- a/Source/WebCore/PAL/ChangeLog
>+++ b/Source/WebCore/PAL/ChangeLog
>@@ -1,3 +1,19 @@
>+2019-05-03  Commit Queue  <commit-queue@webkit.org>
>+
>+        Unreviewed, rolling out r244881.
>+        https://bugs.webkit.org/show_bug.cgi?id=197559
>+
>+        Breaks compilation of jsconly on linux, breaking compilation
>+        for jsc-i386-ews, jsc-mips-ews and jsc-armv7-ews (Requested by
>+        guijemont on #webkit).
>+
>+        Reverted changeset:
>+
>+        "[CMake] Refactor WEBKIT_MAKE_FORWARDING_HEADERS into
>+        WEBKIT_COPY_FILES"
>+        https://bugs.webkit.org/show_bug.cgi?id=197174
>+        https://trac.webkit.org/changeset/244881
>+
> 2019-05-02  Don Olmstead  <don.olmstead@sony.com>
> 
>         [CMake] Refactor WEBKIT_MAKE_FORWARDING_HEADERS into WEBKIT_COPY_FILES
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index ad5a964dab4c1980e669bcd77f1286b46c753b4d..16fe326e829d1bf837c3000493fae3e1679db470 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,19 @@
>+2019-05-03  Commit Queue  <commit-queue@webkit.org>
>+
>+        Unreviewed, rolling out r244881.
>+        https://bugs.webkit.org/show_bug.cgi?id=197559
>+
>+        Breaks compilation of jsconly on linux, breaking compilation
>+        for jsc-i386-ews, jsc-mips-ews and jsc-armv7-ews (Requested by
>+        guijemont on #webkit).
>+
>+        Reverted changeset:
>+
>+        "[CMake] Refactor WEBKIT_MAKE_FORWARDING_HEADERS into
>+        WEBKIT_COPY_FILES"
>+        https://bugs.webkit.org/show_bug.cgi?id=197174
>+        https://trac.webkit.org/changeset/244881
>+
> 2019-05-02  Wenson Hsieh  <wenson_hsieh@apple.com>
> 
>         REGRESSION: Layout test editing/selection/ios/selection-after-changing-text-with-callout-menu.html is failing
>diff --git a/Source/WebKitLegacy/ChangeLog b/Source/WebKitLegacy/ChangeLog
>index 5cc4231889b2229d327f5c0e69d06b6cc0ea139f..69790e8e45fad0fcd8970f84368648069eeadd34 100644
>--- a/Source/WebKitLegacy/ChangeLog
>+++ b/Source/WebKitLegacy/ChangeLog
>@@ -1,3 +1,19 @@
>+2019-05-03  Commit Queue  <commit-queue@webkit.org>
>+
>+        Unreviewed, rolling out r244881.
>+        https://bugs.webkit.org/show_bug.cgi?id=197559
>+
>+        Breaks compilation of jsconly on linux, breaking compilation
>+        for jsc-i386-ews, jsc-mips-ews and jsc-armv7-ews (Requested by
>+        guijemont on #webkit).
>+
>+        Reverted changeset:
>+
>+        "[CMake] Refactor WEBKIT_MAKE_FORWARDING_HEADERS into
>+        WEBKIT_COPY_FILES"
>+        https://bugs.webkit.org/show_bug.cgi?id=197174
>+        https://trac.webkit.org/changeset/244881
>+
> 2019-05-02  Don Olmstead  <don.olmstead@sony.com>
> 
>         [CMake] Refactor WEBKIT_MAKE_FORWARDING_HEADERS into WEBKIT_COPY_FILES
>diff --git a/Source/JavaScriptCore/CMakeLists.txt b/Source/JavaScriptCore/CMakeLists.txt
>index 86a73f8ac0013fc457089a0db11c6d6ab7e505b2..a12c0748d605f75cb2252aba91b8a10f8db19570 100644
>--- a/Source/JavaScriptCore/CMakeLists.txt
>+++ b/Source/JavaScriptCore/CMakeLists.txt
>@@ -296,9 +296,9 @@ add_executable(LLIntOffsetsExtractor
> )
> 
> target_link_libraries(LLIntSettingsExtractor WTF)
>-add_dependencies(LLIntSettingsExtractor JavaScriptCoreFrameworkHeaders WTFFrameworkHeaders)
>+add_dependencies(LLIntSettingsExtractor JavaScriptCoreFrameworkHeaders)
> target_link_libraries(LLIntOffsetsExtractor WTF)
>-add_dependencies(LLIntOffsetsExtractor JavaScriptCoreFrameworkHeaders WTFFrameworkHeaders)
>+add_dependencies(LLIntOffsetsExtractor JavaScriptCoreFrameworkHeaders)
> 
> # The build system will execute asm.rb every time LLIntOffsetsExtractor's mtime is newer than
> # LLIntAssembly.h's mtime. The problem we have here is: asm.rb has some built-in optimization
>@@ -1274,6 +1274,20 @@ if (COMPILER_IS_GCC_OR_CLANG)
>     WEBKIT_ADD_TARGET_CXX_FLAGS(JavaScriptCore -ffp-contract=off)
> endif ()
> 
>+WEBKIT_MAKE_FORWARDING_HEADERS(JavaScriptCore
>+    TARGET_NAME JavaScriptCoreFrameworkHeaders
>+    DESTINATION ${JavaScriptCore_FRAMEWORK_HEADERS_DIR}/JavaScriptCore
>+    FILES ${JavaScriptCore_PUBLIC_FRAMEWORK_HEADERS}
>+    FLATTENED
>+)
>+
>+WEBKIT_MAKE_FORWARDING_HEADERS(JavaScriptCore
>+    TARGET_NAME JavaScriptCorePrivateFrameworkHeaders
>+    DESTINATION ${JavaScriptCore_PRIVATE_FRAMEWORK_HEADERS_DIR}/JavaScriptCore
>+    FILES ${JavaScriptCore_PRIVATE_FRAMEWORK_HEADERS}
>+    FLATTENED
>+)
>+
> target_include_directories(LLIntSettingsExtractor PRIVATE
>     ${JavaScriptCore_INCLUDE_DIRECTORIES}
>     ${JavaScriptCore_PRIVATE_INCLUDE_DIRECTORIES}
>@@ -1292,21 +1306,6 @@ WEBKIT_COMPUTE_SOURCES(JavaScriptCore)
> WEBKIT_WRAP_SOURCELIST(${JavaScriptCore_SOURCES})
> WEBKIT_FRAMEWORK(JavaScriptCore)
> 
>-WEBKIT_COPY_FILES(JavaScriptCoreFrameworkHeaders
>-    DESTINATION ${JavaScriptCore_FRAMEWORK_HEADERS_DIR}/JavaScriptCore
>-    FILES ${JavaScriptCore_PUBLIC_FRAMEWORK_HEADERS}
>-    FLATTENED
>-)
>-
>-WEBKIT_COPY_FILES(JavaScriptCorePrivateFrameworkHeaders
>-    DESTINATION ${JavaScriptCore_PRIVATE_FRAMEWORK_HEADERS_DIR}/JavaScriptCore
>-    FILES ${JavaScriptCore_PRIVATE_FRAMEWORK_HEADERS}
>-    FLATTENED
>-)
>-
>-add_dependencies(JavaScriptCore JavaScriptCoreFrameworkHeaders)
>-add_dependencies(JavaScriptCorePrivateFrameworkHeaders JavaScriptCore)
>-
> if (NOT "${PORT}" STREQUAL "Mac")
>     if (${JavaScriptCore_LIBRARY_TYPE} STREQUAL "SHARED")
>         WEBKIT_POPULATE_LIBRARY_VERSION(JAVASCRIPTCORE)
>diff --git a/Source/WTF/wtf/CMakeLists.txt b/Source/WTF/wtf/CMakeLists.txt
>index b84cc7772b08da31319f54ef47a8bc1b646f678c..5a8bb51b94ac9f5ec35ef844d97eca202fb4f47b 100644
>--- a/Source/WTF/wtf/CMakeLists.txt
>+++ b/Source/WTF/wtf/CMakeLists.txt
>@@ -503,7 +503,8 @@ WEBKIT_INCLUDE_CONFIG_FILES_IF_EXISTS()
> WEBKIT_WRAP_SOURCELIST(${WTF_SOURCES})
> WEBKIT_FRAMEWORK(WTF)
> 
>-WEBKIT_COPY_FILES(WTFFrameworkHeaders
>+WEBKIT_MAKE_FORWARDING_HEADERS(WTF
>+    TARGET_NAME WTFFrameworkHeaders
>     DESTINATION ${WTF_FRAMEWORK_HEADERS_DIR}/wtf
>     FILES ${WTF_PUBLIC_HEADERS}
> )
>diff --git a/Source/WebCore/CMakeLists.txt b/Source/WebCore/CMakeLists.txt
>index 75de74857b61bd8ef595f0641a95c41209828f0c..e06abb5d75b4769f0f27e91cde48c1a50d863751 100644
>--- a/Source/WebCore/CMakeLists.txt
>+++ b/Source/WebCore/CMakeLists.txt
>@@ -1763,6 +1763,13 @@ set(PAINTWORKLETGLOBALSCOPE_CONSTRUCTORS_FILE ${WebCore_DERIVED_SOURCES_DIR}/Pai
> WEBKIT_FRAMEWORK_DECLARE(WebCore)
> WEBKIT_INCLUDE_CONFIG_FILES_IF_EXISTS()
> 
>+WEBKIT_MAKE_FORWARDING_HEADERS(WebCore
>+    TARGET_NAME WebCorePrivateFrameworkHeaders
>+    DESTINATION ${WebCore_PRIVATE_FRAMEWORK_HEADERS_DIR}/WebCore
>+    FILES ${WebCore_PRIVATE_FRAMEWORK_HEADERS}
>+    FLATTENED
>+)
>+
> # Generate CommandLineAPIModuleSource.h
> add_custom_command(
>     OUTPUT ${WebCore_DERIVED_SOURCES_DIR}/CommandLineAPIModuleSource.h ${WebCore_DERIVED_SOURCES_DIR}/CommandLineAPIModuleSource.min.js
>@@ -2072,17 +2079,7 @@ endif ()
> 
> WEBKIT_FRAMEWORK(WebCore)
> 
>-WEBKIT_COPY_FILES(WebCorePrivateFrameworkHeaders
>-    DESTINATION ${WebCore_PRIVATE_FRAMEWORK_HEADERS_DIR}/WebCore
>-    FILES ${WebCore_PRIVATE_FRAMEWORK_HEADERS}
>-    FLATTENED
>-)
>-
>-add_dependencies(WebCore
>-    PALFrameworkHeaders
>-    JavaScriptCorePrivateFrameworkHeaders
>-    WebCoreBindings
>-)
>+add_dependencies(WebCore WebCoreBindings)
> add_dependencies(WebCorePrivateFrameworkHeaders WebCoreBindings)
> 
> if (APPLE)
>diff --git a/Source/WebCore/PAL/pal/CMakeLists.txt b/Source/WebCore/PAL/pal/CMakeLists.txt
>index c7a08043ad7b38473ff99c889d14bbf25c12ecb7..c50c485b3a7cd53b1ec8718265c5a7e9ff514791 100644
>--- a/Source/WebCore/PAL/pal/CMakeLists.txt
>+++ b/Source/WebCore/PAL/pal/CMakeLists.txt
>@@ -51,7 +51,8 @@ WEBKIT_INCLUDE_CONFIG_FILES_IF_EXISTS()
> WEBKIT_WRAP_SOURCELIST(${PAL_SOURCES})
> WEBKIT_FRAMEWORK(PAL)
> 
>-WEBKIT_COPY_FILES(PALFrameworkHeaders
>+WEBKIT_MAKE_FORWARDING_HEADERS(PAL
>+    TARGET_NAME PALFrameworkHeaders
>     DESTINATION ${PAL_FRAMEWORK_HEADERS_DIR}/pal
>     FILES ${PAL_PUBLIC_HEADERS}
> )
>diff --git a/Source/WebKit/CMakeLists.txt b/Source/WebKit/CMakeLists.txt
>index f17532c41fa880e47b0d34eb63a37203c971a9dd..ce4f200b5fccf5a83041b0531a781573fe87488c 100644
>--- a/Source/WebKit/CMakeLists.txt
>+++ b/Source/WebKit/CMakeLists.txt
>@@ -421,7 +421,7 @@ list(APPEND WebKit_SOURCES ${WebKit_DERIVED_SOURCES})
> WEBKIT_COMPUTE_SOURCES(WebKit)
> 
> WEBKIT_FRAMEWORK(WebKit)
>-add_dependencies(WebKit WebCore WebCorePrivateFrameworkHeaders ${WEBKIT_EXTRA_DEPENDENCIES})
>+add_dependencies(WebKit WebCore ${WEBKIT_EXTRA_DEPENDENCIES})
> ADD_WEBKIT_PREFIX_HEADER(WebKit)
> 
> add_executable(WebProcess ${WebProcess_SOURCES})
>diff --git a/Source/WebKit/PlatformWin.cmake b/Source/WebKit/PlatformWin.cmake
>index 9e15929564af878e43942b377dc0541c5bb450b4..4e9e2a601b868d53904703a1126b7ebd1077fa66 100644
>--- a/Source/WebKit/PlatformWin.cmake
>+++ b/Source/WebKit/PlatformWin.cmake
>@@ -370,7 +370,8 @@ if (${WTF_PLATFORM_WIN_CAIRO})
>     )
> endif ()
> 
>-WEBKIT_COPY_FILES(WebKitFrameworkHeaders
>+WEBKIT_MAKE_FORWARDING_HEADERS(WebKit
>+    TARGET_NAME WebKitFrameworkHeaders
>     DESTINATION ${WebKit_FRAMEWORK_HEADERS_DIR}/WebKit
>     FILES ${WebKit_PUBLIC_FRAMEWORK_HEADERS}
>     FLATTENED
>diff --git a/Source/WebKitLegacy/PlatformWin.cmake b/Source/WebKitLegacy/PlatformWin.cmake
>index bb9fd77915ddebefd89f19bf8510b86612358865..3506b154db72944e43ad0fda0df23c3ef19ead1c 100644
>--- a/Source/WebKitLegacy/PlatformWin.cmake
>+++ b/Source/WebKitLegacy/PlatformWin.cmake
>@@ -496,12 +496,13 @@ set(WebKitLegacy_PUBLIC_FRAMEWORK_HEADERS
>     win/WebKitCOMAPI.h
> )
> 
>-WEBKIT_COPY_FILES(WebKitLegacyFrameworkHeaders
>+WEBKIT_MAKE_FORWARDING_HEADERS(WebKitLegacyGUID
>+    TARGET_NAME WebKitLegacyFrameworkHeaders
>     DESTINATION ${WebKitLegacy_FRAMEWORK_HEADERS_DIR}/WebKitLegacy
>     FILES ${WebKitLegacy_PUBLIC_FRAMEWORK_HEADERS}
>     FLATTENED
> )
>-add_dependencies(WebKitLegacyFrameworkHeaders WebKitLegacyGUID)
>+add_dependencies(WebKitLegacyFrameworkHeaders WebCorePrivateFrameworkHeaders)
> 
> set(WebKitLegacy_OUTPUT_NAME
>     WebKit${DEBUG_SUFFIX}
>diff --git a/Source/cmake/WebKitMacros.cmake b/Source/cmake/WebKitMacros.cmake
>index aee62f00d3d0c886da55476b1dd4fd6df1372dc9..4aacbd6ddc513cd48ff2b3db052b9a70ff34ed9f 100644
>--- a/Source/cmake/WebKitMacros.cmake
>+++ b/Source/cmake/WebKitMacros.cmake
>@@ -291,35 +291,46 @@ macro(WEBKIT_CREATE_FORWARDING_HEADERS _framework)
>     endif ()
> endmacro()
> 
>-function(WEBKIT_COPY_FILES target_name)
>+function(WEBKIT_MAKE_FORWARDING_HEADERS framework)
>     set(options FLATTENED)
>-    set(oneValueArgs DESTINATION)
>-    set(multiValueArgs FILES)
>+    set(oneValueArgs DESTINATION TARGET_NAME)
>+    set(multiValueArgs DIRECTORIES FILES)
>     cmake_parse_arguments(opt "${options}" "${oneValueArgs}" "${multiValueArgs}" ${ARGN})
>-    set(files ${opt_FILES})
>-    set(dst_files)
>-    foreach (file IN LISTS files)
>-        if (IS_ABSOLUTE ${file})
>-            set(src_file ${file})
>+    set(headers ${opt_FILES})
>+    file(MAKE_DIRECTORY ${opt_DESTINATION})
>+    foreach (dir IN LISTS opt_DIRECTORIES)
>+        file(GLOB files RELATIVE ${CMAKE_CURRENT_SOURCE_DIR} ${dir}/*.h)
>+        list(APPEND headers ${files})
>+    endforeach ()
>+    set(fwd_headers)
>+    foreach (header IN LISTS headers)
>+        if (IS_ABSOLUTE ${header})
>+            set(src_header ${header})
>         else ()
>-            set(src_file ${CMAKE_CURRENT_SOURCE_DIR}/${file})
>+            set(src_header ${CMAKE_CURRENT_SOURCE_DIR}/${header})
>         endif ()
>         if (opt_FLATTENED)
>-            get_filename_component(filename ${file} NAME)
>-            set(dst_file ${opt_DESTINATION}/${filename})
>+            get_filename_component(header_filename ${header} NAME)
>+            set(fwd_header ${opt_DESTINATION}/${header_filename})
>         else ()
>-            get_filename_component(file_dir ${file} DIRECTORY)
>-            file(MAKE_DIRECTORY ${opt_DESTINATION}/${file_dir})
>-            set(dst_file ${opt_DESTINATION}/${file})
>+            get_filename_component(header_dir ${header} DIRECTORY)
>+            file(MAKE_DIRECTORY ${opt_DESTINATION}/${header_dir})
>+            set(fwd_header ${opt_DESTINATION}/${header})
>         endif ()
>-        add_custom_command(OUTPUT ${dst_file}
>-            COMMAND ${CMAKE_COMMAND} -E copy ${src_file} ${dst_file}
>-            MAIN_DEPENDENCY ${file}
>+        add_custom_command(OUTPUT ${fwd_header}
>+            COMMAND ${CMAKE_COMMAND} -E copy ${src_header} ${fwd_header}
>+            MAIN_DEPENDENCY ${header}
>             VERBATIM
>         )
>-        list(APPEND dst_files ${dst_file})
>+        list(APPEND fwd_headers ${fwd_header})
>     endforeach ()
>-    add_custom_target(${target_name} DEPENDS ${dst_files})
>+    if (opt_TARGET_NAME)
>+        set(target_name ${opt_TARGET_NAME})
>+    else ()
>+        set(target_name ${framework}ForwardingHeaders)
>+    endif ()
>+    add_custom_target(${target_name} DEPENDS ${fwd_headers})
>+    add_dependencies(${framework} ${target_name})
> endfunction()
> 
> # Helper macros for debugging CMake problems.
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index f24b0cf5751d4aa920aa4f9a27077824129929c9..fa00bb9ba3d34620e6dbe62c634db3e4bcb6e74e 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,19 @@
>+2019-05-03  Commit Queue  <commit-queue@webkit.org>
>+
>+        Unreviewed, rolling out r244881.
>+        https://bugs.webkit.org/show_bug.cgi?id=197559
>+
>+        Breaks compilation of jsconly on linux, breaking compilation
>+        for jsc-i386-ews, jsc-mips-ews and jsc-armv7-ews (Requested by
>+        guijemont on #webkit).
>+
>+        Reverted changeset:
>+
>+        "[CMake] Refactor WEBKIT_MAKE_FORWARDING_HEADERS into
>+        WEBKIT_COPY_FILES"
>+        https://bugs.webkit.org/show_bug.cgi?id=197174
>+        https://trac.webkit.org/changeset/244881
>+
> 2019-05-03  Zan Dobersek  <zdobersek@igalia.com>
> 
>         Unreviewed WPE build fix after r244898.
>diff --git a/Tools/TestWebKitAPI/PlatformGTK.cmake b/Tools/TestWebKitAPI/PlatformGTK.cmake
>index a22aea3f5730d1fe81d32a7c25cae7f733a49767..6aca35ba8ee0caabedfb568efe705d3bab7a7915 100644
>--- a/Tools/TestWebKitAPI/PlatformGTK.cmake
>+++ b/Tools/TestWebKitAPI/PlatformGTK.cmake
>@@ -119,10 +119,6 @@ set(TestJSC_LIBRARIES
>     JavaScriptCore
> )
> 
>-set(TestJSC_DEPENDENCIES
>-    JavaScriptCorePrivateFrameworkHeaders
>-)
>-
> set(TestJSC_DEFINITIONS
>     WEBKIT_SRC_DIR="${CMAKE_SOURCE_DIR}"
> )
>diff --git a/Tools/TestWebKitAPI/PlatformWPE.cmake b/Tools/TestWebKitAPI/PlatformWPE.cmake
>index 74c9369aab636993feeb6f2215b2e885e336e323..82749a8fdcc78a75367da9157c59a8e5888523af 100644
>--- a/Tools/TestWebKitAPI/PlatformWPE.cmake
>+++ b/Tools/TestWebKitAPI/PlatformWPE.cmake
>@@ -117,10 +117,6 @@ set(TestJSC_LIBRARIES
>     JavaScriptCore
> )
> 
>-set(TestJSC_DEPENDENCIES
>-    JavaScriptCorePrivateFrameworkHeaders
>-)
>-
> set(TestJSC_DEFINITIONS
>     WEBKIT_SRC_DIR="${CMAKE_SOURCE_DIR}"
> )
>diff --git a/ChangeLog b/ChangeLog
>index 0db00afe82ee11b002b144d14a64a680bdfd7a04..35c56070da0cdbf69fee63ec6a43dbb335315e91 100644
>--- a/ChangeLog
>+++ b/ChangeLog
>@@ -1,3 +1,19 @@
>+2019-05-03  Commit Queue  <commit-queue@webkit.org>
>+
>+        Unreviewed, rolling out r244881.
>+        https://bugs.webkit.org/show_bug.cgi?id=197559
>+
>+        Breaks compilation of jsconly on linux, breaking compilation
>+        for jsc-i386-ews, jsc-mips-ews and jsc-armv7-ews (Requested by
>+        guijemont on #webkit).
>+
>+        Reverted changeset:
>+
>+        "[CMake] Refactor WEBKIT_MAKE_FORWARDING_HEADERS into
>+        WEBKIT_COPY_FILES"
>+        https://bugs.webkit.org/show_bug.cgi?id=197174
>+        https://trac.webkit.org/changeset/244881
>+
> 2019-05-02  Christopher Reid  <chris.reid@sony.com>
> 
>         [CMake] Add support for LTO builds

Actions: View | Formatted Diff | Diff

Attachments on bug 197559: 368922