Attachment 368888 Details for Bug 197549 – Patch

[patch] Patch

bug-197549-20190502210842.patch (text/plain), 3.25 KB, created by youenn fablet on 2019-05-02 21:08:43 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: youenn fablet

Created: 2019-05-02 21:08:43 PDT

Size: 3.25 KB

patch

obsolete

>Subversion Revision: 244802
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 926ff4f7643efac2a9dd261221733a007a0f5cab..eb0e72429419a424a11a07283ce84f4fe8443669 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,15 @@
>+2019-05-02  Youenn Fablet  <youenn@apple.com>
>+
>+        Convert some RealtimeOutgoingVideoSourceCocoa logging to ERROR_LOG
>+        https://bugs.webkit.org/show_bug.cgi?id=197549
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        No change of behavior.
>+
>+        * platform/mediastream/mac/RealtimeOutgoingVideoSourceCocoa.mm:
>+        (WebCore::RealtimeOutgoingVideoSourceCocoa::rotatePixelBuffer):
>+
> 2019-05-02  Youenn Fablet  <youenn@apple.com>
> 
>         Make AudioContext::scriptExecutionContext() private
>diff --git a/Source/WebCore/platform/mediastream/mac/RealtimeOutgoingVideoSourceCocoa.mm b/Source/WebCore/platform/mediastream/mac/RealtimeOutgoingVideoSourceCocoa.mm
>index 5e7e12492b4657c83f9e45d36eddb017ce5241bf..6f6d471a80eb465d11e7b0829fc16f1ee3d756f7 100644
>--- a/Source/WebCore/platform/mediastream/mac/RealtimeOutgoingVideoSourceCocoa.mm
>+++ b/Source/WebCore/platform/mediastream/mac/RealtimeOutgoingVideoSourceCocoa.mm
>@@ -75,7 +75,7 @@ RetainPtr<CVPixelBufferRef> RealtimeOutgoingVideoSourceCocoa::rotatePixelBuffer(
>         VTImageRotationSessionRef rawRotationSession = nullptr;
>         auto status = VTImageRotationSessionCreate(kCFAllocatorDefault, rotation, &rawRotationSession);
>         if (status != noErr) {
>-            ALWAYS_LOG(LOGIDENTIFIER, "Failed creating a rotation session with error ", status);
>+            ERROR_LOG(LOGIDENTIFIER, "Failed creating a rotation session with error ", status);
>             return nullptr;
>         }
> 
>@@ -100,7 +100,7 @@ RetainPtr<CVPixelBufferRef> RealtimeOutgoingVideoSourceCocoa::rotatePixelBuffer(
>         auto status = CVPixelBufferPoolCreate(kCFAllocatorDefault, nullptr, (__bridge CFDictionaryRef)pixelAttributes, &pool);
> 
>         if (status != kCVReturnSuccess) {
>-            ALWAYS_LOG(LOGIDENTIFIER, "Failed creating a pixel buffer pool with error ", status);
>+            ERROR_LOG(LOGIDENTIFIER, "Failed creating a pixel buffer pool with error ", status);
>             return nullptr;
>         }
>         m_rotationPool = adoptCF(pool);
>@@ -114,7 +114,7 @@ RetainPtr<CVPixelBufferRef> RealtimeOutgoingVideoSourceCocoa::rotatePixelBuffer(
>     auto status = CVPixelBufferPoolCreatePixelBuffer(kCFAllocatorDefault, m_rotationPool.get(), &rawRotatedBuffer);
> 
>     if (status != kCVReturnSuccess) {
>-        ALWAYS_LOG(LOGIDENTIFIER, "Failed creating a pixel buffer with error ", status);
>+        ERROR_LOG(LOGIDENTIFIER, "Failed creating a pixel buffer with error ", status);
>         return nullptr;
>     }
>     RetainPtr<CVPixelBufferRef> rotatedBuffer = adoptCF(rawRotatedBuffer);
>@@ -122,7 +122,7 @@ RetainPtr<CVPixelBufferRef> RealtimeOutgoingVideoSourceCocoa::rotatePixelBuffer(
>     status = VTImageRotationSessionTransferImage(m_rotationSession.get(), pixelBuffer, rotatedBuffer.get());
> 
>     if (status != noErr) {
>-        ALWAYS_LOG(LOGIDENTIFIER, "Failed rotating with error ", status);
>+        ERROR_LOG(LOGIDENTIFIER, "Failed rotating with error ", status, " for rotation ", m_currentRotation);
>         return nullptr;
>     }
>     return rotatedBuffer;

Actions: View | Formatted Diff | Diff

Attachments on bug 197549: 368888 | 368914