WebKit Bugzilla
Attachment 368886 Details for
Bug 197548
: Make focusing-element-with-tabindex-by-tap-or-click.html more robust on iOS
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Fixes the test
bug-197548-20190502205524.patch (text/plain), 2.12 KB, created by
Ryosuke Niwa
on 2019-05-02 20:55:25 PDT
(
hide
)
Description:
Fixes the test
Filename:
MIME Type:
Creator:
Ryosuke Niwa
Created:
2019-05-02 20:55:25 PDT
Size:
2.12 KB
patch
obsolete
>Index: LayoutTests/ChangeLog >=================================================================== >--- LayoutTests/ChangeLog (revision 244898) >+++ LayoutTests/ChangeLog (working copy) >@@ -1,3 +1,16 @@ >+2019-05-02 Ryosuke Niwa <rniwa@webkit.org> >+ >+ Make focusing-element-with-tabindex-by-tap-or-click.html more robust on iOS >+ https://bugs.webkit.org/show_bug.cgi?id=197548 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ There was a race between the time the editable element was focused and the keyboard was brought up >+ to when the next non-editable element was focused. Made the test explicitly wait for the keyboard >+ to come up and go down between test cases to make it more robust. >+ >+ * fast/events/focusing-element-with-tabindex-by-tap-or-click.html: >+ > 2019-05-02 Chris Dumez <cdumez@apple.com> > > Add test coverage for <rdar://problem/49731231> >Index: LayoutTests/fast/events/focusing-element-with-tabindex-by-tap-or-click.html >=================================================================== >--- LayoutTests/fast/events/focusing-element-with-tabindex-by-tap-or-click.html (revision 244898) >+++ LayoutTests/fast/events/focusing-element-with-tabindex-by-tap-or-click.html (working copy) >@@ -18,12 +18,14 @@ description('This tests tapping or click > jsTestIsAsync = true; > > async function runTests() { >- await UIHelper.activateAt(contentEditableElement.offsetLeft + 5, contentEditableElement.offsetTop + 5); >+ await UIHelper.activateElementAndWaitForInputSession(contentEditableElement); > shouldBe('"Activated contentEditableElement"; document.activeElement', 'contentEditableElement'); > > await UIHelper.activateAt(elementWithTabIndexAndClickHandler.offsetLeft + 5, elementWithTabIndexAndClickHandler.offsetTop + 5); > shouldBe('"Activated elementWithTabIndexAndClickHandler"; document.activeElement', 'elementWithTabIndexAndClickHandler'); > >+ await UIHelper.waitForKeyboardToHide(); >+ > await UIHelper.activateAt(elementWithTabIndex.offsetLeft + 5, elementWithTabIndex.offsetTop + 5); > shouldBe('"Activated elementWithTabIndex"; document.activeElement', 'elementWithTabIndex'); > }
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Flags:
wenson_hsieh
:
review+
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 197548
: 368886