Attachment 368856 Details for Bug 197538 – Patch

[patch] Patch

patch.txt (text/plain), 4.96 KB, created by Nikita Vasilyev on 2019-05-02 18:02:50 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Nikita Vasilyev

Created: 2019-05-02 18:02:50 PDT

Size: 4.96 KB

patch

obsolete

>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
>index 93835516176..1c1997df014 100644
>--- a/Source/WebInspectorUI/ChangeLog
>+++ b/Source/WebInspectorUI/ChangeLog
>@@ -1,3 +1,22 @@
>+2019-05-02  Nikita Vasilyev  <nvasilyev@apple.com>
>+
>+        Web Inspector: Styles: use the same green color for modified properties as in Changes panel
>+        https://bugs.webkit.org/show_bug.cgi?id=197538
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * UserInterface/Views/ChangesDetailsSidebarPanel.css:
>+        (.changes-panel .css-property-line.added):
>+        (.changes-panel .css-property-line.removed):
>+        (.changes-panel .css-property-line.added::before):
>+        * UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.css:
>+        (.spreadsheet-style-declaration-editor .property.modified):
>+        (.spreadsheet-style-declaration-editor .property.modified:not(.selected)):
>+        (@media (prefers-color-scheme: dark)):
>+        * UserInterface/Views/Variables.css:
>+        (:root):
>+        (@media (prefers-color-scheme: dark)):
>+
> 2019-04-11  Devin Rousso  <drousso@apple.com>
> 
>         Web Inspector: REGRESSION(r244195): Timelines: unable to take heap snapshot
>diff --git a/Source/WebInspectorUI/UserInterface/Views/ChangesDetailsSidebarPanel.css b/Source/WebInspectorUI/UserInterface/Views/ChangesDetailsSidebarPanel.css
>index afb5f3e3582..ebcb3b8fd8a 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/ChangesDetailsSidebarPanel.css
>+++ b/Source/WebInspectorUI/UserInterface/Views/ChangesDetailsSidebarPanel.css
>@@ -84,13 +84,13 @@
> }
> 
> .changes-panel .css-property-line.added {
>-    color: hsl(90, 61%, 25%);
>-    background-color: hsl(70, 90%, 86%);
>+    color: var(--diff-addition-text-color);
>+    background-color: var(--diff-addition-background);
> }
> 
> .changes-panel .css-property-line.removed {
>-    color: hsl(0, 100%, 35%);
>-    background-color: hsl(5, 100%, 94%);
>+    color: var(--diff-deletion-text-color);
>+    background-color: var(--diff-deletion-background);
> }
> 
> .changes-panel .css-property-line.removed::before {
>@@ -106,15 +106,3 @@
>     left: var(--css-declaration-horizontal-padding);
>     pointer-events: none;
> }
>-
>-@media (prefers-color-scheme: dark) {
>-    .changes-panel .css-property-line.added {
>-        color: hsl(70, 64%, 70%);
>-        background-color: hsl(89, 40%, 19%);
>-    }
>-
>-    .changes-panel .css-property-line.removed {
>-        color: hsl(0, 84%, 75%);
>-        background-color: hsl(5, 40%, 28%);
>-    }
>-}
>diff --git a/Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.css b/Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.css
>index 0e3454ccc2e..edbc8ac7872 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.css
>+++ b/Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.css
>@@ -131,11 +131,11 @@
> }
> 
> .spreadsheet-style-declaration-editor .property.modified {
>-    border-right-color: hsl(120, 100%, 40%);
>+    border-right-color: hsl(90, 100%, 40%);
> }
> 
> .spreadsheet-style-declaration-editor .property.modified:not(.selected) {
>-    background-color: hsl(90, 100%, 93%);
>+    background-color: var(--diff-addition-background);
> }
> 
> .spreadsheet-style-declaration-editor .property.selected {
>@@ -216,10 +216,6 @@ body:matches(.window-docked-inactive, .window-inactive) .spreadsheet-style-decla
>         outline-color: var(--background-color-secondary) !important;
>     }
> 
>-    .spreadsheet-style-declaration-editor .property.modified:not(.selected) {
>-        background-color: hsl(106, 13%, 25%);
>-    }
>-
>     .spreadsheet-style-declaration-editor .property.overridden:hover .select-effective-property::after,
>     .spreadsheet-style-declaration-editor .property.overridden:focus-within .select-effective-property::after {
>         /* .select-effective-property has inverted colors. Invert the pseudo-element again to restore the original text color. */
>diff --git a/Source/WebInspectorUI/UserInterface/Views/Variables.css b/Source/WebInspectorUI/UserInterface/Views/Variables.css
>index 0edb5083b7b..b40e5933c12 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/Variables.css
>+++ b/Source/WebInspectorUI/UserInterface/Views/Variables.css
>@@ -178,6 +178,11 @@
> 
>     --css-declaration-vertical-padding: 4px;
>     --css-declaration-horizontal-padding: 6px;
>+
>+    --diff-addition-text-color: hsl(90, 61%, 25%);
>+    --diff-addition-background: hsl(70, 90%, 86%);
>+    --diff-deletion-text-color: hsl(0, 100%, 35%);
>+    --diff-deletion-background: hsl(5, 100%, 94%);
> }
> 
> body.window-inactive {
>@@ -327,6 +332,11 @@ body.window-inactive * {
>         --overlay-background: hsla(0, 0%, 24%, 0.9);
> 
>         --console-message-separator: var(--text-color-quaternary);
>+
>+        --diff-addition-text-color: hsl(70, 64%, 70%);
>+        --diff-addition-background: hsl(90, 40%, 19%);
>+        --diff-deletion-text-color: hsl(0, 84%, 75%);
>+        --diff-deletion-background: hsl(5, 40%, 28%);
>     }
> 
>     body.window-inactive {

Flags:

timothy: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 197538: 368855 | 368856 | 368857 | 368913 | 369079