Attachment 368783 Details for Bug 197518 – Patch

[patch] Patch

bug-197518-20190502101812.patch (text/plain), 1.92 KB, created by Daniel Bates on 2019-05-02 10:18:13 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Daniel Bates

Created: 2019-05-02 10:18:13 PDT

Size: 1.92 KB

patch

obsolete

>Subversion Revision: 244742
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index c89195bfb8a245ac4ff9b1bf7da6376b41b35181..d7de1fab0f76b424ea1f755b97ab8d62f7409b55 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,17 @@
>+2019-05-02  Daniel Bates  <dabates@apple.com>
>+
>+        [lldb-webkit] Support adding pretty-printing for qualified types
>+        https://bugs.webkit.org/show_bug.cgi?id=197518
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Remove all "::"s from the name of the specified type when computing the name for the Python classes
>+        that will provide summary and synthetic details as LLDB is not happy about registering such classes
>+        when they contain :: in their name.
>+
>+        * lldb/lldb_webkit.py:
>+        (addSummaryAndSyntheticFormattersForRawBitmaskType):
>+
> 2019-04-26  Stephanie Lewis  <slewis@apple.com>
> 
>         run-benchmarks should have an intial prep and restore env call for tasks that are too expensive to do for every iteration
>diff --git a/Tools/lldb/lldb_webkit.py b/Tools/lldb/lldb_webkit.py
>index cfcc6191fa3e433ef4986c04e59bdb0960ac6202..99bf88568bfd8ccec2bbc9fff1324d9715b9ce12 100644
>--- a/Tools/lldb/lldb_webkit.py
>+++ b/Tools/lldb/lldb_webkit.py
>@@ -44,8 +44,9 @@ def addSummaryAndSyntheticFormattersForRawBitmaskType(debugger, type_name, enume
> 
>     # Add the provider class and summary function to the global scope so that LLDB
>     # can find them.
>-    synthetic_provider_class_name = type_name + 'Provider'
>-    summary_provider_function_name = type_name + '_SummaryProvider'
>+    python_type_name = type_name.replace('::', '')  # Remove qualifications (e.g. WebCore::X becomes WebCoreX)
>+    synthetic_provider_class_name = python_type_name + 'Provider'
>+    summary_provider_function_name = python_type_name + '_SummaryProvider'
>     globals()[synthetic_provider_class_name] = GeneratedRawBitmaskProvider
>     globals()[summary_provider_function_name] = raw_bitmask_summary_provider
>

Actions: View | Formatted Diff | Diff

Attachments on bug 197518: 368783 | 368828