Attachment 368768 Details for Bug 196142 – Patch

[patch] Patch

bug-196142-20190502104842.patch (text/plain), 20.84 KB, created by Frédéric Wang (:fredw) on 2019-05-02 01:48:44 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Frédéric Wang (:fredw)

Created: 2019-05-02 01:48:44 PDT

Size: 20.84 KB

patch

obsolete

>Subversion Revision: 244868
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 70a44407fce85f7b7262deef6a0ebb9d78514973..69d11d4643eab380dfa085d104e97f7f030f1635 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,26 @@
>+2019-05-02  Frederic Wang  <fwang@igalia.com>
>+
>+        [GTK][WPE] Disable "thin", "thick", "medium" values of mfrac@linethickness at runtime
>+        https://bugs.webkit.org/show_bug.cgi?id=196142
>+
>+        This patch introduces some experimental runtime flag to let users
>+        disable MathML features that are removed from MathML Core [1]. For now,
>+        these features are only disabled on GTK and WPE ports. This patch also
>+        adds a condition to disable "thin", "thick", "medium" values of
>+        mfrac@linethickness at runtime as agreed in [2].
>+
>+        [1] https://mathml-refresh.github.io/mathml-core/
>+        [2] https://github.com/mathml-refresh/mathml/issues/4
>+
>+        Reviewed by Rob Buis.
>+
>+        No new tests, covered by frac-linethickness-0001.html
>+
>+        * mathml/MathMLFractionElement.cpp:
>+        (WebCore::MathMLFractionElement::lineThickness): Just do standard
>+        parsing for MathML lengths when non-core MathML features are disabled.
>+        * page/Settings.yaml: Add WebCore setting.
>+
> 2019-05-01  Jiewen Tan  <jiewen_tan@apple.com>
> 
>         [WebAuthN] Adopt SecurityOrigin::isMatchingRegistrableDomainSuffix()
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 4da338445b6d8457235a25e04ef0a0dc106f9787..b65e6c326004a5f7aa7ac87ebe7f3b594fe3711a 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,19 @@
>+2019-05-02  Frederic Wang  <fwang@igalia.com>
>+
>+        [GTK][WPE] Disable "thin", "thick", "medium" values of mfrac@linethickness at runtime
>+        https://bugs.webkit.org/show_bug.cgi?id=196142
>+
>+        This patch introduces some experimental runtime flag to let users
>+        disable MathML features that are removed from MathML Core [1]. For now,
>+        these features are only disabled on GTK and WPE ports.
>+
>+        [1] https://mathml-refresh.github.io/mathml-core/
>+
>+        Reviewed by Rob Buis.
>+
>+        * Shared/WebPreferences.yaml:
>+        * Shared/WebPreferencesDefaultValues.h:
>+
> 2019-05-01  Wenson Hsieh  <wenson_hsieh@apple.com>
> 
>         Add the ability to import WebKitAdditions snippets in WebKit.apinotes
>diff --git a/Source/WebKitLegacy/mac/ChangeLog b/Source/WebKitLegacy/mac/ChangeLog
>index 1e97046c8ba5c30d1f9af2651b51f251777a5df8..d924bdf2bc1a51803b18c6edd8252992135bb7d9 100644
>--- a/Source/WebKitLegacy/mac/ChangeLog
>+++ b/Source/WebKitLegacy/mac/ChangeLog
>@@ -1,3 +1,25 @@
>+2019-05-02  Frederic Wang  <fwang@igalia.com>
>+
>+        [GTK][WPE] Disable "thin", "thick", "medium" values of mfrac@linethickness at runtime
>+        https://bugs.webkit.org/show_bug.cgi?id=196142
>+
>+        This patch introduces some experimental runtime flag to let users
>+        disable MathML features that are removed from MathML Core [1]. For now,
>+        these features are only disabled on GTK and WPE ports.
>+
>+        [1] https://mathml-refresh.github.io/mathml-core/
>+
>+        Reviewed by Rob Buis.
>+
>+        * WebView/WebPreferenceKeysPrivate.h:
>+        * WebView/WebPreferences.mm:
>+        (+[WebPreferences initialize]):
>+        (-[WebPreferences coreMathMLEnabled]):
>+        (-[WebPreferences setCoreMathMLEnabled:]):
>+        * WebView/WebPreferencesPrivate.h:
>+        * WebView/WebView.mm:
>+        (-[WebView _preferencesChanged:]):
>+
> 2019-04-29  Alex Christensen  <achristensen@webkit.org>
> 
>         <rdar://problem/50299396> Fix internal High Sierra build
>diff --git a/Source/WebKitLegacy/win/ChangeLog b/Source/WebKitLegacy/win/ChangeLog
>index b0d1ee444af538687788ec858704d27a813454eb..1c8ff84ae057cb745b14d5551bb2a7acab73fb2a 100644
>--- a/Source/WebKitLegacy/win/ChangeLog
>+++ b/Source/WebKitLegacy/win/ChangeLog
>@@ -1,3 +1,26 @@
>+2019-05-02  Frederic Wang  <fwang@igalia.com>
>+
>+        [GTK][WPE] Disable "thin", "thick", "medium" values of mfrac@linethickness at runtime
>+        https://bugs.webkit.org/show_bug.cgi?id=196142
>+
>+        This patch introduces some experimental runtime flag to let users
>+        disable MathML features that are removed from MathML Core [1]. For now,
>+        these features are only disabled on GTK and WPE ports.
>+
>+        [1] https://mathml-refresh.github.io/mathml-core/
>+
>+        Reviewed by Rob Buis.
>+
>+        * Interfaces/IWebPreferencesPrivate.idl:
>+        * WebPreferenceKeysPrivate.h:
>+        * WebPreferences.cpp:
>+        (WebPreferences::initializeDefaultSettings):
>+        (WebPreferences::coreMathMLEnabled):
>+        (WebPreferences::setCoreMathMLEnabled):
>+        * WebPreferences.h:
>+        * WebView.cpp:
>+        (WebView::notifyPreferencesChanged):
>+
> 2019-04-24  Zalan Bujtas  <zalan@apple.com>
> 
>         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
>diff --git a/Source/WebCore/mathml/MathMLFractionElement.cpp b/Source/WebCore/mathml/MathMLFractionElement.cpp
>index 77988d5fbd99907cd01b13e9bc3b1ee08494fc3b..5311934b1988a8a88fcff751cb0ac3cd0b95446a 100644
>--- a/Source/WebCore/mathml/MathMLFractionElement.cpp
>+++ b/Source/WebCore/mathml/MathMLFractionElement.cpp
>@@ -30,6 +30,7 @@
> #if ENABLE(MATHML)
> 
> #include "RenderMathMLFraction.h"
>+#include "Settings.h"
> #include <wtf/IsoMallocInlines.h>
> 
> namespace WebCore {
>@@ -53,10 +54,15 @@ const MathMLElement::Length& MathMLFractionElement::lineThickness()
>     if (m_lineThickness)
>         return m_lineThickness.value();
> 
>+    auto& thickness = attributeWithoutSynchronization(linethicknessAttr);
>+    if (document().settings().coreMathMLEnabled()) {
>+        m_lineThickness = parseMathMLLength(thickness);
>+        return m_lineThickness.value();
>+    }
>+
>     // The MathML3 recommendation states that "medium" is the default thickness.
>     // However, it only states that "thin" and "thick" are respectively thiner and thicker.
>     // The MathML in HTML5 implementation note suggests 50% and 200% and these values are also used in Gecko.
>-    auto& thickness = attributeWithoutSynchronization(linethicknessAttr);
>     m_lineThickness = Length();
>     if (equalLettersIgnoringASCIICase(thickness, "thin")) {
>         m_lineThickness.value().type = LengthType::UnitLess;
>diff --git a/Source/WebCore/page/Settings.yaml b/Source/WebCore/page/Settings.yaml
>index e47d7eb4cb5d7c4ab3a121eb3ffe67a3a9accf59..d30c815e9cc68eb27367111619f49a712bb80225 100644
>--- a/Source/WebCore/page/Settings.yaml
>+++ b/Source/WebCore/page/Settings.yaml
>@@ -824,6 +824,10 @@ editableImagesEnabled:
> adClickAttributionEnabled:
>   initial: false
> 
>+coreMathMLEnabled:
>+  initial: false
>+  onChange: setNeedsRecalcStyleInAllFrames
>+
> blockingOfSmallPluginsEnabled:
>   initial: true
> 
>diff --git a/Source/WebKit/Shared/WebPreferences.yaml b/Source/WebKit/Shared/WebPreferences.yaml
>index cd9326eccef20f6e7fced89cda80fc8241a860b1..20156d0d1068e002efd5b32671fa7b28c068bf4d 100644
>--- a/Source/WebKit/Shared/WebPreferences.yaml
>+++ b/Source/WebKit/Shared/WebPreferences.yaml
>@@ -1650,6 +1650,13 @@ PageAtRuleSupportEnabled:
>   category: experimental
>   webcoreBinding: RuntimeEnabledFeatures
> 
>+CoreMathMLEnabled:
>+  type: bool
>+  defaultValue: DEFAULT_CORE_MATHML_ENABLED
>+  humanReadableName: "MathML Core"
>+  humanReadableDescription: "Disable features removed from the MathML Core spec."
>+  category: experimental
>+
> ApplePayRemoteUIEnabled:
>   category: internal
>   condition: ENABLE(APPLE_PAY_REMOTE_UI)
>diff --git a/Source/WebKit/Shared/WebPreferencesDefaultValues.h b/Source/WebKit/Shared/WebPreferencesDefaultValues.h
>index a5bcbd417bf306e93ab274442dba79be9fab5a58..3643966d5af8bca9f9eeed3e77b1eae0cffb9f72 100644
>--- a/Source/WebKit/Shared/WebPreferencesDefaultValues.h
>+++ b/Source/WebKit/Shared/WebPreferencesDefaultValues.h
>@@ -31,6 +31,12 @@
> #define DEFAULT_WEBKIT_TABSTOLINKS_ENABLED false
> #endif
> 
>+#if PLATFORM(GTK) || PLATFORM(WPE)
>+#define DEFAULT_CORE_MATHML_ENABLED true
>+#else
>+#define DEFAULT_CORE_MATHML_ENABLED false
>+#endif
>+
> #if ENABLE(SMOOTH_SCROLLING)
> #define DEFAULT_WEBKIT_SCROLL_ANIMATOR_ENABLED true
> #else
>diff --git a/Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h b/Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h
>index 2b5e73f0926215fff7f8b14af94623b6305aedae..1dcbc25ff5f83b88ba5200d8422565a23d1b1907 100644
>--- a/Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h
>+++ b/Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h
>@@ -268,3 +268,5 @@
> #define WebKitAdClickAttributionEnabledPreferenceKey @"WebKitAdClickAttributionEnabled"
> #define WebKitReferrerPolicyAttributeEnabledPreferenceKey @"WebKitReferrerPolicyAttributeEnabled"
> #define WebKitResizeObserverEnabledPreferenceKey @"WebKitResizeObserverEnabled"
>+#define WebKitCoreMathMLEnabledPreferenceKey @"WebKitCoreMathMLEnabled"
>+
>diff --git a/Source/WebKitLegacy/mac/WebView/WebPreferences.mm b/Source/WebKitLegacy/mac/WebView/WebPreferences.mm
>index fc524f7f6e8f1ecfa271686b18b8263eab109a5b..9f1c226fb98a015b497607a11d0fbc07ebfda97a 100644
>--- a/Source/WebKitLegacy/mac/WebView/WebPreferences.mm
>+++ b/Source/WebKitLegacy/mac/WebView/WebPreferences.mm
>@@ -691,6 +691,7 @@ public:
> #if ENABLE(RESIZE_OBSERVER)
>         @NO, WebKitResizeObserverEnabledPreferenceKey,
> #endif
>+        @NO, WebKitCoreMathMLEnabledPreferenceKey,
>         nil];
> 
> #if !PLATFORM(IOS_FAMILY)
>@@ -3456,6 +3457,17 @@ static NSString *classIBCreatorID = nil;
> {
>     [self _setBoolValue:flag forKey:WebKitResizeObserverEnabledPreferenceKey];
> }
>+
>+- (BOOL)coreMathMLEnabled
>+{
>+    return [self _boolValueForKey:WebKitCoreMathMLEnabledPreferenceKey];
>+}
>+
>+- (void)setCoreMathMLEnabled:(BOOL)flag
>+{
>+    [self _setBoolValue:flag forKey:WebKitCoreMathMLEnabledPreferenceKey];
>+}
>+
> @end
> 
> @implementation WebPreferences (WebInternal)
>diff --git a/Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h b/Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h
>index f4c5ff37f56e9e2b538438fed007309fdb93aa85..4c6581f98e0d8c5202cbcac40e8cfe248bc260e4 100644
>--- a/Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h
>+++ b/Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h
>@@ -603,6 +603,9 @@ extern NSString *WebPreferencesCacheModelChangedInternalNotification WEBKIT_DEPR
> - (void)setReferrerPolicyAttributeEnabled:(BOOL)flag;
> - (BOOL)referrerPolicyAttributeEnabled;
> 
>+- (void)setCoreMathMLEnabled:(BOOL)flag;
>+- (BOOL)coreMathMLEnabled;
>+
> @property (nonatomic) BOOL visualViewportAPIEnabled;
> @property (nonatomic) BOOL CSSOMViewScrollingAPIEnabled;
> @property (nonatomic) BOOL largeImageAsyncDecodingEnabled;
>@@ -635,6 +638,7 @@ extern NSString *WebPreferencesCacheModelChangedInternalNotification WEBKIT_DEPR
> @property (nonatomic) BOOL sourceBufferChangeTypeEnabled;
> @property (nonatomic) BOOL referrerPolicyAttributeEnabled;
> @property (nonatomic) BOOL resizeObserverEnabled;
>+@property (nonatomic) BOOL coreMathMLEnabled;
> 
> #if TARGET_OS_IPHONE
> @property (nonatomic) BOOL quickLookDocumentSavingEnabled;
>diff --git a/Source/WebKitLegacy/mac/WebView/WebView.mm b/Source/WebKitLegacy/mac/WebView/WebView.mm
>index 3998a5b9591d631df5a8b0a982a6b73632d607b6..16dd65bba1f40d96e2a39e6b903e880e82664044 100644
>--- a/Source/WebKitLegacy/mac/WebView/WebView.mm
>+++ b/Source/WebKitLegacy/mac/WebView/WebView.mm
>@@ -3214,6 +3214,8 @@ static bool needsSelfRetainWhileLoadingQuirk()
>     settings.setAnimatedImageAsyncDecodingEnabled([preferences animatedImageAsyncDecodingEnabled]);
>     settings.setMediaCapabilitiesEnabled([preferences mediaCapabilitiesEnabled]);
> 
>+    settings.setCoreMathMLEnabled([preferences coreMathMLEnabled]);
>+
>     RuntimeEnabledFeatures::sharedFeatures().setServerTimingEnabled([preferences serverTimingEnabled]);
> 
>     settings.setSelectionAcrossShadowBoundariesEnabled(preferences.selectionAcrossShadowBoundariesEnabled);
>diff --git a/Source/WebKitLegacy/win/Interfaces/IWebPreferencesPrivate.idl b/Source/WebKitLegacy/win/Interfaces/IWebPreferencesPrivate.idl
>index ed8b1ccaa9dc3905183da7015705d39c117aa35b..cb8dda4aefbdaa68b17beebe7195d0cbba2534cf 100644
>--- a/Source/WebKitLegacy/win/Interfaces/IWebPreferencesPrivate.idl
>+++ b/Source/WebKitLegacy/win/Interfaces/IWebPreferencesPrivate.idl
>@@ -240,4 +240,6 @@ interface IWebPreferencesPrivate7 : IWebPreferencesPrivate6
>     HRESULT setCrossOriginWindowPolicySupportEnabled([in] BOOL enabled);
>     HRESULT resizeObserverEnabled([out, retval] BOOL*);
>     HRESULT setResizeObserverEnabled([in] BOOL enabled);
>+    HRESULT coreMathMLEnabled([out, retval] BOOL* enabled);
>+    HRESULT setCoreMathMLEnabled([in] BOOL enabled);
> }
>diff --git a/Source/WebKitLegacy/win/WebPreferenceKeysPrivate.h b/Source/WebKitLegacy/win/WebPreferenceKeysPrivate.h
>index 413a6fdf2953fb62b3491481212c95d5468b1c60..ba662703ab86791702bad561e794a3878de8cf02 100644
>--- a/Source/WebKitLegacy/win/WebPreferenceKeysPrivate.h
>+++ b/Source/WebKitLegacy/win/WebPreferenceKeysPrivate.h
>@@ -207,3 +207,5 @@
> #define WebKitCSSOMViewScrollingAPIEnabledPreferenceKey "WebKitCSSOMViewScrollingAPIEnabled"
> 
> #define WebKitResizeObserverEnabledPreferenceKey "WebKitResizeObserverEnabled"
>+
>+#define WebKitCoreMathMLEnabledPreferenceKey "WebKitCoreMathMLEnabled"
>diff --git a/Source/WebKitLegacy/win/WebPreferences.cpp b/Source/WebKitLegacy/win/WebPreferences.cpp
>index 9023e3f4153109d771455c22ddd2a56f7e18a629..13948686bcfa140da9de9289c6ac4b46c40581da 100644
>--- a/Source/WebKitLegacy/win/WebPreferences.cpp
>+++ b/Source/WebKitLegacy/win/WebPreferences.cpp
>@@ -331,6 +331,8 @@ void WebPreferences::initializeDefaultSettings()
> 
>     CFDictionaryAddValue(defaults, CFSTR(WebKitResizeObserverEnabledPreferenceKey), kCFBooleanFalse);
> 
>+    CFDictionaryAddValue(defaults, CFSTR(WebKitCoreMathMLEnabledPreferenceKey), kCFBooleanFalse);
>+
>     defaultSettings = defaults;
> }
> 
>@@ -2201,6 +2203,20 @@ HRESULT WebPreferences::setCSSOMViewScrollingAPIEnabled(BOOL enabled)
>     return S_OK;
> }
> 
>+HRESULT WebPreferences::coreMathMLEnabled(_Out_ BOOL* enabled)
>+{
>+    if (!enabled)
>+        return E_POINTER;
>+    *enabled = boolValueForKey(WebKitCoreMathMLEnabledPreferenceKey);
>+    return S_OK;
>+}
>+
>+HRESULT WebPreferences::setCoreMathMLEnabled(BOOL enabled)
>+{
>+    setBoolValue(WebKitCoreMathMLEnabledPreferenceKey, enabled);
>+    return S_OK;
>+}
>+
> HRESULT WebPreferences::setApplicationId(BSTR applicationId)
> {
>     m_applicationId = String(applicationId).createCFString();
>diff --git a/Source/WebKitLegacy/win/WebPreferences.h b/Source/WebKitLegacy/win/WebPreferences.h
>index 6eba17c3e876595a9f0b491a8ecbef0c76633273..5ee6427b3532cd838c867296b4c3ace57b87f638 100644
>--- a/Source/WebKitLegacy/win/WebPreferences.h
>+++ b/Source/WebKitLegacy/win/WebPreferences.h
>@@ -285,6 +285,8 @@ public:
>     virtual HRESULT STDMETHODCALLTYPE setCrossOriginWindowPolicySupportEnabled(BOOL);
>     virtual HRESULT STDMETHODCALLTYPE resizeObserverEnabled(_Out_ BOOL*);
>     virtual HRESULT STDMETHODCALLTYPE setResizeObserverEnabled(BOOL);
>+    virtual HRESULT STDMETHODCALLTYPE coreMathMLEnabled(_Out_ BOOL*);
>+    virtual HRESULT STDMETHODCALLTYPE setCoreMathMLEnabled(BOOL);
> 
>     // WebPreferences
> 
>diff --git a/Source/WebKitLegacy/win/WebView.cpp b/Source/WebKitLegacy/win/WebView.cpp
>index 381f1a6ad6fd900933e552d1023a2ac581b7a27b..10fad7881c7e0ce5d92c5bbba0dee754c0f6338c 100644
>--- a/Source/WebKitLegacy/win/WebView.cpp
>+++ b/Source/WebKitLegacy/win/WebView.cpp
>@@ -5601,6 +5601,11 @@ HRESULT WebView::notifyPreferencesChanged(IWebNotification* notification)
>         return hr;
>     settings.setResizeObserverEnabled(!!enabled);
> 
>+    hr = prefsPrivate->coreMathMLEnabled(&enabled);
>+    if (FAILED(hr))
>+        return hr;
>+    settings.setCoreMathMLEnabled(!!enabled);
>+
>     return S_OK;
> }
> 
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 68cf46b40c9432d5048210d438c4c86bdb286fd2..5022fc68215f5c57efc98c2614b9194a7b818cff 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,22 @@
>+2019-05-02  Frederic Wang  <fwang@igalia.com>
>+
>+        [GTK][WPE] Disable "thin", "thick", "medium" values of mfrac@linethickness at runtime
>+        https://bugs.webkit.org/show_bug.cgi?id=196142
>+
>+        This patch introduces some experimental runtime flag to let users
>+        disable MathML features that are removed from MathML Core [1]. For now,
>+        these features are only disabled on GTK and WPE ports.
>+
>+        [1] https://mathml-refresh.github.io/mathml-core/
>+
>+        Reviewed by Rob Buis.
>+
>+        * DumpRenderTree/TestOptions.cpp:
>+        (TestOptions::TestOptions):
>+        * DumpRenderTree/TestOptions.h:
>+        * DumpRenderTree/mac/DumpRenderTree.mm:
>+        (setWebPreferencesForTestOptions):
>+
> 2019-05-01  Don Olmstead  <don.olmstead@sony.com>
> 
>         TestWebKitAPI config.h should be aware of what suite is being built
>diff --git a/Tools/DumpRenderTree/TestOptions.cpp b/Tools/DumpRenderTree/TestOptions.cpp
>index 0c93c80efd1483e96f350ee4f95318f0eab0ecf7..3ca91c4e320102e785ce32faccd1b018f3b3e5a8 100644
>--- a/Tools/DumpRenderTree/TestOptions.cpp
>+++ b/Tools/DumpRenderTree/TestOptions.cpp
>@@ -113,6 +113,8 @@ TestOptions::TestOptions(const std::string& pathOrURL, const std::string& absolu
>             adClickAttributionEnabled = parseBooleanTestHeaderValue(value);
>         else if (key == "experimental:ResizeObserverEnabled")
>             enableResizeObserver = parseBooleanTestHeaderValue(value);
>+        else if (key == "experimental:CoreMathMLEnabled")
>+            enableCoreMathML = parseBooleanTestHeaderValue(value);
>         pairStart = pairEnd + 1;
>     }
> }
>diff --git a/Tools/DumpRenderTree/TestOptions.h b/Tools/DumpRenderTree/TestOptions.h
>index d885edbdeb06a8bb67f4a01baf2b2bc53fc4c7d1..f4eb67197df340d289a732576b889b25c9671b65 100644
>--- a/Tools/DumpRenderTree/TestOptions.h
>+++ b/Tools/DumpRenderTree/TestOptions.h
>@@ -47,6 +47,7 @@ struct TestOptions {
>     bool enableCSSLogical { false };
>     bool adClickAttributionEnabled { false };
>     bool enableResizeObserver { false };
>+    bool enableCoreMathML { false };
>     std::string jscOptions;
> 
>     TestOptions(const std::string& pathOrURL, const std::string& absolutePath);
>diff --git a/Tools/DumpRenderTree/mac/DumpRenderTree.mm b/Tools/DumpRenderTree/mac/DumpRenderTree.mm
>index 49353229f7d521e3607e32285595975d54e8a90a..9fb0a47db19d405016e83766cae545ddfedf2a49 100644
>--- a/Tools/DumpRenderTree/mac/DumpRenderTree.mm
>+++ b/Tools/DumpRenderTree/mac/DumpRenderTree.mm
>@@ -1019,6 +1019,7 @@ static void setWebPreferencesForTestOptions(const TestOptions& options)
>     preferences.CSSLogicalEnabled = options.enableCSSLogical;
>     preferences.adClickAttributionEnabled = options.adClickAttributionEnabled;
>     preferences.resizeObserverEnabled = options.enableResizeObserver;
>+    preferences.coreMathMLEnabled = options.enableCoreMathML;
> }
> 
> // Called once on DumpRenderTree startup.
>diff --git a/LayoutTests/imported/w3c/ChangeLog b/LayoutTests/imported/w3c/ChangeLog
>index b67bdb6e9855ae45022b389f403c9a0f2ed1d24c..e210bae9ac6e74400bc8d3d3adb2f4acc9261693 100644
>--- a/LayoutTests/imported/w3c/ChangeLog
>+++ b/LayoutTests/imported/w3c/ChangeLog
>@@ -1,3 +1,24 @@
>+2019-05-02  Frederic Wang  <fwang@igalia.com>
>+
>+        [GTK][WPE] Disable "thin", "thick", "medium" values of mfrac@linethickness at runtime
>+        https://bugs.webkit.org/show_bug.cgi?id=196142
>+
>+        This patch introduces some experimental runtime flag to let users
>+        disable MathML features that are removed from MathML Core [1]. For now,
>+        these features are only disabled on GTK and WPE ports. This patch also
>+        adds a condition to disable "thin", "thick", "medium" values of
>+        mfrac@linethickness at runtime as agreed in [2].
>+
>+        [1] https://mathml-refresh.github.io/mathml-core/
>+        [2] https://github.com/mathml-refresh/mathml/issues/4
>+
>+        Reviewed by Rob Buis.
>+
>+        * web-platform-tests/mathml/presentation-markup/fractions/frac-linethickness-001.html:
>+        Explicitly enable deprecated features in this test. It should be moved
>+        back to WebKit's test suite if/when it is updated in the upstream WPT
>+        repository so also add a reminder for the next synchronization.
>+
> 2019-05-01  Darin Adler  <darin@apple.com>
> 
>         WebKit has too much of its own UTF-8 code and should rely more on ICU's UTF-8 support
>diff --git a/LayoutTests/imported/w3c/web-platform-tests/mathml/presentation-markup/fractions/frac-linethickness-001.html b/LayoutTests/imported/w3c/web-platform-tests/mathml/presentation-markup/fractions/frac-linethickness-001.html
>index 83e15c83dc0bcb911eb52a6b74b86a13c2f1e31e..8ee991b3bf98be8a643dd8785b184a2bbfc36b84 100644
>--- a/LayoutTests/imported/w3c/web-platform-tests/mathml/presentation-markup/fractions/frac-linethickness-001.html
>+++ b/LayoutTests/imported/w3c/web-platform-tests/mathml/presentation-markup/fractions/frac-linethickness-001.html
>@@ -1,4 +1,6 @@
>-<!DOCTYPE html>
>+<!DOCTYPE html> 
>+
> <html>
>   <head>
>     <meta charset="utf-8">

Actions: View | Formatted Diff | Diff

Attachments on bug 196142: 365712 | 365723 | 365824 | 365826 | 366260 | 368768