Attachment 368714 Details for Bug 197438 – Patch

[patch] Patch

bug-197438-20190501143718.patch (text/plain), 1.87 KB, created by Wenson Hsieh on 2019-05-01 14:37:18 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Wenson Hsieh

Created: 2019-05-01 14:37:18 PDT

Size: 1.87 KB

patch

obsolete

>Subversion Revision: 244840
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index 8525a413c643504f40e12589ccca23c21ecadc58..21505a7193a1930634c8fb3b1ed937f505169bb1 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,15 @@
>+2019-05-01  Wenson Hsieh  <wenson_hsieh@apple.com>
>+
>+        REGRESSION(r244494): editing/pasteboard/5761530-1.html is flaky due to a simple line layout bug
>+        https://bugs.webkit.org/show_bug.cgi?id=197438
>+        <rdar://problem/50348091>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Work around the simple line layout bug in the flaky layout test by disabling simple line layout.
>+
>+        * editing/pasteboard/5761530-1.html:
>+
> 2019-04-28  Wenson Hsieh  <wenson_hsieh@apple.com>
> 
>         [iOS] Add a version of viewport shrink-to-fit heuristics that preserves page layout
>diff --git a/LayoutTests/editing/pasteboard/5761530-1.html b/LayoutTests/editing/pasteboard/5761530-1.html
>index a0884da51b1e03873455de59e255fd0fe307bc89..903fa5d6667986aed964348810d107ceaf976f7e 100644
>--- a/LayoutTests/editing/pasteboard/5761530-1.html
>+++ b/LayoutTests/editing/pasteboard/5761530-1.html
>@@ -1,8 +1,10 @@
> <div id="description">This tests to see that tabs are put into tab spans when they are copied individually.  The pasted tab should be inside of a tab span, not a style span.  To run the test manually, paste and then inspect the editable region, and ensure that there is a tab span at the beginning of the editable div.</div>
> <div id="edit" contenteditable="true"><span class="Apple-tab-span" style="white-space:pre;">	</span>xxx</div>
> <script>
>-if (window.testRunner)
>-	window.testRunner.dumpAsText();
>+if (window.testRunner && window.internals) {
>+    window.testRunner.dumpAsText();
>+    internals.settings.setSimpleLineLayoutEnabled(false);
>+}
> edit = document.getElementById("edit");
> 
> window.getSelection().setPosition(edit, 0);

Actions: View | Formatted Diff | Diff

Attachments on bug 197438: 368708 | 368714