Attachment 368707 Details for Bug 197399 – Patch

[patch] Patch

bug-197399-20190501141103.patch (text/plain), 1.51 KB, created by Alex Christensen on 2019-05-01 14:11:04 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Alex Christensen

Created: 2019-05-01 14:11:04 PDT

Size: 1.51 KB

patch

obsolete

>Index: Source/WebKit/ChangeLog
>===================================================================
>--- Source/WebKit/ChangeLog	(revision 244848)
>+++ Source/WebKit/ChangeLog	(working copy)
>@@ -1,3 +1,17 @@
>+2019-05-01  Alex Christensen  <achristensen@webkit.org>
>+
>+        Protect against null crash in fetchDiskCacheEntries
>+        https://bugs.webkit.org/show_bug.cgi?id=197399
>+        <rdar://problem/47759337>
>+
>+        Reviewed by Antti Koivisto.
>+
>+        If the call to Entry::decodeStorageRecord returns nullptr in Storage::traverse, do not call the traverseHandler, which expects
>+        that when it is called with nullptr that is the end of the traversal.
>+
>+        * NetworkProcess/cache/NetworkCache.cpp:
>+        (WebKit::NetworkCache::Cache::traverse):
>+
> 2019-05-01  Dean Jackson  <dino@apple.com>
> 
>         Link Previews that use WKImagePreviewViewController are not always scaled correctly
>Index: Source/WebKit/NetworkProcess/cache/NetworkCache.cpp
>===================================================================
>--- Source/WebKit/NetworkProcess/cache/NetworkCache.cpp	(revision 244824)
>+++ Source/WebKit/NetworkProcess/cache/NetworkCache.cpp	(working copy)
>@@ -478,10 +478,8 @@ void Cache::traverse(Function<void(const
>         }
> 
>         auto entry = Entry::decodeStorageRecord(*record);
>-        if (!entry) {
>-            traverseHandler(nullptr);
>+        if (!entry)
>             return;
>-        }
> 
>         TraversalEntry traversalEntry { *entry, recordInfo };
>         traverseHandler(&traversalEntry);

Actions: View | Formatted Diff | Diff

Attachments on bug 197399: 368530 | 368537 | 368707