Attachment 368681 Details for Bug 197444 – Patch

[patch] Patch

bug-197444-20190501121226.patch (text/plain), 3.46 KB, created by Michael Catanzaro on 2019-05-01 10:12:27 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Michael Catanzaro

Created: 2019-05-01 10:12:27 PDT

Size: 3.46 KB

patch

obsolete

>Subversion Revision: 244805
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index c1ca7a22d5a7c6189503ad8f29bb231dfbb5f54f..7a73d5970dd2e1d612ce02f398527fcff0002710 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,18 @@
>+2019-05-01  Michael Catanzaro  <mcatanzaro@igalia.com>
>+
>+        Office365 showing older version & Microsoft Teams recommends Chrome / Firefox
>+        https://bugs.webkit.org/show_bug.cgi?id=197444
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Add user agent quirks for Office 365 and Microsoft Teams, which have lost the right to
>+        receive an accurate user agent from WebKit.
>+
>+        Also, opportunistically remame WebKitGTK+ to WebKitGTK in this file.
>+
>+        * platform/UserAgentQuirks.cpp:
>+        (WebCore::urlRequiresMacintoshPlatform):
>+
> 2019-04-30  Commit Queue  <commit-queue@webkit.org>
> 
>         Unreviewed, rolling out r244773.
>diff --git a/Source/WebCore/platform/UserAgentQuirks.cpp b/Source/WebCore/platform/UserAgentQuirks.cpp
>index 04e06af639cc3bfd36a6cabc0a2e7bec1ae82ce9..bf544c2d66fa2796521256935409a16c4bd5ddcb 100644
>--- a/Source/WebCore/platform/UserAgentQuirks.cpp
>+++ b/Source/WebCore/platform/UserAgentQuirks.cpp
>@@ -75,38 +75,48 @@ static bool urlRequiresMacintoshPlatform(const URL& url)
>     String domain = url.host().toString();
>     String baseDomain = topPrivatelyControlledDomain(domain);
> 
>-    // At least finance.yahoo.com displays a mobile version with WebKitGTK+'s standard user agent.
>+    // At least finance.yahoo.com displays a mobile version with WebKitGTK's standard user agent.
>     if (baseDomain == "yahoo.com")
>         return true;
> 
>-    // taobao.com displays a mobile version with WebKitGTK+'s standard user agent.
>+    // taobao.com displays a mobile version with WebKitGTK's standard user agent.
>     if (baseDomain == "taobao.com")
>         return true;
> 
>-    // web.whatsapp.com completely blocks users with WebKitGTK+'s standard user agent.
>+    // web.whatsapp.com completely blocks users with WebKitGTK's standard user agent.
>     if (baseDomain == "whatsapp.com")
>         return true;
> 
>-    // paypal.com completely blocks users with WebKitGTK+'s standard user agent.
>+    // paypal.com completely blocks users with WebKitGTK's standard user agent.
>     if (baseDomain == "paypal.com")
>         return true;
> 
>     // chase.com displays a huge "please update your browser" warning with
>-    // WebKitGTK+'s standard user agent.
>+    // WebKitGTK's standard user agent.
>     if (baseDomain == "chase.com")
>         return true;
> 
>-    // Microsoft Outlook Web App forces users with WebKitGTK+'s standard user
>+    // Microsoft Outlook Web App forces users with WebKitGTK's standard user
>     // agent to use the light version. Earlier versions even blocks users from
>     // accessing the calendar.
>     if (domain == "outlook.live.com" || domain == "mail.ntu.edu.tw")
>         return true;
> 
>-    // Google Docs shows a scary unsupported browser warning with WebKitGTK+'s
>+    // Google Docs shows a scary unsupported browser warning with WebKitGTK's
>     // standard user agent.
>     if (domain == "docs.google.com")
>         return true;
> 
>+    // Office 365 displays an awful fallback website with WebKitGTK's standard
>+    // user agent.
>+    if (baseDomain == "office365.com")
>+        return true;
>+
>+    // Microsoft Teams completely blocks users with WebKitGTK's standard user
>+    // agent.
>+    if (domain == "teams.microsoft.com")
>+        return true;
>+
>     return false;
> }
>

Actions: View | Formatted Diff | Diff

Attachments on bug 197444: 368681