Attachment 368639 Details for Bug 197450 – Patch

[patch] Patch

bug-197450-20190501111316.patch (text/plain), 1.60 KB, created by Dean Jackson on 2019-04-30 18:13:17 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Dean Jackson

Created: 2019-04-30 18:13:17 PDT

Size: 1.60 KB

patch

obsolete

>Subversion Revision: 244792
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index dc20718f77b75ab98277efafb981267e6d710bf6..a99eb3259af43d5638b3ca92674691c75686e7ce 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,17 @@
>+2019-04-30  Dean Jackson  <dino@apple.com>
>+
>+        Link Previews that use WKImagePreviewViewController are not always scaled correctly
>+        https://bugs.webkit.org/show_bug.cgi?id=197450
>+        <rdar://problem/50357695>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Tell the UIImageView that we create in WKImagePreviewViewController to use
>+        a filling scaling method.
>+
>+        * UIProcess/WKImagePreviewViewController.mm:
>+        (-[WKImagePreviewViewController initWithCGImage:defaultActions:elementInfo:]):
>+
> 2019-04-30  Tim Horton  <timothy_horton@apple.com>
> 
>         Long-standing rare crash under -[WKWebView _web_immediateActionAnimationControllerForHitTestResultInternal...]
>diff --git a/Source/WebKit/UIProcess/WKImagePreviewViewController.mm b/Source/WebKit/UIProcess/WKImagePreviewViewController.mm
>index 704b82cfef7483204a1286406e22a749b982e0df..ce4065a6560202fde721d05256cd8171db65c0c3 100644
>--- a/Source/WebKit/UIProcess/WKImagePreviewViewController.mm
>+++ b/Source/WebKit/UIProcess/WKImagePreviewViewController.mm
>@@ -53,6 +53,7 @@
>     _image = image;
> 
>     _imageView = adoptNS([[UIImageView alloc] initWithFrame:CGRectZero]);
>+    _imageView.get().contentMode = UIViewContentModeScaleAspectFill;
>     RetainPtr<UIImage> uiImage = adoptNS([[UIImage alloc] initWithCGImage:_image.get()]);
>     [_imageView setImage:uiImage.get()];
>

Flags:

wenson_hsieh: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 197450: 368639