Attachment 368611 Details for Bug 197439 – PATCH

[patch] PATCH

197439.diff (text/plain), 2.13 KB, created by Basuke Suzuki on 2019-04-30 14:08:19 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Basuke Suzuki

Created: 2019-04-30 14:08:19 PDT

Size: 2.13 KB

patch

obsolete

>diff --git a/Source/JavaScriptCore/ChangeLog b/Source/JavaScriptCore/ChangeLog
>index 38ccae2b96e..3b5ec9e5edd 100644
>--- a/Source/JavaScriptCore/ChangeLog
>+++ b/Source/JavaScriptCore/ChangeLog
>@@ -1,3 +1,15 @@
>+2019-04-30  Basuke Suzuki  <basuke.suzuki@sony.com>
>+
>+        [PlayStation] targetListingMap is not update when RemoteInspector has started after target.
>+        https://bugs.webkit.org/show_bug.cgi?id=197439
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        When RemoteInspector starts after targets, this method is called to update targetListingMap.
>+
>+        * inspector/remote/socket/RemoteInspectorSocket.cpp:
>+        (Inspector::RemoteInspector::updateAutomaticInspectionCandidate):
>+
> 2019-04-29  Yusuke Suzuki  <ysuzuki@apple.com>
> 
>         JITStubRoutineSet wastes 180KB of HashTable capacity on can.com
>diff --git a/Source/JavaScriptCore/inspector/remote/socket/RemoteInspectorSocket.cpp b/Source/JavaScriptCore/inspector/remote/socket/RemoteInspectorSocket.cpp
>index b431df0a7f4..e8f492a09d0 100644
>--- a/Source/JavaScriptCore/inspector/remote/socket/RemoteInspectorSocket.cpp
>+++ b/Source/JavaScriptCore/inspector/remote/socket/RemoteInspectorSocket.cpp
>@@ -184,8 +184,26 @@ void RemoteInspector::pushListingsSoon()
>     });
> }
> 
>-void RemoteInspector::updateAutomaticInspectionCandidate(RemoteInspectionTarget*)
>+void RemoteInspector::updateAutomaticInspectionCandidate(RemoteInspectionTarget* target)
> {
>+    LockHolder lock(m_mutex);
>+
>+    ASSERT(target);
>+    auto targetIdentifier = target->targetIdentifier();
>+    if (!targetIdentifier)
>+        return;
>+
>+    auto result = m_targetMap.set(targetIdentifier, target);
>+    ASSERT_UNUSED(result, !result.isNewEntry);
>+
>+    // If the target has just allowed remote control, then the listing won't exist yet.
>+    // If the target has no identifier remove the old listing.
>+    if (auto targetListing = listingForTarget(*target))
>+        m_targetListingMap.set(targetIdentifier, targetListing);
>+    else
>+        m_targetListingMap.remove(targetIdentifier);
>+    // FIXME: Implement automatic inspection.
>+    pushListingsSoon();
> }
> 
> void RemoteInspector::sendAutomaticInspectionCandidateMessage()

Actions: View | Formatted Diff | Diff

Attachments on bug 197439: 368608 | 368611 | 368628 | 368635 | 368703 | 368721 | 368737