Attachment 368563 Details for Bug 197415 – Patch

[patch] Patch

bug-197415-20190430170837.patch (text/plain), 2.80 KB, created by Ludovico de Nittis on 2019-04-30 08:08:39 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Ludovico de Nittis

Created: 2019-04-30 08:08:39 PDT

Size: 2.80 KB

patch

obsolete

>Subversion Revision: 244770
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index f6cc3480ec1cee64f24d7a61a5407e0296ceea02..d3bc66a362e28e8d553b4f7da19def0490190610 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,15 @@
>+2019-04-30  Ludovico de Nittis  <ludovico.denittis@collabora.com>
>+
>+        [WPE][Qt] Use C++17 instead of C++14
>+        https://bugs.webkit.org/show_bug.cgi?id=197415
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        There was a regression introduced with the commit https://bugs.webkit.org/show_bug.cgi?id=197131
>+        The WPE Qt port was not updated to C++17 and this leaded to a compilation error.
>+
>+        * PlatformWPE.cmake:
>+
> 2019-04-30  Carlos Garcia Campos  <cgarcia@igalia.com>
> 
>         REGRESSION(r244750): [GTK][WPE] Network process is crashing in all layout tests
>diff --git a/Source/WebKit/PlatformWPE.cmake b/Source/WebKit/PlatformWPE.cmake
>index 8f4948e289ebcdc9e3dae5fc77db1e0426b9fc6b..43b7daec4817438fce58de10bb4132b04959ea6d 100644
>--- a/Source/WebKit/PlatformWPE.cmake
>+++ b/Source/WebKit/PlatformWPE.cmake
>@@ -391,7 +391,7 @@ if (ENABLE_WPE_QT_API)
>     set_target_properties(qtwpe PROPERTIES
>         OUTPUT_NAME qtwpe
>         AUTOMOC ON
>-        CXX_STANDARD 14
>+        CXX_STANDARD 17
>     )
>     target_compile_definitions(qtwpe PUBLIC QT_NO_KEYWORDS=1)
>     target_link_libraries(qtwpe ${qtwpe_LIBRARIES})
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 50fa10753c800e3d16d9f987a700007624e556d0..5ab3e7adb5282e64e6c9c4fea1cac95b3989cfbb 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,15 @@
>+2019-04-30  Ludovico de Nittis  <ludovico.denittis@collabora.com>
>+
>+        [WPE][Qt] Use C++17 instead of C++14
>+        https://bugs.webkit.org/show_bug.cgi?id=197415
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        There was a regression introduced with the commit https://bugs.webkit.org/show_bug.cgi?id=197131
>+        The WPE Qt port was not updated to C++17 and this leaded to a compilation error.
>+
>+        * TestWebKitAPI/glib/CMakeLists.txt:
>+
> 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
> 
>         [ews-build] Enable webkitpy queue on new EWS
>diff --git a/Tools/TestWebKitAPI/glib/CMakeLists.txt b/Tools/TestWebKitAPI/glib/CMakeLists.txt
>index 7cf2177888ad9a69b512d9fb32eaafea7390a6a6..2a743a71893401849f541d434efb8d3f8e776ddc 100644
>--- a/Tools/TestWebKitAPI/glib/CMakeLists.txt
>+++ b/Tools/TestWebKitAPI/glib/CMakeLists.txt
>@@ -158,7 +158,7 @@ macro(ADD_WPE_QT_TEST test_name)
>     set_target_properties(${test_name} PROPERTIES
>         RUNTIME_OUTPUT_DIRECTORY ${CMAKE_RUNTIME_OUTPUT_DIRECTORY}/TestWebKitAPI/WPEQt
>         AUTOMOC ON
>-        CXX_STANDARD 14
>+        CXX_STANDARD 17
>     )
>     target_compile_definitions(${test_name} PUBLIC QT_NO_KEYWORDS=1)
>     target_link_libraries(${test_name} ${WPEQtAPITest_LIBRARIES})

Actions: View | Formatted Diff | Diff

Attachments on bug 197415: 368563