Attachment 368555 Details for Bug 197412 – Patch

[patch] Patch

bug-197412-20190430081945.patch (text/plain), 1.76 KB, created by Michael Catanzaro on 2019-04-30 06:19:45 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Michael Catanzaro

Created: 2019-04-30 06:19:45 PDT

Size: 1.76 KB

patch

obsolete

>Subversion Revision: 244767
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 02b7ae51af26ed7847386bcba298e4ec645b3c0f..90211ee2ab35a5d0e1f78b6deb6605f10fea3442 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,17 @@
>+2019-04-30  Michael Catanzaro  <mcatanzaro@igalia.com>
>+
>+        WebCore::StyleColorScheme should not have explicitly-declared copy constructor
>+        https://bugs.webkit.org/show_bug.cgi?id=197412
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Either we need to explicitly declare a copy assignment operator here, or the copy
>+        constructor needs to be removed. Having one without the other causes a huge warning spam
>+        with GCC 9. In this case, the copy constructor is redundant because it's identical to an
>+        implicitly-declared copy constructor, so let's just remove it.
>+
>+        * rendering/style/StyleColorScheme.h:
>+
> 2019-04-30  Carlos Garcia Campos  <cgarcia@igalia.com>
> 
>         [GTK] Support prefers-color-scheme media query
>diff --git a/Source/WebCore/rendering/style/StyleColorScheme.h b/Source/WebCore/rendering/style/StyleColorScheme.h
>index 521ee52616daac68696a2d4f6e721713d9a31f9a..ed30a8af715d2e800278cdd285f9c733ea2aacba 100644
>--- a/Source/WebCore/rendering/style/StyleColorScheme.h
>+++ b/Source/WebCore/rendering/style/StyleColorScheme.h
>@@ -36,11 +36,6 @@ class StyleColorScheme {
> public:
>     StyleColorScheme() { }
> 
>-    StyleColorScheme(const StyleColorScheme& other)
>-        : m_colorScheme(other.m_colorScheme)
>-        , m_allowsTransformations(other.m_allowsTransformations)
>-    { }
>-
>     StyleColorScheme(OptionSet<ColorScheme> colorScheme, bool allowsTransformations)
>         : m_colorScheme(colorScheme)
>         , m_allowsTransformations(allowsTransformations)

Actions: View | Formatted Diff | Diff

Attachments on bug 197412: 368555