Attachment 368543 Details for Bug 197406 – Patch

[patch] Patch

wk2-network-process-crash.diff (text/plain), 1.59 KB, created by Carlos Garcia Campos on 2019-04-30 01:34:08 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Carlos Garcia Campos

Created: 2019-04-30 01:34:08 PDT

Size: 1.59 KB

patch

obsolete

>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index b20332c1a57..0913cf27592 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,16 @@
>+2019-04-30  Carlos Garcia Campos  <cgarcia@igalia.com>
>+
>+        REGRESSION(r244750): [GTK][WPE] Network process is crashing in all layout tests
>+        https://bugs.webkit.org/show_bug.cgi?id=197406
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Do not trasnfer ownership of cachePath to traverseDirectory() lambda, since it's passed also as first argument
>+        and it can be passed as a reference.
>+
>+        * NetworkProcess/cache/NetworkCacheStorage.cpp:
>+        (WebKit::NetworkCache::Storage::deleteOldVersions):
>+
> 2019-04-29  Truitt Savell  <tsavell@apple.com>
> 
>         Unreviewed, rolling out r244755.
>diff --git a/Source/WebKit/NetworkProcess/cache/NetworkCacheStorage.cpp b/Source/WebKit/NetworkProcess/cache/NetworkCacheStorage.cpp
>index 0f5a9fec11b..bbfc649890f 100644
>--- a/Source/WebKit/NetworkProcess/cache/NetworkCacheStorage.cpp
>+++ b/Source/WebKit/NetworkProcess/cache/NetworkCacheStorage.cpp
>@@ -1110,7 +1110,7 @@ void Storage::shrink()
> void Storage::deleteOldVersions()
> {
>     backgroundIOQueue().dispatch([cachePath = basePath()] () mutable {
>-        traverseDirectory(cachePath, [cachePath = WTFMove(cachePath)](const String& subdirName, DirectoryEntryType type) {
>+        traverseDirectory(cachePath, [&cachePath](const String& subdirName, DirectoryEntryType type) {
>             if (type != DirectoryEntryType::Directory)
>                 return;
>             if (!subdirName.startsWith(versionDirectoryPrefix))

Flags:

zan: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 197406: 368543